Merge remote-tracking branch 'tmil/RemoveObsoleteMethods' into v4

Author: angularsen

Common/GeneratedCode/Quantities/Acceleration.Common.g.cs

@@ -82,21 +82,11 @@ static Acceleration()
             BaseDimensions = new BaseDimensions(1, 0, -2, 0, 0, 0, 0);
         }
 
-        /// <summary>
-        ///     Creates the quantity with the given value in the base unit MeterPerSecondSquared.
-        /// </summary>
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public Acceleration(double meterspersecondsquared)
-        {
-            _value = Convert.ToDouble(meterspersecondsquared);
-            _unit = BaseUnit;
-        }
-
         /// <summary>
         ///     Creates the quantity with the given numeric value and unit.
         /// </summary>
         /// <param name="numericValue">Numeric value.</param>
-        /// <param name="unit">Unit representation.</param>
+        /// <param name="unit">The unit representation to contruct this quantity with.</param>
         /// <remarks>Value parameter cannot be named 'value' due to constraint when targeting Windows Runtime Component.</remarks>
 #if WINDOWS_UWP
         private
@@ -109,33 +99,6 @@ public Acceleration(double meterspersecondsquared)
             _unit = unit;
         }
 
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit MeterPerSecondSquared.
-        /// </summary>
-        /// <param name="meterspersecondsquared">Value assuming base unit MeterPerSecondSquared.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        Acceleration(long meterspersecondsquared) : this(Convert.ToDouble(meterspersecondsquared), BaseUnit) { }
-
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        // Windows Runtime Component does not support decimal type
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit MeterPerSecondSquared.
-        /// </summary>
-        /// <param name="meterspersecondsquared">Value assuming base unit MeterPerSecondSquared.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        Acceleration(decimal meterspersecondsquared) : this(Convert.ToDouble(meterspersecondsquared), BaseUnit) { }
-
         #region Properties
 
         /// <summary>
@@ -144,7 +107,7 @@ public Acceleration(double meterspersecondsquared)
         public static QuantityType QuantityType => QuantityType.Acceleration;
 
         /// <summary>
-        ///     The base unit representation of this quantity for the numeric value stored internally. All conversions go via this value.
+        ///     The base unit of Acceleration, which is MeterPerSecondSquared. All conversions go via this value.
         /// </summary>
         public static AccelerationUnit BaseUnit => AccelerationUnit.MeterPerSecondSquared;
 
@@ -469,16 +432,6 @@ int CompareTo(Acceleration other)
             return _value.CompareTo(other.AsBaseNumericType(this.Unit));
         }
 
-        [Obsolete("It is not safe to compare equality due to using System.Double as the internal representation. It is very easy to get slightly different values due to floating point operations. Instead use Equals($quantityName, double, ComparisonType) to provide the max allowed absolute or relative error.")]
-        public override bool Equals(object obj)
-        {
-            if(obj is null || !(obj is Acceleration))
-                return false;
-
-            var objQuantity = (Acceleration)obj;
-            return _value.Equals(objQuantity.AsBaseNumericType(this.Unit));
-        }
-
         /// <summary>
         ///     <para>
         ///     Compare equality to another Acceleration within the given absolute or relative tolerance.
@@ -530,20 +483,6 @@ public bool Equals(Acceleration other, double tolerance, ComparisonType comparis
             return UnitsNet.Comparison.Equals(thisValue, otherValueInThisUnits, tolerance, comparisonType);
         }
 
-        /// <summary>
-        ///     Compare equality to another Acceleration by specifying a max allowed difference.
-        ///     Note that it is advised against specifying zero difference, due to the nature
-        ///     of floating point operations and using System.Double internally.
-        /// </summary>
-        /// <param name="other">Other quantity to compare to.</param>
-        /// <param name="maxError">Max error allowed.</param>
-        /// <returns>True if the difference between the two values is not greater than the specified max.</returns>
-        [Obsolete("Please use the Equals(Acceleration, double, ComparisonType) overload. This method will be removed in a future version.")]
-        public bool Equals(Acceleration other, Acceleration maxError)
-        {
-            return Math.Abs(_value - other.AsBaseNumericType(this.Unit)) <= maxError.AsBaseNumericType(this.Unit);
-        }
-
         /// <summary>
         ///     Returns the hash code for this instance.
         /// </summary>
@@ -694,12 +633,6 @@ public static AccelerationUnit ParseUnit(string str)
 
         #endregion
 
-        /// <summary>
-        ///     Set the default unit used by ToString(). Default is MeterPerSecondSquared
-        /// </summary>
-        [Obsolete("This is no longer used since we will instead use the quantity's Unit value as default.")]
-        public static AccelerationUnit ToStringDefaultUnit { get; set; } = AccelerationUnit.MeterPerSecondSquared;
-
         /// <summary>
         ///     Get default string representation of value and unit.
         /// </summary>

Common/GeneratedCode/Quantities/AmountOfSubstance.Common.g.cs

@@ -82,21 +82,11 @@ static AmountOfSubstance()
             BaseDimensions = new BaseDimensions(0, 0, 0, 0, 0, 1, 0);
         }
 
-        /// <summary>
-        ///     Creates the quantity with the given value in the base unit Mole.
-        /// </summary>
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public AmountOfSubstance(double moles)
-        {
-            _value = Convert.ToDouble(moles);
-            _unit = BaseUnit;
-        }
-
         /// <summary>
         ///     Creates the quantity with the given numeric value and unit.
         /// </summary>
         /// <param name="numericValue">Numeric value.</param>
-        /// <param name="unit">Unit representation.</param>
+        /// <param name="unit">The unit representation to contruct this quantity with.</param>
         /// <remarks>Value parameter cannot be named 'value' due to constraint when targeting Windows Runtime Component.</remarks>
 #if WINDOWS_UWP
         private
@@ -109,33 +99,6 @@ public AmountOfSubstance(double moles)
             _unit = unit;
         }
 
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit Mole.
-        /// </summary>
-        /// <param name="moles">Value assuming base unit Mole.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        AmountOfSubstance(long moles) : this(Convert.ToDouble(moles), BaseUnit) { }
-
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        // Windows Runtime Component does not support decimal type
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit Mole.
-        /// </summary>
-        /// <param name="moles">Value assuming base unit Mole.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        AmountOfSubstance(decimal moles) : this(Convert.ToDouble(moles), BaseUnit) { }
-
         #region Properties
 
         /// <summary>
@@ -144,7 +107,7 @@ public AmountOfSubstance(double moles)
         public static QuantityType QuantityType => QuantityType.AmountOfSubstance;
 
         /// <summary>
-        ///     The base unit representation of this quantity for the numeric value stored internally. All conversions go via this value.
+        ///     The base unit of AmountOfSubstance, which is Mole. All conversions go via this value.
         /// </summary>
         public static AmountOfSubstanceUnit BaseUnit => AmountOfSubstanceUnit.Mole;
 
@@ -488,16 +451,6 @@ int CompareTo(AmountOfSubstance other)
             return _value.CompareTo(other.AsBaseNumericType(this.Unit));
         }
 
-        [Obsolete("It is not safe to compare equality due to using System.Double as the internal representation. It is very easy to get slightly different values due to floating point operations. Instead use Equals($quantityName, double, ComparisonType) to provide the max allowed absolute or relative error.")]
-        public override bool Equals(object obj)
-        {
-            if(obj is null || !(obj is AmountOfSubstance))
-                return false;
-
-            var objQuantity = (AmountOfSubstance)obj;
-            return _value.Equals(objQuantity.AsBaseNumericType(this.Unit));
-        }
-
         /// <summary>
         ///     <para>
         ///     Compare equality to another AmountOfSubstance within the given absolute or relative tolerance.
@@ -549,20 +502,6 @@ public bool Equals(AmountOfSubstance other, double tolerance, ComparisonType com
             return UnitsNet.Comparison.Equals(thisValue, otherValueInThisUnits, tolerance, comparisonType);
         }
 
-        /// <summary>
-        ///     Compare equality to another AmountOfSubstance by specifying a max allowed difference.
-        ///     Note that it is advised against specifying zero difference, due to the nature
-        ///     of floating point operations and using System.Double internally.
-        /// </summary>
-        /// <param name="other">Other quantity to compare to.</param>
-        /// <param name="maxError">Max error allowed.</param>
-        /// <returns>True if the difference between the two values is not greater than the specified max.</returns>
-        [Obsolete("Please use the Equals(AmountOfSubstance, double, ComparisonType) overload. This method will be removed in a future version.")]
-        public bool Equals(AmountOfSubstance other, AmountOfSubstance maxError)
-        {
-            return Math.Abs(_value - other.AsBaseNumericType(this.Unit)) <= maxError.AsBaseNumericType(this.Unit);
-        }
-
         /// <summary>
         ///     Returns the hash code for this instance.
         /// </summary>
@@ -715,12 +654,6 @@ public static AmountOfSubstanceUnit ParseUnit(string str)
 
         #endregion
 
-        /// <summary>
-        ///     Set the default unit used by ToString(). Default is Mole
-        /// </summary>
-        [Obsolete("This is no longer used since we will instead use the quantity's Unit value as default.")]
-        public static AmountOfSubstanceUnit ToStringDefaultUnit { get; set; } = AmountOfSubstanceUnit.Mole;
-
         /// <summary>
         ///     Get default string representation of value and unit.
         /// </summary>

Common/GeneratedCode/Quantities/AmplitudeRatio.Common.g.cs

@@ -81,21 +81,11 @@ static AmplitudeRatio()
         {
         }
 
-        /// <summary>
-        ///     Creates the quantity with the given value in the base unit DecibelVolt.
-        /// </summary>
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public AmplitudeRatio(double decibelvolts)
-        {
-            _value = Convert.ToDouble(decibelvolts);
-            _unit = BaseUnit;
-        }
-
         /// <summary>
         ///     Creates the quantity with the given numeric value and unit.
         /// </summary>
         /// <param name="numericValue">Numeric value.</param>
-        /// <param name="unit">Unit representation.</param>
+        /// <param name="unit">The unit representation to contruct this quantity with.</param>
         /// <remarks>Value parameter cannot be named 'value' due to constraint when targeting Windows Runtime Component.</remarks>
 #if WINDOWS_UWP
         private
@@ -108,33 +98,6 @@ public AmplitudeRatio(double decibelvolts)
             _unit = unit;
         }
 
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit DecibelVolt.
-        /// </summary>
-        /// <param name="decibelvolts">Value assuming base unit DecibelVolt.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        AmplitudeRatio(long decibelvolts) : this(Convert.ToDouble(decibelvolts), BaseUnit) { }
-
-        // Windows Runtime Component does not allow public methods/ctors with same number of parameters: https://msdn.microsoft.com/en-us/library/br230301.aspx#Overloaded methods
-        // Windows Runtime Component does not support decimal type
-        /// <summary>
-        ///     Creates the quantity with the given value assuming the base unit DecibelVolt.
-        /// </summary>
-        /// <param name="decibelvolts">Value assuming base unit DecibelVolt.</param>
-#if WINDOWS_UWP
-        private
-#else
-        [Obsolete("Use the constructor that takes a unit parameter. This constructor will be removed in a future version.")]
-        public
-#endif
-        AmplitudeRatio(decimal decibelvolts) : this(Convert.ToDouble(decibelvolts), BaseUnit) { }
-
         #region Properties
 
         /// <summary>
@@ -143,7 +106,7 @@ public AmplitudeRatio(double decibelvolts)
         public static QuantityType QuantityType => QuantityType.AmplitudeRatio;
 
         /// <summary>
-        ///     The base unit representation of this quantity for the numeric value stored internally. All conversions go via this value.
+        ///     The base unit of AmplitudeRatio, which is DecibelVolt. All conversions go via this value.
         /// </summary>
         public static AmplitudeRatioUnit BaseUnit => AmplitudeRatioUnit.DecibelVolt;
 
@@ -297,16 +260,6 @@ int CompareTo(AmplitudeRatio other)
             return _value.CompareTo(other.AsBaseNumericType(this.Unit));
         }
 
-        [Obsolete("It is not safe to compare equality due to using System.Double as the internal representation. It is very easy to get slightly different values due to floating point operations. Instead use Equals($quantityName, double, ComparisonType) to provide the max allowed absolute or relative error.")]
-        public override bool Equals(object obj)
-        {
-            if(obj is null || !(obj is AmplitudeRatio))
-                return false;
-
-            var objQuantity = (AmplitudeRatio)obj;
-            return _value.Equals(objQuantity.AsBaseNumericType(this.Unit));
-        }
-
         /// <summary>
         ///     <para>
         ///     Compare equality to another AmplitudeRatio within the given absolute or relative tolerance.
@@ -358,20 +311,6 @@ public bool Equals(AmplitudeRatio other, double tolerance, ComparisonType compar
             return UnitsNet.Comparison.Equals(thisValue, otherValueInThisUnits, tolerance, comparisonType);
         }
 
-        /// <summary>
-        ///     Compare equality to another AmplitudeRatio by specifying a max allowed difference.
-        ///     Note that it is advised against specifying zero difference, due to the nature
-        ///     of floating point operations and using System.Double internally.
-        /// </summary>
-        /// <param name="other">Other quantity to compare to.</param>
-        /// <param name="maxError">Max error allowed.</param>
-        /// <returns>True if the difference between the two values is not greater than the specified max.</returns>
-        [Obsolete("Please use the Equals(AmplitudeRatio, double, ComparisonType) overload. This method will be removed in a future version.")]
-        public bool Equals(AmplitudeRatio other, AmplitudeRatio maxError)
-        {
-            return Math.Abs(_value - other.AsBaseNumericType(this.Unit)) <= maxError.AsBaseNumericType(this.Unit);
-        }
-
         /// <summary>
         ///     Returns the hash code for this instance.
         /// </summary>
@@ -504,12 +443,6 @@ public static AmplitudeRatioUnit ParseUnit(string str)
 
         #endregion
 
-        /// <summary>
-        ///     Set the default unit used by ToString(). Default is DecibelVolt
-        /// </summary>
-        [Obsolete("This is no longer used since we will instead use the quantity's Unit value as default.")]
-        public static AmplitudeRatioUnit ToStringDefaultUnit { get; set; } = AmplitudeRatioUnit.DecibelVolt;
-
         /// <summary>
         ///     Get default string representation of value and unit.
         /// </summary>