Skip to content

Commit 6319b5f

Browse files
committed
💥🐛Change DataMember ordering to 1-indexed
Fixes #1356 Apparently, protobuf-net does not support 0-indexed order values. Some investigation indicates that the actual order value is not important, only the relative ordering. #1356 (comment)
1 parent 2424307 commit 6319b5f

File tree

124 files changed

+258
-258
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+258
-258
lines changed

CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ namespace UnitsNet
9999
Writer.WL(@$"
100100
#endif");
101101
}
102-
102+
103103
if (_quantity.ValueType == "decimal") Writer.WL(@$"
104104
IDecimalQuantity,");
105105

@@ -115,13 +115,13 @@ namespace UnitsNet
115115
/// <summary>
116116
/// The numeric value this quantity was constructed with.
117117
/// </summary>
118-
[DataMember(Name = ""Value"", Order = 0)]
118+
[DataMember(Name = ""Value"", Order = 1)]
119119
private readonly {_quantity.ValueType} _value;
120120
121121
/// <summary>
122122
/// The unit this quantity was constructed with.
123123
/// </summary>
124-
[DataMember(Name = ""Unit"", Order = 1)]
124+
[DataMember(Name = ""Unit"", Order = 2)]
125125
private readonly {_unitEnumName}? _unit;
126126
");
127127
GenerateStaticConstructor();
@@ -759,41 +759,41 @@ private void GenerateRelationalOperators()
759759
{
760760
leftConversionProperty = "Total" + leftConversionProperty;
761761
}
762-
762+
763763
if (relation.RightQuantity.Name is nameof(TimeSpan))
764764
{
765765
rightConversionProperty = "Total" + rightConversionProperty;
766766
}
767-
767+
768768
if (leftParameter == rightParameter)
769769
{
770770
leftParameter = "left";
771771
rightParameter = "right";
772772
}
773-
773+
774774
var leftPart = $"{leftParameter}.{leftConversionProperty}";
775775
var rightPart = $"{rightParameter}.{rightConversionProperty}";
776-
776+
777777
if (leftParameter is "double")
778778
{
779779
leftParameter = leftPart = "value";
780-
}
781-
780+
}
781+
782782
if (rightParameter is "double")
783783
{
784784
rightParameter = rightPart = "value";
785785
}
786-
786+
787787
var leftCast = relation.LeftQuantity.ValueType is "decimal" ? "(double)" : string.Empty;
788788
var rightCast = relation.RightQuantity.ValueType is "decimal" ? "(double)" : string.Empty;
789-
789+
790790
var expression = $"{leftCast}{leftPart} {relation.Operator} {rightCast}{rightPart}";
791791

792792
if (relation.ResultQuantity.Name is not ("double" or "decimal"))
793793
{
794794
expression = $"{relation.ResultQuantity.Name}.From{relation.ResultUnit.PluralName}({expression})";
795795
}
796-
796+
797797
Writer.WL($@"
798798
/// <summary>Get <see cref=""{relation.ResultQuantity.Name}""/> from <see cref=""{relation.LeftQuantity.Name}""/> {relation.Operator} <see cref=""{relation.RightQuantity.Name}""/>.</summary>
799799
public static {relation.ResultQuantity.Name} operator {relation.Operator}({relation.LeftQuantity.Name} {leftParameter}, {relation.RightQuantity.Name} {rightParameter})

UnitsNet/GeneratedCode/Quantities/AbsorbedDoseOfIonizingRadiation.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Acceleration.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/AmountOfSubstance.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/AmplitudeRatio.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Angle.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/ApparentEnergy.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/ApparentPower.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Area.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/AreaDensity.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/AreaMomentOfInertia.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/BitRate.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/BrakeSpecificFuelConsumption.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Capacitance.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/CoefficientOfThermalExpansion.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Compressibility.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Density.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/Duration.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/DynamicViscosity.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/ElectricAdmittance.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

UnitsNet/GeneratedCode/Quantities/ElectricCharge.g.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)