Remove all TODOs in code

Replace with github issues and update comments
to point there.

Author: angularsen

UnitsNet.Serialization.JsonNet/UnitsNetJsonConverter.cs

@@ -130,9 +130,7 @@ private static object CreateQuantity(Type quantityType, double value, object uni
             object quantityValue = GetFromMethodValueArgument(notNullableFromMethod, value);
 
             // Ex: Mass.From(55, MassUnit.Gram)
-            // TODO: there is a possible loss of precision if base value requires higher precision than double can represent.
-            // Example: Serializing Information.FromExabytes(100) then deserializing to Information
-            // will likely return a very different result. Not sure how we can handle this?
+            // See ValueUnit about precision loss for quantities using decimal type.
             return notNullableFromMethod.Invoke(null, new[] {quantityValue, unitValue});
         }
 
@@ -207,7 +205,7 @@ public override void WriteJson(JsonWriter writer, object obj, JsonSerializer ser
 
             serializer.Serialize(writer, new ValueUnit
             {
-                // TODO Should we serialize long, decimal and long differently?
+                // See ValueUnit about precision loss for quantities using decimal type.
                 Value = Convert.ToDouble(quantityValue),
                 Unit = quantityUnitName
             });
@@ -233,9 +231,7 @@ private static object GetValueOfQuantity(object value, Type quantityType)
         {
             FieldInfo valueField = GetPrivateInstanceField(quantityType, ValueFieldName);
 
-            // Unit base type can be double, long or decimal,
-            // so make sure we serialize the real type to avoid
-            // loss of precision
+            // See ValueUnit about precision loss for quantities using decimal type.
             object quantityValue = valueField.GetValue(value);
             return quantityValue;
         }
@@ -278,10 +274,13 @@ private static FieldInfo GetPrivateInstanceField(Type quantityType, string field
         ///     A structure used to serialize/deserialize Units.NET unit instances.
         /// </summary>
         /// <remarks>
-        ///     TODO Units may use decimal, long or double as base value type and might result
+        ///     Quantities may use decimal, long or double as base value type and this might result
         ///     in a loss of precision when serializing/deserializing to decimal.
         ///     Decimal is the highest precision type available in .NET, but has a smaller
         ///     range than double.
+        ///
+        ///     Json: Support decimal precision #503
+        ///     https://github.com/angularsen/UnitsNet/issues/503
         /// </remarks>
         private class ValueUnit
         {

UnitsNet.Tests/CustomCode/EnergyTests.cs

@@ -1,16 +1,16 @@
 // Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
 // https://github.com/angularsen/UnitsNet
-// 
+//
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
 // in the Software without restriction, including without limitation the rights
 // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 // copies of the Software, and to permit persons to whom the Software is
 // furnished to do so, subject to the following conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be included in
 // all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class EnergyTests : EnergyTestsBase
     {
-        // TODO Override properties in base class here
         protected override double ThermsImperialInOneJoule => 9.478171203551087813109937767482e-9;
 
         protected override double JoulesInOneJoule => 1;

UnitsNet.Tests/CustomCode/RotationalStiffnessPerLengthTests.cs

@@ -1,9 +1,9 @@
 //------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated (once) by \generate-code.bat, but will not be
-//     regenerated when it already exists. The purpose of creating this file is to make 
+//     regenerated when it already exists. The purpose of creating this file is to make
 //     it easier to remember to implement all the unit conversion test cases.
-// 
+//
 //     Whenever a new unit is added to this quantity and \generate-code.bat is run,
 //     the base test class will get a new abstract property and cause a compile error
 //     in this derived class, reminding the developer to implement the test case
@@ -20,17 +20,17 @@
 
 // Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
 // https://github.com/angularsen/UnitsNet
-// 
+//
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
 // in the Software without restriction, including without limitation the rights
 // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 // copies of the Software, and to permit persons to whom the Software is
 // furnished to do so, subject to the following conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be included in
 // all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -46,8 +46,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class RotationalStiffnessPerLengthTests : RotationalStiffnessPerLengthTestsBase
     {
-        // TODO Override properties in base class here
-
         protected override double KilonewtonMetersPerRadianPerMeterInOneNewtonMeterPerRadianPerMeter => 1E-3;
         protected override double MeganewtonMetersPerRadianPerMeterInOneNewtonMeterPerRadianPerMeter => 1E-6;
         protected override double NewtonMetersPerRadianPerMeterInOneNewtonMeterPerRadianPerMeter => 1;

UnitsNet/Scripts/Include-GenerateUnitTestPlaceholderSourceCode.ps1

@@ -5,9 +5,9 @@ function GenerateUnitTestPlaceholderSourceCode($quantity)
 //------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated (once) by \generate-code.bat, but will not be
-//     regenerated when it already exists. The purpose of creating this file is to make 
+//     regenerated when it already exists. The purpose of creating this file is to make
 //     it easier to remember to implement all the unit conversion test cases.
-// 
+//
 //     Whenever a new unit is added to this quantity and \generate-code.bat is run,
 //     the base test class will get a new abstract property and cause a compile error
 //     in this derived class, reminding the developer to implement the test case
@@ -24,17 +24,17 @@ function GenerateUnitTestPlaceholderSourceCode($quantity)
 
 // Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
 // https://github.com/angularsen/UnitsNet
-// 
+//
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
 // in the Software without restriction, including without limitation the rights
 // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 // copies of the Software, and to permit persons to whom the Software is
 // furnished to do so, subject to the following conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be included in
 // all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -50,7 +50,7 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class $($quantityName)Tests : $($quantityName)TestsBase
     {
-        // TODO Override properties in base class here
+        // Override properties in base class here
     }
 }
 "@;

UnitsNet/UnitConverter.cs

@@ -1,16 +1,16 @@
 // Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
 // https://github.com/angularsen/UnitsNet
-// 
+//
 // Permission is hereby granted, free of charge, to any person obtaining a copy
 // of this software and associated documentation files (the "Software"), to deal
 // in the Software without restriction, including without limitation the rights
 // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 // copies of the Software, and to permit persons to whom the Software is
 // furnished to do so, subject to the following conditions:
-// 
+//
 // The above copyright notice and this permission notice shall be included in
 // all copies or substantial portions of the Software.
-// 
+//
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -119,8 +119,11 @@ public static bool TryConvertByName(FromValue inputValue, string quantityName, s
         {
             try
             {
-                // TODO Reimplement to avoid exceptions where possible, as Try methods are generally recommended for performance and this is cheating
+                // Re-implement this to avoid exceptions where possible, as Try methods are generally recommended for performance and this is cheating.
                 // https://msdn.microsoft.com/en-us/library/ms229009(v=vs.100).aspx
+                //
+                // Implement Try-methods without try-catch #504
+                // https://github.com/angularsen/UnitsNet/issues/504
                 result = ConvertByName(inputValue, quantityName, fromUnit, toUnit);
                 return true;
             }
@@ -201,7 +204,7 @@ public static double ConvertByAbbreviation(FromValue fromValue, string quantityN
 
             UnitSystem unitSystem = UnitSystem.GetCached(culture);
             object fromUnitValue = unitSystem.Parse(fromUnitAbbrev, unitType); // ex: ("m", LengthUnit) => LengthUnit.Meter
-            object toUnitValue = unitSystem.Parse(toUnitAbbrev, unitType); // ex:("cm", LengthUnit) => LengthUnit.Centimeter 
+            object toUnitValue = unitSystem.Parse(toUnitAbbrev, unitType); // ex:("cm", LengthUnit) => LengthUnit.Centimeter
 
             MethodInfo fromMethod = GetStaticFromMethod(quantityType, unitType); // ex: UnitsNet.Length.From(double inputValue, LengthUnit inputUnit)
             object fromResult = fromMethod.Invoke(null, new[] {fromValue, fromUnitValue}); // ex: Length quantity = UnitsNet.Length.From(5, LengthUnit.Meter)
@@ -277,8 +280,11 @@ public static bool TryConvertByAbbreviation(FromValue fromValue, string quantity
         {
             try
             {
-                // TODO Reimplement to avoid exceptions where possible, as Try methods are generally recommended for performance and this is cheating
+                // Re-implement this to avoid exceptions where possible, as Try methods are generally recommended for performance and this is cheating.
                 // https://msdn.microsoft.com/en-us/library/ms229009(v=vs.100).aspx
+                //
+                // Implement Try-methods without try-catch #504
+                // https://github.com/angularsen/UnitsNet/issues/504
                 result = ConvertByAbbreviation(fromValue, quantityName, fromUnitAbbrev, toUnitAbbrev, culture);
                 return true;
             }
@@ -373,4 +379,4 @@ private static Type GetQuantityType(string quantityName)
             return quantityType;
         }
     }
-}
+}