From 88879ec18be2c30a4f639bb43bca16740357e189 Mon Sep 17 00:00:00 2001 From: tirana Date: Thu, 7 Apr 2016 15:49:08 -0700 Subject: [PATCH] [accessibility] Autocomplete should use role=combobox Typically editable combo boxes are used for autocomplete behavior, and authors SHOULD set aria-autocomplete attribute on the textfield. https://www.w3.org/TR/wai-aria/roles#combobox --- src/components/autocomplete/js/autocompleteDirective.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/autocomplete/js/autocompleteDirective.js b/src/components/autocomplete/js/autocompleteDirective.js index ac0f5e3486b..43c4312fc01 100644 --- a/src/components/autocomplete/js/autocompleteDirective.js +++ b/src/components/autocomplete/js/autocompleteDirective.js @@ -174,8 +174,7 @@ function MdAutocomplete () { return '\ \ + ng-class="{ \'md-whiteframe-z1\': !floatingLabel, \'md-menu-showing\': !$mdAutocompleteCtrl.hidden }">\ ' + getInputElement() + '\ \ @@ -276,6 +276,7 @@ function MdAutocomplete () { ' + (attr.mdSelectOnFocus != null ? 'md-select-on-focus=""' : '') + '\ aria-label="{{placeholder}}"\ aria-autocomplete="list"\ + role="combobox"\ aria-haspopup="true"\ aria-activedescendant=""\ aria-expanded="{{!$mdAutocompleteCtrl.hidden}}"/>\