Fix jshint warnings (#11109)

add sub:true and multistr=true to .jshintrc

revert and remove confusing use of ! warning

update fix

fix space

exclude warnings

Author: 5earle

.jshintrc

@@ -1,4 +1,7 @@
 {
+  "sub": true,
+  "multistr": true,
+  "-W018": true,
   "expr": true,
   "boss": true,
   "laxbreak": true,

src/components/autocomplete/demoInsideDialog/script.js

@@ -15,8 +15,8 @@
         parent: angular.element(document.body),
         targetEvent: $event,
         clickOutsideToClose:true
-      })
-    }
+      });
+    };
   }
 
   function DialogCtrl ($timeout, $q, $scope, $mdDialog) {

src/components/autocomplete/js/autocompleteDirective.js

@@ -277,7 +277,7 @@ function MdAutocomplete ($$mdSvgRegistry) {
         if (!angular.isDefined(attrs.mdClearButton) && !scope.floatingLabel) {
           scope.clearButton = true;
         }
-      }
+      };
     },
     template:     function (element, attr) {
       var noItemsTemplate = getNoItemsTemplate(),

src/components/chips/demoContactChips/script.js

@@ -49,7 +49,7 @@
             resolve( self.querySearch(criteria) );
 
             refreshDebounce();
-          }, Math.random() * 500, true)
+          }, Math.random() * 500, true);
         });
       }
 

src/components/chips/demoCustomInputs/script.js

@@ -29,7 +29,7 @@
       }
 
       // Otherwise, create a new one
-      return { name: chip, type: 'new' }
+      return { name: chip, type: 'new' };
     }
 
     /**

src/components/chips/js/chipDirective.js

@@ -21,6 +21,7 @@ angular
 
 // This hint text is hidden within a chip but used by screen readers to
 // inform the user how they can interact with a chip.
+
 var DELETE_HINT_TEMPLATE = '\
     <span ng-if="!$mdChipsCtrl.readonly" class="md-visually-hidden">\
       {{$mdChipsCtrl.deleteHint}}\

src/components/chips/js/chipsDirective.js

@@ -9,7 +9,7 @@
    *
    * @description
    * `<md-chips>` is an input component for building lists of strings or objects. The list items are
-   * displayed as 'chips'. This component can make use of an `<input>` element or an 
+   * displayed as 'chips'. This component can make use of an `<input>` element or an
    * `<md-autocomplete>` element.
    *
    * ### Custom templates
@@ -106,7 +106,7 @@
    *    the input and delete buttons. If no `ng-model` is provided, the chips will automatically be
    *    marked as readonly.<br/><br/>
    *    When `md-removable` is not defined, the `md-remove` behavior will be overwritten and disabled.
-   * @param {string=} md-enable-chip-edit Set this to "true" to enable editing of chip contents. The user can 
+   * @param {string=} md-enable-chip-edit Set this to "true" to enable editing of chip contents. The user can
    *    go into edit mode with pressing "space", "enter", or double clicking on the chip. Chip edit is only
    *    supported for chips with basic template.
    * @param {boolean=} ng-required Whether ng-model is allowed to be empty or not.

src/components/colors/demoBasicUsage/script.js

@@ -14,7 +14,7 @@ angular.module('colorsDemo', ['ngMaterial'])
       scope: {
         name: '@',
       }
-    }
+    };
   })
   .directive('userCard', function () {
     return {
@@ -27,5 +27,5 @@ angular.module('colorsDemo', ['ngMaterial'])
       controller: function ($scope) {
         $scope.theme = $scope.theme || 'default';
       }
-    }
+    };
   });

src/components/colors/demoThemePicker/script.js

@@ -1,7 +1,7 @@
 angular
   .module('colorsThemePickerDemo', ['ngMaterial'])
   .controller('ThemeDemoCtrl', function ($scope, $mdColorPalette) {
-    $scope.colors = Object.keys($mdColorPalette); 
+    $scope.colors = Object.keys($mdColorPalette);
 
     $scope.mdURL = 'https://material.google.com/style/color.html#color-color-palette';
     $scope.primary = 'purple';
@@ -32,10 +32,10 @@ angular
       },
       controller: function ($scope, $mdColors, $mdColorUtil) {
         $scope.getColor = function (color) {
-          return $mdColorUtil.rgbaToHex($mdColors.getThemeColor(color))
+          return $mdColorUtil.rgbaToHex($mdColors.getThemeColor(color));
         };
       }
-    }
+    };
   })
   .directive('mdJustified', function() {
     return {

src/components/gridList/grid-list.js

@@ -105,7 +105,7 @@ function GridListDirective($interpolate, $mdConstant, $mdGridLayout, $mdMedia) {
 
   function postLink(scope, element, attrs, ctrl) {
     element.addClass('_md');     // private md component indicator for styling
-    
+
     // Apply semantics
     element.attr('role', 'list');
 
@@ -193,9 +193,9 @@ function GridListDirective($interpolate, $mdConstant, $mdGridLayout, $mdMedia) {
                   style: getTileStyle(ps.position, ps.spans,
                       props.colCount, rowCount,
                       props.gutter, props.rowMode, props.rowHeight)
-                }
+                };
               })
-            }
+            };
           })
           .reflow()
           .performance();
@@ -550,7 +550,7 @@ function GridLayoutFactory($mdUtil) {
     grid.element.css(grid.style);
     tiles.forEach(function(t) {
       t.element.css(t.style);
-    })
+    });
   }
 
   /**

src/components/icon/demoLoadSvgIconsFromUrl/script.js

@@ -15,5 +15,5 @@ angular.module('appDemoSvgIcons', ['ngMaterial'])
     /* Returns decoded SVG */
     $scope.getCartDecoded = function() {
       return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><g id="add-shopping-cart"><path d="M11 9h2V6h3V4h-3V1h-2v3H8v2h3v3zm-4 9c-1.1 0-1.99.9-1.99 2S5.9 22 7 22s2-.9 2-2-.9-2-2-2zm10 0c-1.1 0-1.99.9-1.99 2s.89 2 1.99 2 2-.9 2-2-.9-2-2-2zm-9.83-3.25l.03-.12.9-1.63h7.45c.75 0 1.41-.41 1.75-1.03l3.86-7.01L19.42 4h-.01l-1.1 2-2.76 5H8.53l-.13-.27L6.16 6l-.95-2-.94-2H1v2h2l3.6 7.59-1.35 2.45c-.16.28-.25.61-.25.96 0 1.1.9 2 2 2h12v-2H7.42c-.13 0-.25-.11-.25-.25z"/></g></svg>';
-    }
+    };
 });

src/components/input/input.js

@@ -30,7 +30,7 @@ if (window._mdMocksIncluded) {
         hide        : hideInputMessages,
         getElement  : getMessagesElement
       }
-    }
+    };
   })
 
   // Register a service for each animation so that we can easily inject them into unit tests

src/components/menu/js/menuServiceProvider.js

@@ -125,7 +125,7 @@ function MenuProvider($$interimElementProvider) {
           element
         );
       }
-      
+
       // Register various listeners to move menu on resize/orientation change
       opts.cleanupResizing = startRepositioningOnResize();
       opts.hideBackdrop = showBackdrop(scope, element, opts);
@@ -224,7 +224,7 @@ function MenuProvider($$interimElementProvider) {
 
         return function() {
           opts.backdrop.off('click', onBackdropClick);
-        }
+        };
       }
 
       /**

src/components/navBar/navBar.js

@@ -275,7 +275,7 @@ MdNavBarController.prototype._getTabs = function() {
   var controllers = Array.prototype.slice.call(
     this._navBarEl.querySelectorAll('.md-nav-item'))
     .map(function(el) {
-      return angular.element(el).controller('mdNavItem')
+      return angular.element(el).controller('mdNavItem');
     });
   return controllers.indexOf(undefined) ? controllers : null;
 };

src/components/panel/demoGroups/script.js

@@ -134,6 +134,6 @@
   function PanelMenuCtrl(mdPanelRef) {
     this.closeMenu = function() {
       mdPanelRef && mdPanelRef.close();
-    }
+    };
   }
 })();

src/components/panel/panel.js

@@ -245,7 +245,7 @@ angular
  *   - `locals` - `{Object=}`: An object containing key/value pairs. The keys
  *     will be used as names of values to inject into the controller. For
  *     example, `locals: {three: 3}` would inject `three` into the controller,
- *     with the value 3. 'mdPanelRef' is a reserved key, and will always 
+ *     with the value 3. 'mdPanelRef' is a reserved key, and will always
  *     be set to the created MdPanelRef instance.
  *   - `resolve` - `{Object=}`: Similar to locals, except it takes promises as
  *     values. The panel will not open until all of the promises resolve.

src/components/tabs/js/tabsController.js

@@ -358,7 +358,7 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp
    * Slides the tabs over approximately one page forward.
    */
   function nextPage () {
-    if (!ctrl.canPageForward()) { return }
+    if (!ctrl.canPageForward()) { return; }
 
     var newOffset = MdTabsPaginationService.increasePageOffset(getElements(), ctrl.offsetLeft);
 
@@ -369,7 +369,7 @@ function MdTabsController ($scope, $element, $window, $mdConstant, $mdTabInkRipp
    * Slides the tabs over approximately one page backward.
    */
   function previousPage () {
-    if (!ctrl.canPageBack()) { return }
+    if (!ctrl.canPageBack()) { return; }
 
     var newOffset = MdTabsPaginationService.decreasePageOffset(getElements(), ctrl.offsetLeft);
 

src/components/toast/toast.js

@@ -17,7 +17,7 @@ function MdToastDirective($mdToast) {
     restrict: 'E',
     link: function postLink(scope, element) {
       element.addClass('_md');     // private md component indicator for styling
-      
+
       // When navigation force destroys an interimElement, then
       // listen and $destroy() that interim instance...
       scope.$on('$destroy', function() {
@@ -118,7 +118,7 @@ function MdToastDirective($mdToast) {
 /**
  * @ngdoc method
  * @name $mdToast#showSimple
- * 
+ *
  * @param {string} message The message to display inside the toast
  * @description
  * Convenience method which builds and shows a simple toast.
@@ -351,7 +351,7 @@ function MdToastProvider($$interimElementProvider) {
         $scope.highlightClasses = [
           'md-highlight',
           self.highlightClass
-        ]
+        ];
       }
 
       $scope.$watch(function() { return activeToastContent; }, function() {
@@ -361,7 +361,7 @@ function MdToastProvider($$interimElementProvider) {
       this.resolve = function() {
         $mdToast.hide( ACTION_RESOLVE );
       };
-    }
+    };
   }
 
   /* @ngInject */

src/components/truncate/truncate.js

@@ -68,7 +68,7 @@ function MdTruncateDirective() {
     restrict: 'AE',
 
     controller: MdTruncateController
-  }
+  };
 }
 
 /**

src/components/virtualRepeat/virtual-repeater.js

@@ -1015,6 +1015,6 @@ function ForceHeightDirective($mdUtil) {
         element[0].style.height = height;
       }
     }
-  }
+  };
 }
 ForceHeightDirective.$inject = ['$mdUtil'];

src/core/services/compiler/compiler.js

@@ -415,7 +415,7 @@ function MdCompilerProvider($compileProvider) {
           if (contentEl.parentNode) {
             contentEl.parentNode.removeChild(contentEl);
           }
-        }
+        };
       }
     }
 
@@ -439,7 +439,7 @@ function MdCompilerProvider($compileProvider) {
           // before.
           parent.insertBefore(element, nextSibling);
         }
-      }
+      };
     }
   };
 }

src/core/util/util.js

@@ -80,7 +80,7 @@ function UtilFactory($document, $timeout, $compile, $rootScope, $$mdAnimate, $in
 
       // The newer versions of AngularJS introduced a `getOption function and made the option values no longer
       // visible on the $options object.
-      return $options.getOption ? $options.getOption(optionName) : $options[optionName]
+      return $options.getOption ? $options.getOption(optionName) : $options[optionName];
     },
 
     /**
@@ -573,7 +573,7 @@ function UtilFactory($document, $timeout, $compile, $rootScope, $$mdAnimate, $in
       var hasContains = (window.Node && window.Node.prototype && Node.prototype.contains);
       var findFn = hasContains ? angular.bind(node, node.contains) : angular.bind(node, function(arg) {
         // compares the positions of two nodes and returns a bitmask
-        return (node === child) || !!(this.compareDocumentPosition(arg) & 16)
+        return (node === child) || !!(this.compareDocumentPosition(arg) & 16);
       });
 
       return findFn(child);