From 5a7b096aab05bb30c9e6179f792decb41c395d49 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 15 Mar 2017 22:29:02 +0100 Subject: [PATCH] build(tslint): disallow var keyword * Disallows the var-keyboard in the source files. `var` mostly causes issues with variables, and can be safely replaced with `let`. --- src/examples/example-data.ts | 4 +--- src/lib/button-toggle/button-toggle.ts | 2 +- src/lib/checkbox/checkbox.ts | 2 +- src/lib/radio/radio.ts | 2 +- tslint.json | 1 + 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/examples/example-data.ts b/src/examples/example-data.ts index a1fc1c8838a6..3dd2b5a3ef4e 100644 --- a/src/examples/example-data.ts +++ b/src/examples/example-data.ts @@ -28,9 +28,7 @@ export class ExampleData { } this.selectorName = this.indexFilename = `${example}-example`; - var exampleName = example.replace(/(?:^\w|\b\w)/g, function(letter) { - return letter.toUpperCase(); - }); + let exampleName = example.replace(/(?:^\w|\b\w)/g, letter => letter.toUpperCase()); if (EXAMPLE_COMPONENTS[example].title) { this.description = EXAMPLE_COMPONENTS[example].title; diff --git a/src/lib/button-toggle/button-toggle.ts b/src/lib/button-toggle/button-toggle.ts index 22b0184d4ee0..d0d82bfb6593 100644 --- a/src/lib/button-toggle/button-toggle.ts +++ b/src/lib/button-toggle/button-toggle.ts @@ -36,7 +36,7 @@ export const MD_BUTTON_TOGGLE_GROUP_VALUE_ACCESSOR: any = { multi: true }; -var _uniqueIdCounter = 0; +let _uniqueIdCounter = 0; /** Change event object emitted by MdButtonToggle. */ export class MdButtonToggleChange { diff --git a/src/lib/checkbox/checkbox.ts b/src/lib/checkbox/checkbox.ts index eac2c0131768..8ff44319a258 100644 --- a/src/lib/checkbox/checkbox.ts +++ b/src/lib/checkbox/checkbox.ts @@ -402,7 +402,7 @@ export class MdCheckbox implements ControlValueAccessor, AfterViewInit, OnDestro private _getAnimationClassForCheckStateTransition( oldState: TransitionCheckState, newState: TransitionCheckState): string { - var animSuffix: string; + let animSuffix: string; switch (oldState) { case TransitionCheckState.Init: diff --git a/src/lib/radio/radio.ts b/src/lib/radio/radio.ts index d40c896a3477..ddad9a8ed8c1 100644 --- a/src/lib/radio/radio.ts +++ b/src/lib/radio/radio.ts @@ -39,7 +39,7 @@ export const MD_RADIO_GROUP_CONTROL_VALUE_ACCESSOR: any = { multi: true }; -var _uniqueIdCounter = 0; +let _uniqueIdCounter = 0; /** Change event object emitted by MdRadio and MdRadioGroup. */ export class MdRadioChange { diff --git a/tslint.json b/tslint.json index 476332448cce..cf9ba7cf9a57 100644 --- a/tslint.json +++ b/tslint.json @@ -25,6 +25,7 @@ "no-shadowed-variable": true, "no-unused-expression": true, "no-unused-var": [true, {"ignore-pattern": "^(_.*)$"}], + "no-var-keyword": true, "no-debugger": true, "one-line": [ true,