From df6d2897b237a84b02442d7272d09810205340b9 Mon Sep 17 00:00:00 2001 From: Miles Malerba Date: Wed, 15 Dec 2021 22:36:16 +0000 Subject: [PATCH] fix(material-experimental/mdc-slide-toggle): remove aria-required rather than setting to false Both are equally valid to mark the control as not required, but setting it to false generates a bunch of false-positive lint errors in google3 --- src/material-experimental/mdc-slide-toggle/slide-toggle.html | 2 +- src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/material-experimental/mdc-slide-toggle/slide-toggle.html b/src/material-experimental/mdc-slide-toggle/slide-toggle.html index 15c4c2a9dfd9..3d3f69102758 100644 --- a/src/material-experimental/mdc-slide-toggle/slide-toggle.html +++ b/src/material-experimental/mdc-slide-toggle/slide-toggle.html @@ -13,7 +13,7 @@ [attr.aria-label]="ariaLabel" [attr.aria-labelledby]="_getAriaLabelledBy()" [attr.aria-describedby]="ariaDescribedby" - [attr.aria-required]="required" + [attr.aria-required]="required || null" (click)="_handleClick($event)" #switch>
diff --git a/src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts b/src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts index 5b55cd224e9e..3000d9473687 100644 --- a/src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts +++ b/src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts @@ -274,7 +274,7 @@ describe('MDC-based MatSlideToggle without forms', () => { testComponent.isRequired = false; fixture.detectChanges(); - expect(buttonElement.getAttribute('aria-required')).toBe('false'); + expect(buttonElement.getAttribute('aria-required')).toBe(null); }); it('should focus on underlying element when focus() is called', fakeAsync(() => {