prototype(button): create prototype button based on MDC Web #15887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 24, 2019
andrewseguin
force-pushed
the
mdc-button
branch
from
21f0055 to
39de594
Compare
andrewseguin
force-pushed
the
mdc-button
branch
from
a96acb1 to
c24e7d3
Compare
mmalerba
approved these changes
Apr 26, 2019
Contributor
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
LGTM aside for the CI issues
mmalerba
added
pr: lgtm
target: major
mmalerba
added
action: merge
Contributor
|
related to #16196 |
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…15887) * prototype(button): create prototype button based on MDC Web * fix BUILD * add focus method to button base * build: rename lib to material * add comments to ripple styles; remove position relative; merge mixins * put button HTML into file * fix lint * move sass rules out of theme; cleanup typography styles * build fix * build fix
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype of using MDC Web for the base of our button component. Remaining issues and todo tasks are left in the README