Skip to content

[autocomplete] panelClosingActions does not include escape key #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willshowell opened this issue Aug 1, 2017 · 1 comment · Fixed by #6250
Closed

[autocomplete] panelClosingActions does not include escape key #6209

willshowell opened this issue Aug 1, 2017 · 1 comment · Fixed by #6250
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

Current

panelClosingActions doesn't emit an event for when the autocomplete is closed due to the escape key

Expected

if (event.keyCode === ESCAPE && this.panelOpen) {
  this._escapeKeyStream.next();
}

// ...

get panelClosingActions(): Observable<MdOptionSelectionChange> {
  return merge(
    this.optionSelections,
    this.autocomplete._keyManager.tabOut,
    this._outsideClickStream,
    this._escapeKeyStream
  );
}

What are the steps to reproduce?

https://plnkr.co/edit/R0CPBfwzKS54o5Fd7fsx?p=preview

What is the use-case or motivation for changing an existing behavior?

#3334 (comment)

@mmalerba mmalerba added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Aug 9, 2017
@kara kara closed this as completed in #6250 Oct 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants