Skip to content

refactor: find a way to share common code between checkable components #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertmesserle opened this issue Jun 1, 2016 · 4 comments
Labels
refactoring This issue is related to a refactoring

Comments

@robertmesserle
Copy link
Contributor

As is, there is a lot of copy/pasted code shared between radio buttons, checkboxes, and toggle buttons. We need to look into a way to rely on shared code rather than duplicate code.

@devversion
Copy link
Member

I think that relates to #598 as well.

@shlomiassaf
Copy link
Contributor

If done, also consider #347 in the process.

@jelbourn jelbourn added the refactoring This issue is related to a refactoring label Oct 20, 2016
@devversion devversion changed the title refactor(radio, checkbox, toggle-button): find a way to share common code between components refactor: find a way to share common code between checkable components Dec 12, 2016
@devversion devversion self-assigned this Dec 12, 2016
@devversion devversion removed their assignment Feb 3, 2017
@jelbourn
Copy link
Member

jelbourn commented Apr 9, 2017

Exploring new mixins in TypeScript 2.2.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactoring This issue is related to a refactoring
Projects
None yet
Development

No branches or pull requests

4 participants