Skip to content

Commit 9323228

Browse files
committed
Fix cannot find name promise
1 parent fdf5b04 commit 9323228

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

tools/gulp/gulpfile.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ import './tasks/docs';
77
import './tasks/e2e';
88
import './tasks/lint';
99
import './tasks/release';
10+
import './tasks/screenshots';
1011
import './tasks/serve';
1112
import './tasks/unit-test';
1213
import './tasks/docs';
1314
import './tasks/aot';
1415
import './tasks/payload';
15-
import './tasks/screenshots';

tools/gulp/tasks/screenshots.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function updateTravis(database: admin.database.Database,
4747
}
4848

4949
/** Get a list of filenames from firebase database. */
50-
function getScreenshotFiles(database: admin.database.Database): Promise<any[]> {
50+
function getScreenshotFiles(database: admin.database.Database) {
5151
let bucket = openScreenshotsBucket();
5252
return bucket.getFiles({ prefix: 'golds/' }).then(function(data: any) {
5353
return data[0].filter((file:any) => file.name.endsWith('.screenshot.png'));
@@ -76,7 +76,7 @@ function getLocalScreenshotFiles(dir: string): string[] {
7676
function uploadScreenshots(prNumber?: string, mode?: 'test' | 'diff') {
7777
let bucket = openScreenshotsBucket();
7878

79-
let promises: admin.Promise<void>[] = [];
79+
let promises: any[] = [];
8080
let localDir = mode == 'diff' ? path.join(SCREENSHOT_DIR, 'diff') : SCREENSHOT_DIR;
8181
getLocalScreenshotFiles(localDir).forEach((file: string) => {
8282
let fileName = path.join(localDir, file);
@@ -95,13 +95,13 @@ function downloadAllGoldsAndCompare(
9595
mkdirp(path.join(SCREENSHOT_DIR, `golds`));
9696
mkdirp(path.join(SCREENSHOT_DIR, `diff`));
9797

98-
return admin.Promise.all(files.map((file: any) => {
98+
return Promise.all(files.map((file: any) => {
9999
return downloadGold(file).then(() => diffScreenshot(file.name, database, prNumber));
100100
})).then((results: boolean[]) => results.every((value: boolean) => value == true));
101101
}
102102

103103
/** Download one gold screenshot */
104-
function downloadGold(file: any): Promise<void> {
104+
function downloadGold(file: any) {
105105
return file.download({
106106
destination: path.join(SCREENSHOT_DIR, file.name)
107107
});

0 commit comments

Comments
 (0)