build: enable more strictness flags in non-library code (#23077)

Updates the compiler options for the schematics and other Node-based code, and resolves any compilation errors that showed up as a result. Also fixes a bunch of references to non-existent types from `parse5`.

Author: crisbeto

src/cdk/schematics/BUILD.bazel

@@ -37,6 +37,7 @@ ts_library(
         # TODO(devversion): Only include jasmine for test sources (See: tsconfig types).
         "@npm//@types/jasmine",
         "@npm//@types/glob",
+        "@npm//@types/parse5",
         "@npm//@types/node",
         "@npm//glob",
         "@npm//parse5",

src/cdk/schematics/ng-add/package-config.ts

@@ -16,8 +16,11 @@ interface PackageJson {
  * Sorts the keys of the given object.
  * @returns A new object instance with sorted keys
  */
-function sortObjectByKeys(obj: object) {
-  return Object.keys(obj).sort().reduce((result, key) => (result[key] = obj[key]) && result, {});
+ function sortObjectByKeys(obj: Record<string, string>) {
+  return Object.keys(obj).sort().reduce((result, key) => {
+    result[key] = obj[key];
+    return result;
+  }, {} as Record<string, string>);
 }
 
 /** Adds a package to the package.json in the given host tree. */

src/cdk/schematics/ng-update/find-stylesheets.ts

@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {join} from '@angular-devkit/core';
+import {join, Path} from '@angular-devkit/core';
 import {Tree} from '@angular-devkit/schematics';
 
 /** Regular expression that matches stylesheet paths */
@@ -21,7 +21,7 @@ const STYLESHEET_REGEX = /.*\.(css|scss)/;
  */
 export function findStylesheetFiles(tree: Tree, startDirectory: string = '/'): string[] {
   const result: string[] = [];
-  const visitDir = dirPath => {
+  const visitDir = (dirPath: Path) => {
     const {subfiles, subdirs} = tree.getDir(dirPath);
 
     subfiles.forEach(fileName => {
@@ -38,6 +38,6 @@ export function findStylesheetFiles(tree: Tree, startDirectory: string = '/'): s
       }
     });
   };
-  visitDir(startDirectory);
+  visitDir(startDirectory as Path);
   return result;
 }

src/cdk/schematics/ng-update/html-parsing/elements.ts

@@ -6,23 +6,23 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {DefaultTreeDocument, DefaultTreeElement, parseFragment} from 'parse5';
+import {ChildNode, Element, parseFragment} from 'parse5';
 
 /**
  * Parses a HTML fragment and traverses all AST nodes in order find elements that
  * include the specified attribute.
  */
 export function findElementsWithAttribute(html: string, attributeName: string) {
-  const document = parseFragment(html, {sourceCodeLocationInfo: true}) as DefaultTreeDocument;
-  const elements: DefaultTreeElement[] = [];
+  const document = parseFragment(html, {sourceCodeLocationInfo: true});
+  const elements: Element[] = [];
 
-  const visitNodes = nodes => {
-    nodes.forEach(node => {
+  const visitNodes = (nodes: ChildNode[]) => {
+    nodes.forEach((node: Element) => {
       if (node.childNodes) {
         visitNodes(node.childNodes);
       }
 
-      if (node.attrs && node.attrs.some(attr => attr.name === attributeName.toLowerCase())) {
+      if (node.attrs?.some(attr => attr.name === attributeName.toLowerCase())) {
         elements.push(node);
       }
     });
@@ -54,7 +54,7 @@ export function findAttributeOnElementWithAttrs(html: string, name: string, attr
 }
 
 /** Shorthand function that checks if the specified element contains the given attribute. */
-function hasElementAttribute(element: DefaultTreeElement, attributeName: string): boolean {
+function hasElementAttribute(element: Element, attributeName: string): boolean {
   return element.attrs && element.attrs.some(attr => attr.name === attributeName.toLowerCase());
 }
 

src/cdk/schematics/ng-update/migrations/attribute-selectors.ts

@@ -23,23 +23,23 @@ export class AttributeSelectorsMigration extends Migration<UpgradeData> {
   data = getVersionUpgradeData(this, 'attributeSelectors');
 
   // Only enable the migration rule if there is upgrade data.
-  enabled = this.data.length !== 0;
+  enabled: boolean = this.data.length !== 0;
 
-  visitNode(node: ts.Node) {
+  override visitNode(node: ts.Node) {
     if (ts.isStringLiteralLike(node)) {
       this._visitStringLiteralLike(node);
     }
   }
 
-  visitTemplate(template: ResolvedResource) {
+  override visitTemplate(template: ResolvedResource) {
     this.data.forEach(selector => {
       findAllSubstringIndices(template.content, selector.replace)
           .map(offset => template.start + offset)
           .forEach(start => this._replaceSelector(template.filePath, start, selector));
     });
   }
 
-  visitStylesheet(stylesheet: ResolvedResource): void {
+  override visitStylesheet(stylesheet: ResolvedResource): void {
     this.data.forEach(selector => {
       const currentSelector = `[${selector.replace}]`;
       const updatedSelector = `[${selector.replaceWith}]`;

src/cdk/schematics/ng-update/migrations/class-inheritance.ts

@@ -26,14 +26,14 @@ export class ClassInheritanceMigration extends Migration<UpgradeData> {
   // Only enable the migration rule if there is upgrade data.
   enabled = this.propertyNames.size !== 0;
 
-  init(): void {
+  override init(): void {
     getVersionUpgradeData(this, 'propertyNames')
         .filter(data => data.limitedTo && data.limitedTo.classes)
         .forEach(
             data => data.limitedTo.classes.forEach(name => this.propertyNames.set(name, data)));
   }
 
-  visitNode(node: ts.Node): void {
+  override visitNode(node: ts.Node): void {
     if (ts.isClassDeclaration(node)) {
       this._visitClassDeclaration(node);
     }

src/cdk/schematics/ng-update/migrations/class-names.ts

@@ -43,7 +43,7 @@ export class ClassNamesMigration extends Migration<UpgradeData> {
   // Only enable the migration rule if there is upgrade data.
   enabled = this.data.length !== 0;
 
-  visitNode(node: ts.Node): void {
+  override visitNode(node: ts.Node): void {
     if (ts.isIdentifier(node)) {
       this._visitIdentifier(node);
     }

src/cdk/schematics/ng-update/migrations/constructor-signature.ts

@@ -40,7 +40,7 @@ export class ConstructorSignatureMigration extends Migration<UpgradeData> {
   // Only enable the migration rule if there is upgrade data.
   enabled = this.data.length !== 0;
 
-  visitNode(node: ts.Node): void {
+  override visitNode(node: ts.Node): void {
     if (ts.isSourceFile(node)) {
       this._visitSourceFile(node);
     }

src/cdk/schematics/ng-update/migrations/css-selectors.ts

@@ -25,13 +25,13 @@ export class CssSelectorsMigration extends Migration<UpgradeData> {
   // Only enable the migration rule if there is upgrade data.
   enabled = this.data.length !== 0;
 
-  visitNode(node: ts.Node): void {
+  override visitNode(node: ts.Node): void {
     if (ts.isStringLiteralLike(node)) {
       this._visitStringLiteralLike(node);
     }
   }
 
-  visitTemplate(template: ResolvedResource): void {
+  override visitTemplate(template: ResolvedResource): void {
     this.data.forEach(data => {
       if (data.replaceIn && !data.replaceIn.html) {
         return;
@@ -43,7 +43,7 @@ export class CssSelectorsMigration extends Migration<UpgradeData> {
     });
   }
 
-  visitStylesheet(stylesheet: ResolvedResource): void {
+  override visitStylesheet(stylesheet: ResolvedResource): void {
     this.data.forEach(data => {
       if (data.replaceIn && !data.replaceIn.stylesheet) {
         return;

src/cdk/schematics/ng-update/migrations/element-selectors.ts

@@ -23,23 +23,23 @@ export class ElementSelectorsMigration extends Migration<UpgradeData> {
   data = getVersionUpgradeData(this, 'elementSelectors');
 
   // Only enable the migration rule if there is upgrade data.
-  enabled = this.data.length !== 0;
+  enabled: boolean = this.data.length !== 0;
 
-  visitNode(node: ts.Node): void {
+  override visitNode(node: ts.Node): void {
     if (ts.isStringLiteralLike(node)) {
       this._visitStringLiteralLike(node);
     }
   }
 
-  visitTemplate(template: ResolvedResource): void {
+  override visitTemplate(template: ResolvedResource): void {
     this.data.forEach(selector => {
       findAllSubstringIndices(template.content, selector.replace)
           .map(offset => template.start + offset)
           .forEach(start => this._replaceSelector(template.filePath, start, selector));
     });
   }
 
-  visitStylesheet(stylesheet: ResolvedResource): void {
+  override visitStylesheet(stylesheet: ResolvedResource): void {
     this.data.forEach(selector => {
       findAllSubstringIndices(stylesheet.content, selector.replace)
           .map(offset => stylesheet.start + offset)