Skip to content

Commit 14c4dba

Browse files
devversionjelbourn
authored andcommitted
build: do not generate type definitions without reference to needed global types (#17373)
Ensures that we properly generate all type definitions for source files which rely on global types from third-party type packages. This is a workaround for: bazel-contrib/rules_nodejs#1265
1 parent d4bf7be commit 14c4dba

File tree

10 files changed

+17
-11
lines changed

10 files changed

+17
-11
lines changed

src/google-maps/google-map/google-map.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9+
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
10+
/// <reference types="googlemaps" />
11+
912
import {
1013
ChangeDetectionStrategy,
1114
Component,

src/google-maps/map-info-window/map-info-window.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9+
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
10+
/// <reference types="googlemaps" />
11+
912
import {
1013
Directive,
1114
ElementRef,

src/google-maps/map-marker/map-marker.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9+
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
10+
/// <reference types="googlemaps" />
11+
912
import {
1013
ChangeDetectionStrategy,
1114
Component,

src/google-maps/tsconfig-build.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@
1111
"rootDirs": [
1212
".",
1313
"../../dist/packages/google-maps"
14-
],
15-
"types": [
16-
"googlemaps"
1714
]
1815
},
1916
"files": [

src/google-maps/tsconfig-tests.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
"module": "commonjs",
99
"target": "es5",
1010
"types": [
11-
"jasmine",
12-
"googlemaps"
13-
],
11+
"jasmine"
12+
]
1413
},
1514
"angularCompilerOptions": {
1615
"strictMetadataEmit": true,

src/google-maps/tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
"baseUrl": ".",
77
"paths": {},
88
"types": [
9-
"jasmine",
10-
"googlemaps"
9+
"jasmine"
1110
]
1211
},
1312
"include": [

src/youtube-player/tsconfig-build.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
".",
1313
"../../dist/packages/youtube-player"
1414
],
15-
"types": ["youtube"]
1615
},
1716
"files": [
1817
"public-api.ts",

src/youtube-player/tsconfig-tests.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"importHelpers": false,
88
"module": "commonjs",
99
"target": "es5",
10-
"types": ["jasmine", "youtube"]
10+
"types": ["jasmine"]
1111
},
1212
"angularCompilerOptions": {
1313
"strictMetadataEmit": true,

src/youtube-player/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"rootDir": "..",
66
"baseUrl": ".",
77
"paths": {},
8-
"types": ["jasmine", "youtube"]
8+
"types": ["jasmine"]
99
},
1010
"include": ["*.ts"]
1111
}

src/youtube-player/youtube-player.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9+
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1265
10+
/// <reference types="youtube" />
11+
912
import {
1013
AfterViewInit,
1114
ChangeDetectionStrategy,

0 commit comments

Comments
 (0)