Skip to content

Commit 008e1ab

Browse files
devversionjelbourn
authored andcommitted
build: fix screenshot golden upload (#4128)
* Fixes the Google Cloud Storage upload for the goldens. The issue seems to happen because the `@google-cloud/storage` package has been installed manually and the `google-cloud` now uses a different storage version than before. Noticed this while debugging the `google-cloud` package.
1 parent e73af7d commit 008e1ab

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
"fs-extra": "^2.0.0",
6969
"glob": "^7.1.1",
7070
"google-closure-compiler": "^20170218.0.0",
71-
"google-cloud": "^0.48.0",
7271
"gulp": "^3.9.1",
7372
"gulp-clean": "^0.3.2",
7473
"gulp-clean-css": "^3.0.3",

tools/gulp/util/firebase.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
const firebaseAdmin = require('firebase-admin');
22
const firebase = require('firebase');
3-
const gcloud = require('google-cloud');
3+
const cloudStorage = require('@google-cloud/storage');
44

55
const config = require('../../../functions/config.json');
66

@@ -27,7 +27,7 @@ export function openFirebaseDashboardDatabase() {
2727
* The files uploaded to google cloud are also available to firebase storage.
2828
*/
2929
export function openScreenshotsBucket() {
30-
let gcs = gcloud.storage({
30+
let gcs = cloudStorage({
3131
projectId: 'material2-screenshots',
3232
credentials: {
3333
client_email: 'firebase-adminsdk-t4209@material2-screenshots.iam.gserviceaccount.com',

0 commit comments

Comments
 (0)