Skip to content

Commit a13bf9b

Browse files
myspiveydavideast
authored andcommitted
fix(): Removing errant old import. Updating build with latest namespace. Fixing import for main @firebase/app. This resolves failing tests.
1 parent 7ec51b2 commit a13bf9b

File tree

3 files changed

+15
-16
lines changed

3 files changed

+15
-16
lines changed

src/core/firebase.app.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { InjectionToken, } from '@angular/core';
22
import { FirebaseAppConfig } from './';
3-
import { firebase } from '@firebase/app';
3+
import firebase from '@firebase/app';
44

55
import { FirebaseApp as FBApp } from '@firebase/app-types';
66
import { FirebaseAuth } from '@firebase/auth-types';

src/database-deprecated/firebase_list_factory.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import * as database from '@firebase/database-types';
22
import { ZoneScheduler } from 'angularfire2';
33
import * as utils from './utils';
4-
import 'firebase/database';
54
import { AFUnwrappedDataSnapshot } from './interfaces';
65
import { FirebaseListObservable } from './firebase_list_observable';
76
import { Observer } from 'rxjs/Observer';

tools/build.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ const GLOBALS = {
5454
'@angular/core': 'ng.core',
5555
'@angular/compiler': 'ng.compiler',
5656
'@angular/platform-browser': 'ng.platformBrowser',
57-
'firebase/auth': 'firebase',
58-
'firebase/app': 'firebase',
59-
'firebase/database': 'firebase',
60-
'firebase/firestore': 'firebase',
61-
'firebase/storage': 'firebase',
57+
'@firebase/auth': 'firebase',
58+
'@firebase/app': 'firebase',
59+
'@firebase/database': 'firebase',
60+
'@firebase/firestore': 'firebase',
61+
'@firebase/storage': 'firebase',
6262
'rxjs/scheduler/queue': 'Rx.Scheduler',
6363
'@angular/core/testing': 'ng.core.testing',
6464
'angularfire2': 'angularfire2',
@@ -123,8 +123,8 @@ const TSC_TEST_ARGS = [`-p`, `${process.cwd()}/src/tsconfig-test.json`];
123123

124124
/**
125125
* Create an Observable of a spawned child process.
126-
* @param {string} command
127-
* @param {string[]} args
126+
* @param {string} command
127+
* @param {string[]} args
128128
*/
129129
function spawnObservable(command, args) {
130130
return Observable.create(observer => {
@@ -151,8 +151,8 @@ function generateBundle(entry, { dest, globals, moduleName }) {
151151

152152
/**
153153
* Create a UMD bundle given a module name.
154-
* @param {string} name
155-
* @param {Object} globals
154+
* @param {string} name
155+
* @param {Object} globals
156156
*/
157157
function createUmd(name, globals) {
158158
// core module is angularfire2 the rest are angularfire2.feature
@@ -177,15 +177,15 @@ function createTestUmd(globals) {
177177

178178
/**
179179
* Get the file path of the src package.json for a module
180-
* @param {string} moduleName
180+
* @param {string} moduleName
181181
*/
182182
function getSrcPackageFile(moduleName) {
183183
return SRC_PKG_PATHS[moduleName];
184184
}
185185

186186
/**
187187
* Get the file path of the dist package.json for a module
188-
* @param {string} moduleName
188+
* @param {string} moduleName
189189
*/
190190
function getDestPackageFile(moduleName) {
191191
return DEST_PKG_PATHS[moduleName];
@@ -194,8 +194,8 @@ function getDestPackageFile(moduleName) {
194194
/**
195195
* Create an observable of package.json dependency version replacements.
196196
* This keeps the dependency versions across each package in sync.
197-
* @param {string} name
198-
* @param {Object} versions
197+
* @param {string} name
198+
* @param {Object} versions
199199
*/
200200
function replaceVersionsObservable(name, versions) {
201201
return Observable.create((observer) => {
@@ -287,7 +287,7 @@ function buildModule(name, globals) {
287287

288288
/**
289289
* Create an observable of module build status. This method builds
290-
* @param {Object} globals
290+
* @param {Object} globals
291291
*/
292292
function buildModules(globals) {
293293
const core$ = buildModule('core', globals);

0 commit comments

Comments
 (0)