From 86130bd7edc9aa953d19f34c038f6b6338e7629e Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Fri, 12 Jun 2020 13:19:48 +0200 Subject: [PATCH 1/2] feat(@schematics/angular): emit declaration maps for local library builds With this change we enable emitting declaration maps when building libraries to be consumed locally as this improved DX as this will allow editors to go to the original typescript file when using `Go to Definition`. For production builds, declaration maps are disabled because they are not useful since the source files are not included in the distributable package. Closes #17888 --- .../angular/library/files/tsconfig.lib.json.template | 1 + .../angular/library/files/tsconfig.lib.prod.json.template | 3 +++ 2 files changed, 4 insertions(+) diff --git a/packages/schematics/angular/library/files/tsconfig.lib.json.template b/packages/schematics/angular/library/files/tsconfig.lib.json.template index 8f7b94ed501a..bbd127f03731 100644 --- a/packages/schematics/angular/library/files/tsconfig.lib.json.template +++ b/packages/schematics/angular/library/files/tsconfig.lib.json.template @@ -4,6 +4,7 @@ "outDir": "<%= relativePathToWorkspaceRoot %>/out-tsc/lib", "target": "es2015", "declaration": true, + "declarationMap": true, "inlineSources": true, "types": [], "lib": [ diff --git a/packages/schematics/angular/library/files/tsconfig.lib.prod.json.template b/packages/schematics/angular/library/files/tsconfig.lib.prod.json.template index cbae79422480..04c0e66277e0 100644 --- a/packages/schematics/angular/library/files/tsconfig.lib.prod.json.template +++ b/packages/schematics/angular/library/files/tsconfig.lib.prod.json.template @@ -1,5 +1,8 @@ { "extends": "./tsconfig.lib.json", + "compilerOptions": { + "declarationMap": false + }, "angularCompilerOptions": { "enableIvy": false } From e9e58c265f55f3e82d7f70838c70a6395154b922 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Fri, 12 Jun 2020 13:23:19 +0200 Subject: [PATCH 2/2] test: update tsconfigs for library tyesting project --- .../test/ng-packaged/projects/lib/tsconfig.lib.json | 6 ++++++ .../test/ng-packaged/projects/lib/tsconfig.lib.prod.json | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.json b/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.json index fbcea14bb9db..cc9fb168b02b 100644 --- a/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.json +++ b/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.json @@ -3,6 +3,7 @@ "compilerOptions": { "target": "es2015", "declaration": true, + "declarationMap": true, "inlineSources": true, "types": [], "lib": [ @@ -10,6 +11,11 @@ "es2018" ] }, + "angularCompilerOptions": { + "skipTemplateCodegen": true, + "strictMetadataEmit": true, + "enableResourceInlining": true + }, "exclude": [ "src/test.ts", "**/*.spec.ts" diff --git a/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.prod.json b/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.prod.json index eb3a0142de75..04c0e66277e0 100644 --- a/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.prod.json +++ b/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/tsconfig.lib.prod.json @@ -1,9 +1,9 @@ { "extends": "./tsconfig.lib.json", + "compilerOptions": { + "declarationMap": false + }, "angularCompilerOptions": { - "skipTemplateCodegen": true, - "strictMetadataEmit": true, - "enableResourceInlining": true, "enableIvy": false } }