Skip to content

fix(@angular-devkit/schematics-cli): fix list-schematics is not printing anything #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/angular_devkit/benchmark/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ ts_library(
module_root = "src/index.d.ts",
deps = [
"//packages/angular_devkit/core",
"//packages/angular_devkit/core:node",
"@rxjs",
"@rxjs//operators",
# @typings: node
Expand All @@ -46,6 +47,7 @@ ts_library(
deps = [
":benchmark",
"//packages/angular_devkit/core",
"//packages/angular_devkit/core:node",
"@rxjs",
"@rxjs//operators",
# @typings: jasmine
Expand Down
5 changes: 3 additions & 2 deletions packages/angular_devkit/benchmark/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*/

import { logging, tags, terminal } from '@angular-devkit/core';
import { ProcessOutput } from '@angular-devkit/core/node';
import { appendFileSync, writeFileSync } from 'fs';
import * as minimist from 'minimist';
import { filter, map, toArray } from 'rxjs/operators';
Expand All @@ -19,8 +20,8 @@ import { runBenchmark } from '../src/run-benchmark';

export interface MainOptions {
args: string[];
stdout?: { write(buffer: string | Buffer): boolean };
stderr?: { write(buffer: string | Buffer): boolean };
stdout?: ProcessOutput;
stderr?: ProcessOutput;
}

export async function main({
Expand Down
15 changes: 11 additions & 4 deletions packages/angular_devkit/core/node/cli-logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,25 @@
import { filter } from 'rxjs/operators';
import { logging, terminal } from '../src';

export interface ProcessOutput {
write(buffer: string | Buffer): boolean;
}

/**
* A Logger that sends information to STDOUT and STDERR.
*/
export function createConsoleLogger(verbose = false): logging.Logger {
export function createConsoleLogger(
verbose = false,
stdout: ProcessOutput = process.stdout,
stderr: ProcessOutput = process.stderr,
): logging.Logger {
const logger = new logging.IndentLogger('cling');

logger
.pipe(filter(entry => (entry.level != 'debug' || verbose)))
.subscribe(entry => {
let color: (s: string) => string = x => terminal.dim(terminal.white(x));
let output = process.stdout;
let output = stdout;
switch (entry.level) {
case 'info':
color = terminal.white;
Expand All @@ -29,11 +36,11 @@ export function createConsoleLogger(verbose = false): logging.Logger {
break;
case 'error':
color = terminal.red;
output = process.stderr;
output = stderr;
break;
case 'fatal':
color = (x: string) => terminal.bold(terminal.red(x));
output = process.stderr;
output = stderr;
break;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/angular_devkit/schematics/src/engine/engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ export class SchematicEngine<CollectionT extends object, SchematicT extends obje
}

// remove duplicates
return [...new Set(names)];
return [...new Set(names)].sort();
}

transformOptions<OptionT extends object, ResultT extends object>(
Expand Down
Loading