Skip to content

Commit b2e81a8

Browse files
committed
feat(@angular/cli): use tslint language service
tslint-language-service can support tslint rules that require the type checker share program representation with TypeScript (no need to reanalyze) Fixes: #6125
1 parent 01cbf65 commit b2e81a8

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

packages/@angular/cli/blueprints/ng/files/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,13 @@
4040
"karma": "~1.7.0",
4141
"karma-chrome-launcher": "~2.1.1",
4242
"karma-cli": "~1.0.1",
43+
"karma-coverage-istanbul-reporter": "^1.2.1",
4344
"karma-jasmine": "~1.1.0",
4445
"karma-jasmine-html-reporter": "^0.2.2",
45-
"karma-coverage-istanbul-reporter": "^1.2.1",
4646
"protractor": "~5.1.2",
4747
"ts-node": "~3.0.4",
48-
"tslint": "~5.3.2",<% } %>
48+
"tslint": "~5.3.2",
49+
"tslint-language-service": "^0.9.6",<% } %>
4950
"typescript": "~2.3.3"
5051
}
5152
}

packages/@angular/cli/blueprints/ng/files/tsconfig.json

+6-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515
"lib": [
1616
"es2016",
1717
"dom"
18-
]
18+
]<% if (!minimal) { %>,
19+
"plugins": [
20+
{
21+
"name": "tslint-language-service"
22+
}
23+
]<% } %>
1924
}
2025
}

tests/e2e/tests/commands/new/new-minimal.ts

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export default function() {
2222
.then(() => expectToFail(() => expectFileToMatch('package.json', '"protractor":')))
2323
.then(() => expectToFail(() => expectFileToMatch('package.json', '"karma":')))
2424
.then(() => expectToFail(() => expectFileToMatch('package.json', '"jasmine-core":')))
25+
.then(() => expectToFail(() => expectFileToMatch('package.json', '"tslint-language-service":')))
2526

2627
// Try to run a build.
2728
.then(() => ng('build'));

0 commit comments

Comments
 (0)