Skip to content

Commit 99aeeee

Browse files
committed
removing a-t-l entirely
1 parent 73bdf95 commit 99aeeee

File tree

5 files changed

+30
-16
lines changed

5 files changed

+30
-16
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"@angular/tsc-wrapped": "^0.3.0",
4848
"angular2-template-loader": "^0.5.0",
4949
"autoprefixer": "^6.5.3",
50-
"awesome-typescript-loader": "^2.2.3",
5150
"chalk": "^1.1.3",
5251
"common-tags": "^1.3.1",
5352
"compression-webpack-plugin": "^0.3.2",
@@ -60,6 +59,7 @@
6059
"ember-cli-normalize-entity-name": "^1.0.0",
6160
"ember-cli-preprocess-registry": "^2.0.0",
6261
"ember-cli-string-utils": "^1.0.0",
62+
"enhanced-resolve": "^2.3.0",
6363
"exists-sync": "0.0.3",
6464
"extract-text-webpack-plugin": "^2.0.0-beta.4",
6565
"file-loader": "^0.8.5",

packages/angular-cli/models/webpack-build-test.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@
22

33
const path = require('path');
44
const webpack = require('webpack');
5-
const atl = require('awesome-typescript-loader');
5+
const ngtools = require('@ngtools/webpack');
6+
7+
8+
const g = global;
9+
const webpackLoader = g['angularCliIsLocal']
10+
? g.angularCliPackages['@ngtools/webpack'].main
11+
: '@ngtools/webpack';
12+
613

714
const getWebpackTestConfig = function (projectRoot, environment, appConfig, testConfig) {
815

@@ -48,8 +55,8 @@ const getWebpackTestConfig = function (projectRoot, environment, appConfig, test
4855
resolve: {
4956
extensions: ['.ts', '.js'],
5057
plugins: [
51-
new atl.TsConfigPathsPlugin({
52-
tsconfig: path.resolve(appRoot, appConfig.tsconfig)
58+
new ngtools.PathsPlugin({
59+
tsConfigPath: path.resolve(appRoot, appConfig.tsconfig)
5360
})
5461
]
5562
},
@@ -74,7 +81,7 @@ const getWebpackTestConfig = function (projectRoot, environment, appConfig, test
7481
test: /\.ts$/,
7582
loaders: [
7683
{
77-
loader: 'awesome-typescript-loader',
84+
loader: webpackLoader,
7885
query: {
7986
tsconfig: path.resolve(appRoot, appConfig.tsconfig),
8087
module: 'commonjs',

packages/angular-cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
"@angular/core": "^2.1.0",
3333
"@ngtools/webpack": "^1.0.0",
3434
"angular2-template-loader": "^0.5.0",
35-
"awesome-typescript-loader": "^2.2.3",
3635
"chalk": "^1.1.3",
3736
"common-tags": "^1.3.1",
3837
"compression-webpack-plugin": "^0.3.2",
@@ -45,6 +44,7 @@
4544
"ember-cli-normalize-entity-name": "^1.0.0",
4645
"ember-cli-preprocess-registry": "^2.0.0",
4746
"ember-cli-string-utils": "^1.0.0",
47+
"enhanced-resolve": "^2.3.0",
4848
"exists-sync": "0.0.3",
4949
"extract-text-webpack-plugin": "^2.0.0-beta.4",
5050
"file-loader": "^0.8.5",

packages/webpack/src/index.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import 'reflect-metadata';
22

3-
export * from './plugin'
4-
export {ngcLoader as default} from './loader'
3+
export * from './plugin';
4+
export {ngcLoader as default} from './loader';
5+
export {PathsPlugin} from './paths-plugin';

packages/webpack/src/paths-plugin.ts

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,15 @@ export class PathsPlugin implements Tapable {
4242

4343
private _absoluteBaseUrl: string;
4444

45-
private static _loadOptionsFromTsConfig(tsConfigPath: string, host: ts.CompilerHost):
45+
private static _loadOptionsFromTsConfig(tsConfigPath: string, host?: ts.CompilerHost):
4646
ts.CompilerOptions {
47-
const tsConfig = ts.readConfigFile(tsConfigPath, (path: string) => host.readFile(path));
47+
const tsConfig = ts.readConfigFile(tsConfigPath, (path: string) => {
48+
if (host) {
49+
return host.readFile(path)
50+
} else {
51+
return ts.sys.readFile(path);
52+
}
53+
});
4854
if (tsConfig.error) {
4955
throw tsConfig.error;
5056
}
@@ -58,16 +64,16 @@ export class PathsPlugin implements Tapable {
5864
}
5965
this._tsConfigPath = options.tsConfigPath;
6066

61-
if (options.hasOwnProperty('compilerHost')) {
62-
this._host = options.compilerHost;
67+
if (options.hasOwnProperty('compilerOptions')) {
68+
this._compilerOptions = Object.assign({}, options.compilerOptions);
6369
} else {
64-
this._host = ts.createCompilerHost(this._compilerOptions, false);
70+
this._compilerOptions = PathsPlugin._loadOptionsFromTsConfig(this._tsConfigPath, null);
6571
}
6672

67-
if (options.hasOwnProperty('compilerOptions')) {
68-
this._compilerOptions = Object.assign({}, options.compilerOptions);
73+
if (options.hasOwnProperty('compilerHost')) {
74+
this._host = options.compilerHost;
6975
} else {
70-
this._compilerOptions = PathsPlugin._loadOptionsFromTsConfig(this._tsConfigPath, this._host);
76+
this._host = ts.createCompilerHost(this._compilerOptions, false);
7177
}
7278

7379
this.source = 'described-resolve';

0 commit comments

Comments
 (0)