chore: make Angular2App a full broccoli plugin.

`toTree()` is always called and nothing else is ever done anyway.

Author: hansl

addon/ng2/blueprints/ng2/files/angular-cli-build.js

@@ -3,8 +3,7 @@
 var Angular2App = require('angular-cli/lib/broccoli/angular2-app');
 
 module.exports = function(defaults) {
-  var app = new Angular2App(defaults, {
+  return new Angular2App(defaults, {
     vendorNpmFiles: []
   });
-  return app.toTree();
 };

lib/broccoli/angular2-app.js

@@ -1,19 +1,22 @@
 'use strict';
+const fs = require('fs');
+const glob = require('glob');
 const path = require('path');
+
 const isProduction = require('./is-production');
-const configReplace = require('./broccoli-config-replace');
-const compileWithTypescript = require('./broccoli-typescript');
-const SwManifest = require('./service-worker-manifest').default;
-const fs = require('fs');
-const Funnel = require('broccoli-funnel');
-const mergeTrees = require('broccoli-merge-trees');
-const uglify = require('broccoli-uglify-js');
+const BroccoliPlugin = require('broccoli-writer');
+const BroccoliConfigReplace = require('./broccoli-config-replace');
+const BroccoliTypescript = require('./broccoli-typescript');
+const BroccoliSwManifest = require('./service-worker-manifest').default;
+const BroccoliFunnel = require('broccoli-funnel');
+const BroccoliMergeTrees = require('broccoli-merge-trees');
+const BroccoliUglify = require('broccoli-uglify-js');
 const Project = require('ember-cli/lib/models/project');
-const glob = require('glob');
 
 
-class Angular2App {
+class Angular2App extends BroccoliPlugin {
   constructor(defaults, options) {
+    super();
     options = options || {};
 
     this._options = options;
@@ -27,6 +30,33 @@ class Angular2App {
 
     this._initProject();
     this._notifyAddonIncluded();
+
+    this._tree = this._buildTree();
+  }
+
+  /**
+   * For backward compatibility.
+   * @public
+   * @method toTree
+   * @return {BroccoliPlugin} A broccoli plugin.
+   */
+  toTree() {
+    // eslint-disable-next-line no-console
+    console.warn('Angular2App is now a broccoli plugin. Calling toTree() is deprecated.');
+    return this;
+  }
+
+  /**
+   * @override
+   */
+  read(readTree) {
+    return this._tree.read(readTree);
+  }
+  /**
+   * @override
+   */
+  cleanup() {
+    return this._tree.cleanup();
   }
 
   /**
@@ -39,11 +69,11 @@ class Angular2App {
    * - Apply/remove stuff based on the environment (dev|prod)
    * - Return the app trees to be extended
    *
-   * @public
-   * @method toTree
-   * @return {Array<Tree>} The app trees that can be used to extend the build.
+   * @private
+   * @method _buildTree
+   * @return {BroccoliFunnel} The app trees that can be used to extend the build.
    */
-  toTree() {
+  _buildTree() {
     var assetTree = this._getAssetsTree();
     var tsTree = this._getTsTree();
     var indexTree = this._getIndexTree();
@@ -67,8 +97,8 @@ class Angular2App {
                                                                this._options.compassCompiler)
       ).filter(x => !!x);
 
-    var merged = mergeTrees(buildTrees, { overwrite: true });
-    return new Funnel(mergeTrees([merged, new SwManifest([merged])]), {
+    var merged = BroccoliMergeTrees(buildTrees, { overwrite: true });
+    return new BroccoliFunnel(BroccoliMergeTrees([merged, new BroccoliSwManifest([merged])]), {
       destDir: this._destDir
     });
   }
@@ -184,13 +214,13 @@ class Angular2App {
       'index.html'
     ];
 
-    var index = new Funnel(this._sourceDir, {
+    var index = new BroccoliFunnel(this._sourceDir, {
       files: files,
-      description: 'Funnel: index.html'
+      description: 'BroccoliFunnel: index.html'
     });
 
 
-    return configReplace(index, {
+    return BroccoliConfigReplace(index, {
       files: [htmlName],
       patterns: this._getReplacePatterns()
     });
@@ -204,7 +234,7 @@ class Angular2App {
    * @return {Tree} Tree for the src dir.
    */
   _getSourceTree() {
-    return new Funnel(this._sourceDir, {
+    return new BroccoliFunnel(this._sourceDir, {
       include: ['*.ts', '**/*.ts', '**/*.d.ts'],
       destDir: this._sourceDir
     });
@@ -218,7 +248,7 @@ class Angular2App {
    * @return {Tree} Tree for the src dir.
    */
   _getTypingsTree() {
-    return new Funnel('typings', {
+    return new BroccoliFunnel('typings', {
       include: ['browser.d.ts', 'browser/**'],
       destDir: 'typings'
     });
@@ -266,18 +296,18 @@ class Angular2App {
     // element.
     tsconfig.files = tsconfig.files.map(name => path.join(this._sourceDir, name));
 
-    var mergedTree = mergeTrees([sourceTree, typingsTree, configTree], { overwrite: true });
-    var tsTree = new compileWithTypescript(mergedTree, tsconfig);
+    var mergedTree = BroccoliMergeTrees([sourceTree, typingsTree, configTree], { overwrite: true });
+    var tsTree = new BroccoliTypescript(mergedTree, tsconfig);
 
     var tsTreeExcludes = ['*.d.ts', 'tsconfig.json'];
     var excludeSpecFiles = '**/*.spec.*';
 
     if (isProduction) {
       tsTreeExcludes.push(excludeSpecFiles);
-      tsTree = uglify(tsTree);
+      tsTree = BroccoliUglify(tsTree);
     }
 
-    tsTree = new Funnel(tsTree, {
+    tsTree = new BroccoliFunnel(tsTree, {
       srcDir: this._sourceDir,
       exclude: tsTreeExcludes
     });
@@ -311,12 +341,10 @@ class Angular2App {
       vendorNpmFiles = vendorNpmFiles.concat(this._options.vendorNpmFiles);
     }
 
-    var vendorNpmTree = new Funnel('node_modules', {
+    return new BroccoliFunnel('node_modules', {
       include: vendorNpmFiles,
       destDir: 'vendor'
     });
-
-    return vendorNpmTree;
   }
 
   /**
@@ -327,7 +355,7 @@ class Angular2App {
    * @return {Tree} The assets tree.
    */
   _getAssetsTree() {
-    return new Funnel(this._sourceDir, {
+    return new BroccoliFunnel(this._sourceDir, {
       include: ['**/*.*'],
       exclude: [
         '**/*.ts',
@@ -349,7 +377,7 @@ class Angular2App {
    * @return {Tree} The dotfiles exclusion tree.
    */
   _getPublicTree() {
-    return new Funnel('public', {
+    return new BroccoliFunnel('public', {
       exclude: ['**/.*'],
       allowEmpty: true
     });
@@ -364,8 +392,8 @@ class Angular2App {
    */
   _getConfigTree() {
     var envConfigFile = isProduction ? 'environment.prod.ts' : 'environment.dev.ts';
-    // console.log(envConfigFile);
-    return new Funnel('config', {
+
+    return new BroccoliFunnel('config', {
       include: [envConfigFile],
       destDir: 'src/client/app',
       getDestinationPath: () => 'environment.ts'