Skip to content

Commit 317602e

Browse files
nlm-prohansl
authored andcommitted
refactor(@angular/cli): remove v8-profiler typings
Remove dependency to the @types/v8-profiler Profiler type as we don't want to depend on it. See #12411 (comment)
1 parent 93ccb82 commit 317602e

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
"@types/request": "^2.47.1",
8888
"@types/semver": "^5.5.0",
8989
"@types/source-map": "0.5.2",
90-
"@types/v8-profiler": "^0.0.5",
9190
"@types/webpack": "^4.4.11",
9291
"@types/webpack-dev-server": "^3.1.0",
9392
"@types/webpack-sources": "^0.1.5",

packages/angular/cli/lib/init.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ import { SemVer } from 'semver';
1616
import { Duplex } from 'stream';
1717
import { isWarningEnabled } from '../utilities/config';
1818

19-
// from @types/v8-profiler (no dependency to v8-profiler as we use v8-profiler-node8)
20-
import { Profiler } from 'v8-profiler'; // tslint:disable-line:no-implicit-dependencies
21-
2219
const packageJson = require('../package.json');
2320

2421
function _fromPackageJson(cwd?: string) {
@@ -46,7 +43,10 @@ function _fromPackageJson(cwd?: string) {
4643

4744
// Check if we need to profile this CLI run.
4845
if (process.env['NG_CLI_PROFILING']) {
49-
let profiler: Profiler;
46+
let profiler: {
47+
startProfiling: (name?: string, recsamples?: boolean) => void;
48+
stopProfiling: (name?: string) => any; // tslint:disable-line:no-any
49+
};
5050
try {
5151
profiler = require('v8-profiler-node8'); // tslint:disable-line:no-implicit-dependencies
5252
} catch (err) {

yarn.lock

-6
Original file line numberDiff line numberDiff line change
@@ -463,12 +463,6 @@
463463
version "1.0.1"
464464
resolved "https://codeload.github.com/quicktype/types-urijs/tar.gz/a23603a04e31e883a92244bff8515e3d841a8b98"
465465

466-
"@types/v8-profiler@^0.0.5":
467-
version "0.0.5"
468-
resolved "https://registry.yarnpkg.com/@types/v8-profiler/-/v8-profiler-0.0.5.tgz#2b9f0b7ba3294f5b177b66790607772910a195f9"
469-
dependencies:
470-
"@types/node" "*"
471-
472466
"@types/webpack-dev-server@^3.1.0":
473467
version "3.1.0"
474468
resolved "https://registry.yarnpkg.com/@types/webpack-dev-server/-/webpack-dev-server-3.1.0.tgz#1fae06ad346d2dd09bc5e34745723946458eed58"

0 commit comments

Comments
 (0)