chore: force component and route names to have dashes

Author: Brocco

addon/ng2/blueprints/component/index.js

@@ -4,6 +4,17 @@ var dynamicPathParser = require('../../utilities/dynamic-path-parser');
 var addBarrelRegistration = require('../../utilities/barrel-management');
 var getFiles = Blueprint.prototype.files;
 
+function validateName(name) {
+  if (name.indexOf('-') >= 0) {
+    return true;
+  } else if (name === name.toUpperCase()) {
+    return false;
+  } else if (name === name.toLowerCase()) {
+    return false;
+  }
+  return true;
+}
+
 module.exports = {
   description: '',
 
@@ -16,6 +27,11 @@ module.exports = {
     var parsedPath = dynamicPathParser(this.project, entityName);
 
     this.dynamicPath = parsedPath;
+    
+    if (!validateName(parsedPath.name)) {
+      throw 'Invalid name. Names must be camelCase or kabob-case';
+    }
+    
     return parsedPath.name;
   },
 

tests/acceptance/generate-component.spec.js

@@ -137,4 +137,26 @@ describe('Acceptance: ng generate component', function () {
       expect(existsSync(testPath)).to.equal(false);
     });
   });
+  
+  it('ng generate component mycomp will fail: no dashes in name', () => {
+    return ng(['generate', 'component', 'mycomp'])
+      .then((exitCode) => {
+        expect(exitCode).to.equal(1);
+      });
+  });
+  
+  it('ng generate component MYCOMP will fail: no dashes in name', () => {
+    return ng(['generate', 'component', 'MYCOMP'])
+      .then((exitCode) => {
+        expect(exitCode).to.equal(1);
+      });
+  });
+  
+  it('ng generate component myComp will succeed', () => {
+    return ng(['generate', 'component', 'myComp'])
+      .then(() => {
+        var testPath = path.join(root, 'tmp', 'foo', 'src', 'client', 'app', 'my-comp', 'my-comp.component.ts');
+        expect(existsSync(testPath)).to.equal(true);
+      });
+  });
 });