fix: regenerate the program on file change, and only once per rerun

Author: hansl

lib/broccoli/broccoli-typescript.js

@@ -52,6 +52,8 @@ class BroccoliTypeScriptCompiler extends Plugin {
     var entries = this.listEntries();
     const inputPath = this.inputPaths[0];
 
+    const pathsToEmit = [];
+
     entries.forEach(entry => {
       const tsFilePath = path.join(inputPath, entry.relativePath);
       if (!tsFilePath.match(/\.ts$/) || !fs.existsSync(tsFilePath)) {
@@ -66,13 +68,11 @@ class BroccoliTypeScriptCompiler extends Plugin {
         // not get compiled. It needs to be referenced at some point, and unless we
         // add the spec files first (which we don't know the order), it won't.
         // So make every new files an entry point instead.
-        // TODO(hansl): We should rather build a list and recreate the program only once.
-        //              We need to investigate if we should emit files that are not
+        // TODO(hansl): We need to investigate if we should emit files that are not
         //              referenced. This doesn't take that into account.
         this._tsServiceHost.fileNames.push(tsFilePath);
 
-        // Force the TS Service to recreate the program (ie. call synchronizeHostData).
-        this._tsServiceHost.projectVersion++;
+        pathsToEmit.push(tsFilePath);
       } else if (this._fileRegistry[tsFilePath].version >= entry.mtime) {
         // Nothing to do for this file. Just link the cached outputs.
         this._fileRegistry[tsFilePath].outputs.forEach(absoluteFilePath => {
@@ -83,21 +83,29 @@ class BroccoliTypeScriptCompiler extends Plugin {
         return;
       } else {
         this._fileRegistry[tsFilePath].version = entry.mtime;
+        pathsToEmit.push(tsFilePath);
       }
+    });
 
-      var output = this._tsService.getEmitOutput(tsFilePath);
-      if (output.emitSkipped) {
-        var errorFound = this.collectErrors(tsFilePath);
-        if (errorFound) {
-          pathsWithErrors.push(tsFilePath);
-          errorMessages.push(errorFound);
+    if (pathsToEmit.length > 0) {
+      // Force the TS Service to recreate the program (ie. call synchronizeHostData).
+      this._tsServiceHost.projectVersion++;
+
+      pathsToEmit.forEach(tsFilePath => {
+        var output = this._tsService.getEmitOutput(tsFilePath);
+        if (output.emitSkipped) {
+          var errorFound = this.collectErrors(tsFilePath);
+          if (errorFound) {
+            pathsWithErrors.push(tsFilePath);
+            errorMessages.push(errorFound);
+          }
+        } else {
+          output.outputFiles.forEach(o => {
+            this._outputFile(o.name, o.text, this._fileRegistry[tsFilePath]);
+          });
         }
-      } else {
-        output.outputFiles.forEach(o => {
-          this._outputFile(o.name, o.text, this._fileRegistry[tsFilePath]);
-        });
-      }
-    });
+      });
+    }
 
     if (pathsWithErrors.length) {
       this.previousRunFailed = true;
@@ -254,6 +262,7 @@ class CustomLanguageServiceHost {
   }
 
   getScriptVersion(fileName) {
+    fileName = path.resolve(this.treeInputPath, fileName);
     return this.fileRegistry[fileName] && this.fileRegistry[fileName].version.toString();
   }