Merge pull request #2 from angular/master

Update upstream

Author: GulajavaMinistudio

.github/SAVED_REPLIES.md

@@ -0,0 +1,62 @@
+# Saved Responses for Angular CLI's Issue Tracker
+
+The following are canned responses that the Angular CLI team should use to close issues on our issue tracker that fall into the listed resolution categories.
+
+Since GitHub currently doesn't allow us to have a repository-wide or organization-wide list of [saved replies](https://help.github.com/articles/working-with-saved-replies/), these replies need to be maintained by individual team members. Since the responses can be modified in the future, all responses are versioned to simplify the process of keeping the responses up to date.
+
+
+## Angular CLI: Already Fixed (v1)
+```
+Thanks for reporting this issue. Luckily, it has already been fixed in one of the recent releases. Please update to the most recent version to resolve the problem.
+
+If the problem persists in your application after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `ng new repro-app` to create a new project where you reproduce the problem.
+```
+
+## Angular CLI: Don't Understand (v1)
+```
+I'm sorry, but we don't understand the problem you are reporting.
+
+If the problem persists, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior. You can use `ng new repro-app` to create a new project where you reproduce the problem.
+```
+
+
+## Angular CLI: Duplicate (v1)
+```
+Thanks for reporting this issue. However, this issue is a duplicate of an existing issue #<ISSUE_NUMBER>. Please subscribe to that issue for future updates.
+```
+
+
+## Angular CLI: Insufficient Information Provided (v1)
+```
+Thanks for reporting this issue. However, you didn't provide sufficient information for us to understand and reproduce the problem. Please check out [our submission guidelines](https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-submitting-an-issue) to understand why we can't act on issues that are lacking important information.
+
+If the problem persists, please file a new issue and ensure you provide all of the required information when filling out the issue template.
+```
+
+## Angular CLI: Issue Outside of Angular CLI (v1)
+```
+I'm sorry, but this issue is not caused by Angular CLI. Please contact the author(s) of project <PROJECT NAME> or file issue on their issue tracker.
+```
+
+
+## Angular CLI: Non-reproducible (v1)
+```
+I'm sorry, but we can't reproduce the problem following the instructions you provided.
+
+If the problem persists, please open a new issue following [our submission guidelines](https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-submitting-an-issue).
+```
+
+## Angular CLI: Obsolete (v1)
+```
+Thanks for reporting this issue. This issue is now obsolete due to changes in the recent releases. Please update to the most recent Angular CLI version.
+
+If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.
+```
+
+
+## Angular CLI: Support Request (v1)
+```
+Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on [StackOverflow](http://stackoverflow.com/) using tag `angular-cli`.
+
+If you are wondering why we don't resolve support issues via the issue tracker, please [check out this explanation](https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-got-a-question-or-problem).
+```

CONTRIBUTING.md

@@ -18,7 +18,17 @@ Help us keep Angular open and inclusive. Please read and follow our [Code of Con
 
 ## <a name="question"></a> Got a Question or Problem?
 
-If you have questions about how to *use* Angular CLI, please direct them to [StackOverflow][stackoverflow]. Please note that Angular CLI is still in early developer preview, and the core team's capacity to answer usage questions is limited. We are also available on [Gitter][gitter].
+Please, do not open issues for the general support questions as we want to keep GitHub issues for bug reports and feature requests. You've got much better chances of getting your question answered on [StackOverflow](https://stackoverflow.com/questions/tagged/angular-cli) where the questions should be tagged with tag `angular-cli`.
+
+StackOverflow is a much better place to ask questions since:
+
+- there are thousands of people willing to help on StackOverflow
+- questions and answers stay available for public viewing so your question / answer might help someone else
+- StackOverflow's voting system assures that the best answers are prominently visible.
+
+To save your and our time we will be systematically closing all the issues that are requests for general support and redirecting people to StackOverflow.
+
+If you would like to chat about the question in real-time, you can reach out via [our gitter channel][gitter].
 
 ## <a name="issue"></a> Found an Issue?
 If you find a bug in the source code or a mistake in the documentation, you can help us by
@@ -40,24 +50,23 @@ and help you to craft the change so that it is successfully accepted into the pr
 ## <a name="submit"></a> Submission Guidelines
 
 ### <a name="submit-issue"></a> Submitting an Issue
-Before you submit an issue, search the archive, maybe your question was already answered.
 
-If your issue appears to be a bug, and hasn't been reported, open a new issue.
-Help us to maximize the effort we can spend fixing issues and adding new
-features, by not reporting duplicate issues.  Providing the following information will increase the
-chances of your issue being dealt with quickly:
+Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
+
+We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using `ng new repro-app`. Having a reproducible scenario gives us wealth of important information without going back & forth to you with additional questions like:
+
+- version of Angular CLI used
+- `.angular-cli.json` configuration
+- 3rd-party libraries and their versions
+- and most importantly - a use-case that fails
+
+A minimal reproduce scenario using allows us to quickly confirm a bug (or point out coding problem) as well as confirm that we are fixing the right problem.
+
+We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal repository. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
 
-* **Overview of the Issue** - if an error is being thrown a non-minified stack trace helps
-* **Angular CLI Version** - what version of the CLI is affected (e.g. 0.1.2)
-* **Motivation for or Use Case** - explain what are you trying to do and why the current behavior is a bug for you
-* **Browsers and Operating System** - is this a problem with all browsers?
-* **Reproduce the Error** - provide a live example (using [Plunker][plunker],
-  [JSFiddle][jsfiddle] or [Runnable][runnable]) or a unambiguous set of steps
-* **Related Issues** - has a similar issue been reported before?
-* **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be
-  causing the problem (line of code or commit)
+Unfortunately we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced.
 
-You can file new issues by providing the above information [here](https://github.com/angular/angular-cli/issues/new).
+You can file new issues by filling out our [new issue form](https://github.com/angular/angular-cli/issues/new).
 
 
 ### <a name="submit-pr"></a> Submitting a Pull Request (PR)
@@ -95,7 +104,7 @@ Before you submit your Pull Request (PR) consider the following guidelines:
 * In GitHub, send a pull request to `angular-cli:master`.
 * If we suggest changes then:
   * Make the required updates.
-  * Re-run the Angular CLI test suites for JS and Dart to ensure tests are still passing.
+  * Re-run the Angular CLI test suites to ensure tests are still passing.
   * Rebase your branch and force push to your GitHub repository (this will update your Pull Request):
 
     ```shell
@@ -137,7 +146,7 @@ from the main (upstream) repository:
 ## <a name="rules"></a> Coding Rules
 To ensure consistency throughout the source code, keep these rules in mind as you are working:
 
-* All features or bug fixes **must be tested** by one or more specs (unit-tests).
+* All features or bug fixes **must be tested** by one or more specs (unit-tests or e2e-tests).
 * All public API methods **must be documented**. (Details TBC).
 * We follow [Google's JavaScript Style Guide][js-style-guide], but wrap all code at
   **100 characters**.
@@ -230,12 +239,9 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
 [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md
 [commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
 [corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
-[dev-doc]: https://github.com/angular/angular/blob/master/DEVELOPER.md
+[dev-doc]: https://github.com/angular/angular-cli#development-hints-for-working-on-angular-cli
 [GitHub]: https://github.com/angular/angular-cli
 [gitter]: https://gitter.im/angular/angular-cli
 [individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html
 [js-style-guide]: https://google.github.io/styleguide/jsguide.html
-[jsfiddle]: http://jsfiddle.net/
-[plunker]: http://plnkr.co/edit
-[runnable]: http://runnable.com/
 [stackoverflow]: http://stackoverflow.com/questions/tagged/angular-cli

README.md

@@ -12,8 +12,7 @@ CLI for Angular applications based on the [ember-cli](http://www.ember-cli.com/)
 ## Note
 
 The CLI is now in 1.0.
-If you are updating from a beta or RC version, check out our [1.0 Update Guide]
-(https://github.com/angular/angular-cli/wiki/stories-1.0-update).
+If you are updating from a beta or RC version, check out our [1.0 Update Guide](https://github.com/angular/angular-cli/wiki/stories-1.0-update).
 
 If you wish to collaborate, check out [our issue list](https://github.com/angular/angular-cli/issues).
 
@@ -31,7 +30,7 @@ with NPM 3 or higher.
 * [Generating a New Project](#generating-and-serving-an-angular-project-via-a-development-server)
 * [Generating Components, Directives, Pipes and Services](#generating-components-directives-pipes-and-services)
 * [Updating Angular CLI](#updating-angular-cli)
-* [Development Hints for hacking on Angular CLI](#development-hints-for-hacking-on-angular-cli)
+* [Development Hints for working on Angular CLI](#development-hints-for-working-on-angular-cli)
 * [Documentation](#documentation)
 * [License](#license)
 
@@ -83,15 +82,16 @@ You can find all possible blueprints in the table below:
 
 Scaffold  | Usage
 ---       | ---
-Component | `ng g component my-new-component`
-Directive | `ng g directive my-new-directive`
-Pipe      | `ng g pipe my-new-pipe`
-Service   | `ng g service my-new-service`
-Class     | `ng g class my-new-class`
-Guard     | `ng g guard my-new-guard`
-Interface | `ng g interface my-new-interface`
-Enum      | `ng g enum my-new-enum`
-Module    | `ng g module my-module`
+[Component](https://github.com/angular/angular-cli/wiki/generate-component) | `ng g component my-new-component`
+[Directive](https://github.com/angular/angular-cli/wiki/generate-directive) | `ng g directive my-new-directive`
+[Pipe](https://github.com/angular/angular-cli/wiki/generate-pipe)           | `ng g pipe my-new-pipe`
+[Service](https://github.com/angular/angular-cli/wiki/generate-service)     | `ng g service my-new-service`
+[Class](https://github.com/angular/angular-cli/wiki/generate-class)         | `ng g class my-new-class`
+[Guard](https://github.com/angular/angular-cli/wiki/generate-guard)         | `ng g guard my-new-guard`
+[Interface](https://github.com/angular/angular-cli/wiki/generate-interface) | `ng g interface my-new-interface`
+[Enum](https://github.com/angular/angular-cli/wiki/generate-enum)           | `ng g enum my-new-enum`
+[Module](https://github.com/angular/angular-cli/wiki/generate-module)       | `ng g module my-module`
+
 
 ### Updating Angular CLI
 
@@ -120,7 +120,7 @@ npm install
 You can find more details about changes between versions in [CHANGELOG.md](https://github.com/angular/angular-cli/blob/master/CHANGELOG.md).
 
 
-## Development Hints for hacking on Angular CLI
+## Development Hints for working on Angular CLI
 
 ### Working with master
 
@@ -132,6 +132,9 @@ npm link
 
 `npm link` is very similar to `npm install -g` except that instead of downloading the package
 from the repo, the just cloned `angular-cli/` folder becomes the global package.
+Additionally, this repository publishes several packages and we use special logic to load all of them
+on development setups.
+
 Any changes to the files in the `angular-cli/` folder will immediately affect the global `@angular/cli` package,
 allowing you to quickly test any changes you make to the cli project.
 
@@ -155,6 +158,12 @@ You can also use `ng new foo --link-cli` to automatically link the `@angular/cli
 Please read the official [npm-link documentation](https://www.npmjs.org/doc/cli/npm-link.html)
 and the [npm-link cheatsheet](http://browsenpm.org/help#linkinganynpmpackagelocally) for more information.
 
+To run the Angular CLI test suite use the `node tests/run_e2e.js` command.
+It can also receive a filename to only run that test (e.g. `node tests/run_e2e.js tests/e2e/tests/build/dev-build.ts`).
+
+As part of the test procedure, all packages will be built and linked.
+You will need to re-run `npm link` to re-link the development Angular CLI environment after tests finish.
+
 
 ## Documentation
 

docs/documentation/generate/component.md

@@ -72,7 +72,7 @@
     `--module` (alias: `-m`)
   </p>
   <p>
-    Allows specification of the declaring module.
+    Allows specification of the declaring module's file name (e.g `app.module.ts`).
   </p>
 </details>
 

docs/documentation/new.md

@@ -48,16 +48,6 @@ Default applications are created in a directory of the same name, with an initia
   </p>
 </details>
 
-<details>
-  <summary>ng4</summary>
-  <p>
-    `--ng4` _default value: false_
-  </p>
-  <p>
-    Create a project with Angular 4 in the template.
-  </p>
-</details>
-
 <details>
   <summary>prefix</summary>
   <p>

docs/documentation/stories.md

@@ -2,7 +2,7 @@
 
 # Stories describing how to do more with the CLI
 
- - [RC Update](stories/rc-update)
+ - [1.0 Update](stories/1.0-update)
  - [Asset Configuration](stories/asset-configuration)
  - [Autocompletion](stories/autocompletion)
  - [CSS Preprocessors](stories/css-preprocessors)
@@ -22,3 +22,4 @@
  - [Corporate Proxy](stories/using-corporate-proxy)
  - [Internationalization (i18n)](stories/internationalization)
  - [Serve from Disk](stories/disk-serve)
+ - [Code Coverage](stories/code-coverage)

docs/documentation/stories/1.0-update.md

@@ -1,4 +1,4 @@
-# Angular CLI RC migration guide
+# Angular CLI migration guide
 
 In this migration guide we'll be looking at some of the major changes to CLI projects in the
 last two months.
@@ -8,18 +8,12 @@ Most of these changes were not breaking changes and your project should work fin
 But if you've been waiting for the perfect time to update, this is it!
 Along with major rebuild speed increases, we've been busy adding a lot of features.
 
-RC means release candidate and we intend to stick to it.
-Unless there is a major breaking bug, we will not change the public surface of the API and
-its generated projects.
-
-This means that a project upgraded now should need no more code changes all the way to 1.0.
-
 Documentation has also completely moved to [the wiki](https://github.com/angular/angular-cli/wiki).
 The new [Stories](https://github.com/angular/angular-cli/wiki/stories) section covers common usage
 scenarios, so be sure to have a look!
 
 Below are the changes between a project generated two months ago, with `1.0.0-beta.24` and
-a `1.0.0-rc.1` project.
+a `1.0.0` project.
 If you kept your project up to date you might have a lot of these already.
 
 You can find more details about changes between versions in [CHANGELOG.md](https://github.com/angular/angular-cli/blob/master/CHANGELOG.md).
@@ -302,7 +296,7 @@ Then update `protractor.conf.js` to use the e2e config as well:
 ```
 beforeLaunch: function() {
   require('ts-node').register({
-    project: 'e2e'
+    project: 'e2e/tsconfig.e2e.json'
   });
 },
 ```
@@ -450,7 +444,7 @@ Update `beforeLaunch` as described in [One tsconfig per app](#one-tsconfig-per-a
 ```
 beforeLaunch: function() {
   require('ts-node').register({
-    project: 'e2e'
+    project: 'e2e/tsconfig.e2e.json'
   });
 },
 ```

docs/documentation/stories/code-coverage.md

@@ -0,0 +1,32 @@
+# Code Coverage
+
+With the Angular CLI we can run unit tests as well as create code coverage reports. Code coverage reports allow us to see any parts of our code base that may not be properly tested by our unit tests.
+
+To generate a coverage report run the following command in the root of your project
+
+```bash
+ng test --watch=false --code-coverage
+```
+
+Once the tests complete a new `/coverage` folder will appear in the project. In your Finder or Windows Explorer open the `index.html` file. You should see a report with your source code and code coverage values. 
+
+Using the code coverage percentages we can estimate how much of our code is tested. It is up to your team to determine how much code should be unit tested. 
+
+## Code Coverage Enforcement
+
+If your team decides on a set minimum amount to be unit tested you can enforce this minimum with the Angular CLI. For example our team would like the code base to have a minimum of 80% code coverage. To enable this open the `karma.conf.js` and add the following in the `coverageIstanbulReporter:` key
+
+```javascript
+coverageIstanbulReporter: {
+  reports: [ 'html', 'lcovonly' ],
+  fixWebpackSourcePaths: true,
+  thresholds: {
+    statements: 80,
+    lines: 80,
+    branches: 80,
+    functions: 80
+  }
+}
+``` 
+
+The `thresholds` property will enforce a minimum of 80% code coverage when the unit tests are run in the project.

docs/documentation/stories/internationalization.md

@@ -13,7 +13,7 @@ When your app is ready, you can extract the strings to translate from your templ
 `ng xi18n` command.
 
 By default it will create a file named `messages.xlf` in your `src` folder.
-You can use [parameters from the xi18n command](../xi18n) to change the format,
+You can use [parameters from the xi18n command](./xi18n) to change the format,
 the name, the location and the source locale of the extracted file.
 
 For example to create a file in the `src/locale` folder you would use:
@@ -69,4 +69,4 @@ ng build --aot --output-path dist/fr --base-href fr --locale fr --i18n-format xl
 If you need more details about how to create scripts to generate the app in multiple
 languages and how to setup Apache 2 to serve them from different subdirectories,
 you can read [this great tutorial](https://medium.com/@feloy/deploying-an-i18n-angular-app-with-angular-cli-fc788f17e358#.1xq4iy6fp)
-by Philippe Martin.
+by Philippe Martin.