cn0577_adaq2387x: Add testbench #241

StancaPop · 2025-08-05T16:06:54Z

PR Description

Add testbench support for cn0577 & adaq2387x.

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
New test (change that adds new test program and/or testbench)
Breaking change (has dependencies in other repositories/testbenches)
Documentation (change that adds or modifies documentation)

PR Checklist

I have followed the code style guidelines
I have performed a self-review of changes
I have ran all testbenches affected by this PR
I have commented my code, at least hard-to-understand parts
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
I have not introduced new Warnings/Errors on compilation/elaboration/simulation
I have set the verbosity level to none for the test program

StancaPop · 2025-08-06T12:57:18Z

To be tested with analogdevicesinc/hdl#1870

testbenches/project/cn0577/tests/test_program.sv

StancaPop · 2025-09-11T13:43:44Z

To be used with the HDL main branch.

testbenches/project/cn0577_adaq2387x/system_bd.tcl

testbenches/project/cn0577/system_tb.sv

testbenches/project/cn0577/cn0577_environment.sv

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

StancaPop · 2025-09-17T13:13:54Z

Converting the testbench to draft since the cn0577 HDL reference design will be updated here: analogdevicesinc/hdl#1919

This will cause the testbench to fail because of the following modification:

ADC_RES parameter has been removed; the cn0577 design will support only the LTC2387-18 variant

Solution:

This testbench can be renamed and repurposed for the adaq2387x family, that was separated from the cn0577 (both being built around axi_ltc2387) and supports both resolutions. The HDL project is still under development.

StancaPop · 2025-10-29T10:11:09Z

CRITICAL WARNING: [BD 41-759] The input pins (listed below) are either not connected or do not have a source port, and they don't have a tie-off specified. These pins are tied-off to all 0's to avoid error in Implementation flow. Please check your design and connect them as needed: /axi_ltc2387/delay_clk Related: WARNING: [BD 41-597] NET <sys_200m_clk> has no source

Resolved in 176ab82
Disconnected the delay_clk from sys_200m_clk and connected it to sys_dma_clk.

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

Signed-off-by: Stanca Pop <[email protected]>

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

testbenches/project/cn0577_adaq2387x/system_bd.tcl

testbenches/project/cn0577_adaq2387x/system_tb.sv

Signed-off-by: Stanca Pop <[email protected]>

IstvanZsSzekely · 2025-11-25T13:28:44Z

testbenches/project/cn0577_adaq2387x/system_bd.tcl

+delete_bd_objs [get_bd_nets sys_200m_clk]
+
+ad_disconnect  sys_200m_clk  axi_ltc2387/delay_clk


Build fails in this current state, the sys_200m_clk net cannot be disconnected since it has been deleted prior.

IstvanZsSzekely · 2025-11-25T14:22:40Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

Please specify the variable names on function calls, similar to method instantiations when connecting the signals.
.<variable>(<value/variable>)

IstvanZsSzekely

Indentation related change request.

IstvanZsSzekely · 2025-11-25T14:27:04Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

+  transfer_cnt = 0;
+  forever begin
+    @(posedge cnv);
+     if (transfer_status) begin


Fix indentation.

IstvanZsSzekely · 2025-11-25T14:27:23Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

+    dco_p <= #(DCO_DELAY * 1ns) dco_init;
+    dco_n <= #(DCO_DELAY * 1ns) ~dco_init;


Fix indentation

IstvanZsSzekely · 2025-11-25T14:27:29Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

+    dco_p <= #(DCO_DELAY * 1ns) dco_init;
+    dco_n <= #(DCO_DELAY * 1ns) ~dco_init;


Indentation

IstvanZsSzekely · 2025-11-25T14:27:52Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

+    //ltc2387_common_api.sanity_test();
+    dmac_api_inst.sanity_test();
+    pwm_gen_api_inst.sanity_test();
+    `INFO(("Sanity Tests Done"), ADI_VERBOSITY_LOW);


Indentation

IstvanZsSzekely · 2025-11-25T14:28:07Z

testbenches/project/cn0577_adaq2387x/tests/test_program.sv

+bit [31:0] config_wr_SIMPLE = 'h0; // write request sent result
+bit [31:0] config_SIMPLE = 'h0; // channel static data setup
+
+task data_acquisition_test();


Indentation

Signed-off-by: Stanca Pop <[email protected]>

StancaPop requested a review from a team as a code owner August 5, 2025 16:06

StancaPop added the new New testbench label Aug 5, 2025

StancaPop marked this pull request as draft August 5, 2025 16:08

StancaPop marked this pull request as ready for review August 6, 2025 12:57

StancaPop mentioned this pull request Aug 8, 2025

docs: Add cn0577 project-based documentation #242

Open

13 tasks

StancaPop force-pushed the add_cn0577_tb_s branch 2 times, most recently from 8138e90 to 8979778 Compare August 12, 2025 12:34

caosjr reviewed Sep 4, 2025

View reviewed changes

testbenches/project/cn0577/tests/test_program.sv Outdated Show resolved Hide resolved

caosjr reviewed Sep 4, 2025

View reviewed changes

testbenches/project/cn0577/tests/test_program.sv Outdated Show resolved Hide resolved

caosjr reviewed Sep 4, 2025

View reviewed changes

testbenches/project/cn0577/tests/test_program.sv Outdated Show resolved Hide resolved

StancaPop force-pushed the add_cn0577_tb_s branch from 8979778 to d7b9d72 Compare September 9, 2025 09:09

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 57bbbde #241 (synchronize)

8e943e6

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 564bff7 #241 (synchronize)

f67e1f5

StancaPop force-pushed the add_cn0577_tb_s branch from a72fa8b to 4bad4c0 Compare September 9, 2025 10:13

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 6ddb590 #241 (synchronize)

a601a11

StancaPop force-pushed the add_cn0577_tb_s branch from 4bad4c0 to e8aaf6e Compare September 9, 2025 11:29

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: ae0587e #241 (synchronize)

e5fa314

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 061c17d #241 (synchronize)

57f5901

StancaPop force-pushed the add_cn0577_tb_s branch from af9bb89 to 3041862 Compare September 9, 2025 11:45

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 958f2e4 #241 (synchronize)

2fc5187

StancaPop force-pushed the add_cn0577_tb_s branch from 3041862 to c5eca49 Compare September 9, 2025 14:04

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: 3a67a02 #241 (synchronize)

0375aa2

github-actions bot added a commit that referenced this pull request Sep 9, 2025

deploy: b87434d #241 (synchronize)

956ba7c

StancaPop requested review from IstvanZsSzekely and caosjr September 11, 2025 13:43

IstvanZsSzekely requested changes Sep 12, 2025

View reviewed changes

github-actions bot added a commit that referenced this pull request Sep 17, 2025

deploy: c6a9b3c #241 (synchronize)

3af4f41

github-actions bot added a commit that referenced this pull request Oct 29, 2025

deploy: 3fb651c #241 (synchronize)

7c42db8

IstvanZsSzekely requested changes Nov 3, 2025

View reviewed changes

testbenches/project/cn0577_adaq2387x/tests/test_program.sv Show resolved Hide resolved

testbenches/project/cn0577_adaq2387x/tests/test_program.sv Outdated Show resolved Hide resolved

testbenches/project/cn0577_adaq2387x/tests/test_program.sv Outdated Show resolved Hide resolved

github-actions bot added a commit that referenced this pull request Nov 3, 2025

deploy: 12a7988 #241 (synchronize)

a21447a

github-actions bot added a commit that referenced this pull request Nov 6, 2025

deploy: bd77c7b #241 (synchronize)

25c70b6

github-actions bot added a commit that referenced this pull request Nov 6, 2025

deploy: 19d0ce6 #241 (synchronize)

4c28e27

github-actions bot added a commit that referenced this pull request Nov 6, 2025

deploy: 996f985 #241 (synchronize)

9a115db

github-actions bot added a commit that referenced this pull request Nov 6, 2025

deploy: ffefeab #241 (synchronize)

b772558

github-actions bot added a commit that referenced this pull request Nov 19, 2025

deploy: eaf6a52 #241 (synchronize)

1a91784

StancaPop added 3 commits November 20, 2025 09:56

cn0577_adaq2387x: PR changes

d4f683d

Signed-off-by: Stanca Pop <[email protected]>

cn0577_adaq2387x: Generate ref_clk using VIP, update dco generation

0db5236

Signed-off-by: Stanca Pop <[email protected]>

cn0577: Fix cn0577 test program

621d181

Signed-off-by: Stanca Pop <[email protected]>

StancaPop force-pushed the add_cn0577_tb_s branch from a5b8a38 to 621d181 Compare November 20, 2025 07:57

github-actions bot added a commit that referenced this pull request Nov 20, 2025

deploy: 6417433 #241 (synchronize)

e8ef055

StancaPop requested a review from IstvanZsSzekely November 24, 2025 11:58

IstvanZsSzekely requested changes Nov 24, 2025

View reviewed changes

cn0577: PR changes - cleanup

263be7e

Signed-off-by: Stanca Pop <[email protected]>

github-actions bot added a commit that referenced this pull request Nov 24, 2025

deploy: 662325d #241 (synchronize)

0cef8a3

StancaPop requested a review from IstvanZsSzekely November 24, 2025 13:53

cn0577_adaq2387x: Randomize data, fix indentation

b95b0ae

Signed-off-by: Stanca Pop <[email protected]>

github-actions bot added a commit that referenced this pull request Nov 25, 2025

deploy: bdb6352 #241 (synchronize)

eca81de

cn0577_adaq2387x: Specify delay units

a71cff6

Signed-off-by: Stanca Pop <[email protected]>

github-actions bot added a commit that referenced this pull request Nov 25, 2025

deploy: 484b692 #241 (synchronize)

f745d81

IstvanZsSzekely requested changes Nov 25, 2025

View reviewed changes

cn0577_adaq2387x: Fix PR changes req

62a74ef

Signed-off-by: Stanca Pop <[email protected]>

github-actions bot added a commit that referenced this pull request Nov 25, 2025

deploy: 7b2325b #241 (synchronize)

0c70fd0

cn0577_adaq2387x: Add param names and values

7e3b39d

Signed-off-by: Stanca Pop <[email protected]>

github-actions bot added a commit that referenced this pull request Nov 25, 2025

deploy: 8cd1c4b #241 (synchronize)

9d2f566

		delete_bd_objs [get_bd_nets sys_200m_clk]

		ad_disconnect sys_200m_clk axi_ltc2387/delay_clk

		dco_p <= #(DCO_DELAY * 1ns) dco_init;
		dco_n <= #(DCO_DELAY * 1ns) ~dco_init;

cn0577_adaq2387x: Add testbench #241

Are you sure you want to change the base?

cn0577_adaq2387x: Add testbench #241

Uh oh!

Conversation

StancaPop commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

PR Type

PR Checklist

Uh oh!

StancaPop commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StancaPop commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StancaPop commented Sep 17, 2025

Uh oh!

StancaPop commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely left a comment

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

IstvanZsSzekely Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

StancaPop commented Aug 5, 2025 •

edited

Loading