Allow Signals to be privately named using name=""
#1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
=======================================
Coverage 89.86% 89.87%
=======================================
Files 43 43
Lines 9977 9992 +15
Branches 2409 2417 +8
=======================================
+ Hits 8966 8980 +14
Misses 817 817
- Partials 194 195 +1 ☔ View full report in Codecov by Sentry. |
wanda-phi
reviewed
Mar 23, 2024
wanda-phi
reviewed
Mar 23, 2024
whitequark
reviewed
Mar 24, 2024
whitequark
reviewed
Mar 24, 2024
whitequark
reviewed
Mar 24, 2024
* Given a private name `$\d+` in RTLIL (as they are not named in the IR) * Not automatically added to VCD files (as they are not named in the IR) * Cannot be traced to a VCD (as they have no name to put in the file) * Cannot be used with an unnamed top-level port (as there is no name)
tpwrules
changed the title
name=""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1223
Tested a couple toy designs. The inclusion of FSM names being private should be enough to prevent regressions.
This does remove a bit of diagnostic power from the FSM tests.