removed tslintuse eslint onlyadd FB eslint override fix facebook/create-react-app#7510

Author: gottfired

packages/react-scripts/config/webpack.config.js

@@ -328,30 +328,6 @@ module.exports = function(webpackEnv) {
 
         // First, run the linter.
         // It's important to do this before Babel processes the JS.
-        // {
-        //   test: /\.(js|mjs|jsx)$/,
-        //   enforce: 'pre',
-        //   use: [
-        //     {
-        //       options: {
-        //         formatter: require.resolve('react-dev-utils/eslintFormatter'),
-        //         eslintPath: require.resolve('eslint'),
-        //         // @remove-on-eject-begin
-        //         baseConfig: {
-        //           extends: [require.resolve('eslint-config-react-app')],
-        //         },
-        //         ignore: false,
-        //         useEslintrc: false,
-        //         // @remove-on-eject-end
-        //       },
-        //       loader: require.resolve('eslint-loader'),
-        //     },
-        //   ],
-        //   include: paths.appSrc,
-        // },
-        // AAA:
-        // we don't need the eslint linter for normal js file, but the typescript linter!
-        // potentially disable when https://github.com/facebook/create-react-app/issues/5641 gets merged!
         {
           test: /\.(js|mjs|jsx|ts|tsx)$/,
           enforce: 'pre',
@@ -371,14 +347,8 @@ module.exports = function(webpackEnv) {
                     // A config couldn't be found.
                   }
 
-                  // We allow overriding the config, only if it extends our config
-                  // (`extends` can be a string or array of strings).
-                  if (
-                    process.env.EXTEND_ESLINT &&
-                    eslintConfig &&
-                    eslintConfig.extends &&
-                    eslintConfig.extends.includes('react-app')
-                  ) {
+                  // We allow overriding the config only if the env variable is set
+                  if (process.env.EXTEND_ESLINT && eslintConfig) {
                     return eslintConfig;
                   } else {
                     return {

packages/react-scripts/scripts/init.js

@@ -102,8 +102,8 @@ module.exports = function(
 
   // Setup the script rules
   appPackage.scripts = {
-    start: 'aaa-react-scripts-ts start',
-    build: 'aaa-react-scripts-ts build',
+    start: 'EXTEND_ESLINT=true aaa-react-scripts-ts start',
+    build: 'EXTEND_ESLINT=true aaa-react-scripts-ts build',
     test: 'aaa-react-scripts-ts test --env=jsdom',
     eject: 'aaa-react-scripts-ts eject',
     apollo: 'apollo',

packages/react-scripts/template-typescript/.eslintrc

@@ -3,11 +3,6 @@
         "plugin:@typescript-eslint/recommended",
         "react-app"
     ],
-    "plugins": [
-        "@typescript-eslint",
-        "@typescript-eslint/tslint"
-    ],
-    "parser": "@typescript-eslint/parser",
     "parserOptions": {
         "project": "./tsconfig.json"
     },
@@ -20,12 +15,6 @@
         "@typescript-eslint/no-var-requires": "off",
         "@typescript-eslint/explicit-function-return-type": "off",
         "@typescript-eslint/no-explicit-any": "off",
-        "@typescript-eslint/no-unused-vars": "off",
-        "@typescript-eslint/tslint/config": [
-            "warn",
-            {
-                "lintFile": "./tslint.json"
-            }
-        ]
+        "@typescript-eslint/no-unused-vars": "off"
     }
 }

packages/react-scripts/template-typescript/.template.dependencies.json

@@ -30,12 +30,6 @@
         "@types/react-router": "^5.0.3",
         "@types/react-router-dom": "^4.3.1",
         "@types/webpack-env": "1.14.0",
-        "@typescript-eslint/eslint-plugin": "^1.3.0",
-        "@typescript-eslint/eslint-plugin-tslint": "^1.3.0",
-        "@typescript-eslint/parser": "^1.3.0",
-        "tslint": "^5.12.1",
-        "tslint-microsoft-contrib": "^6.0.0",
-        "tslint-react": "^4.0.0",
         "typescript": "^3.3.3"
     },
     "resolutions": {