Skip to content

Commit acdccad

Browse files
committed
Revert "Merge branch 'aleph-im-ok' into master"
This reverts commit a399d98, reversing changes made to 5b514f8.
1 parent d77c89f commit acdccad

16 files changed

+25
-437
lines changed

pytest.ini

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/aleph_client/__main__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -464,12 +464,6 @@ def amend(
464464
fd.seek(0)
465465
new_content_json = fd.read()
466466

467-
content_type = type(existing_message).__annotations__["content"]
468-
new_content_dict = json.loads(new_content_json)
469-
new_content = content_type(**new_content_dict)
470-
new_content.ref = existing_message.item_hash
471-
new_message = fd.read()
472-
473467
content_type = type(existing_message).__annotations__["content"]
474468
new_content_dict = json.loads(new_content_json)
475469
new_content = content_type(**new_content_dict)

src/aleph_client/asynchronous.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
from datetime import datetime
1111
from functools import lru_cache
1212
from typing import Type
13-
from types import NoneType
1413

1514
from aleph_message.models import (
1615
ForgetContent,
@@ -388,7 +387,7 @@ async def create_program(
388387
async def forget(
389388
account: Account,
390389
hashes: List[str],
391-
reason: Optional[str]=None,
390+
reason: Optional[str],
392391
storage_engine: StorageEnum = StorageEnum.storage,
393392
channel: str = settings.DEFAULT_CHANNEL,
394393
address: Optional[str] = settings.ADDRESS_TO_USE,
@@ -423,10 +422,9 @@ async def submit(
423422
channel: str = settings.DEFAULT_CHANNEL,
424423
api_server: str = settings.API_HOST,
425424
storage_engine: StorageEnum = StorageEnum.storage,
426-
session: Optional[ClientSession]=None,
425+
session: Optional[ClientSession] = None,
427426
inline: bool = True,
428427
) -> AlephMessage:
429-
430428
message: Dict[str, Any] = {
431429
#'item_hash': ipfs_hash,
432430
"chain": account.CHAIN,
@@ -435,10 +433,8 @@ async def submit(
435433
"type": message_type,
436434
"time": time.time(),
437435
}
438-
439-
item_content: str = json.dumps(content, separators=(",", ":"))
440-
441436

437+
item_content: str = json.dumps(content, separators=(",", ":"))
442438

443439
if inline and (len(item_content) < 50000):
444440
message["item_content"] = item_content
@@ -480,10 +476,9 @@ async def fetch_aggregate(
480476
params["limit"] = limit
481477

482478
async with session.get(
483-
f"{api_server}/api/v0/aggregates/{address}.json",
484-
params=params
479+
f"{api_server}/api/v0/aggregates/{address}.json", params=params
485480
) as resp:
486-
result = await resp.json(encoding="utf-8", content_type="application/json" )
481+
result = await resp.json()
487482
data = result.get("data", dict())
488483
return data.get(key)
489484

src/aleph_client/chains/cosmos.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
DEFAULT_HRP = "cosmos"
1515

16+
1617
def get_signable_message(message):
1718
signable = get_verification_buffer(message).decode("utf-8")
1819
content_message = {
@@ -58,7 +59,7 @@ async def sign_message(self, message):
5859

5960
privkey = ecdsa.SigningKey.from_string(self.private_key, curve=ecdsa.SECP256k1)
6061
signature_compact = privkey.sign_deterministic(
61-
verif.encode("ISO-8859-1"),
62+
verif.encode("utf-8"),
6263
hashfunc=hashlib.sha256,
6364
sigencode=ecdsa.util.sigencode_string_canonize,
6465
)
@@ -79,8 +80,7 @@ def get_address(self) -> str:
7980

8081
def get_public_key(self) -> str:
8182
return privkey_to_pubkey(self.private_key).decode()
82-
return privkey_to_pubkey(self.private_key).decode("ISO-8859-1")
8383

8484

8585
def get_fallback_account(hrp=DEFAULT_HRP):
86-
return CSDKAccount(private_key=get_fallback_private_key(), hrp=hrp)
86+
return CSDKAccount(private_key=get_fallback_private_key(), hrp=hrp)

src/aleph_client/chains/substrate.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import json
2-
from base64 import b64encode
2+
33
from substrateinterface import Keypair
44

55
from .common import (
@@ -13,16 +13,17 @@ class DOTAccount(BaseAccount):
1313
CHAIN = "DOT"
1414
CURVE = "sr25519"
1515

16-
def __init__(self, mnemonics=None):
16+
def __init__(self, mnemonics=None, address_type=42):
1717
self.mnemonics = mnemonics
18+
self.address_type = address_type
1819
self._account = Keypair.create_from_mnemonic(
19-
self.mnemonics)
20+
self.mnemonics, address_type=address_type
21+
)
2022

2123
async def sign_message(self, message):
2224
message = self._setup_sender(message)
2325
verif = get_verification_buffer(message).decode("utf-8")
24-
m = b64encode(b'self._account.sign(verif)').decode('utf-8')
25-
sig = {"curve": self.CURVE, "data": m}
26+
sig = {"curve": self.CURVE, "data": self._account.sign(verif)}
2627
message["signature"] = json.dumps(sig)
2728
return message
2829

tests/unit/test_asynchronous.py

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import os
2-
import time
32
from unittest.mock import MagicMock, patch, AsyncMock
43

54
import pytest as pytest
@@ -9,9 +8,6 @@
98
StoreMessage,
109
ProgramMessage,
1110
ForgetMessage,
12-
PostContent,
13-
MessageType,
14-
AlephMessage
1511
)
1612

1713
from aleph_client.conf import settings
@@ -24,24 +20,9 @@
2420
create_store,
2521
create_program,
2622
forget,
27-
submit
2823
)
2924
from aleph_client.chains.common import get_fallback_private_key
3025
from aleph_client.chains.ethereum import ETHAccount
31-
from build.lib.aleph_client.__main__ import post
32-
from build.lib.aleph_client.asynchronous import fetch_aggregates
33-
34-
35-
def new_mock_session_with_post_success():
36-
mock_response = AsyncMock()
37-
mock_response.json.return_value = {"status": "success"}
38-
39-
mock_post = AsyncMock()
40-
mock_post.return_value = mock_response
41-
42-
mock_session = MagicMock()
43-
mock_session.post.return_value.__aenter__ = mock_post
44-
return mock_session
4526

4627

4728
def new_mock_session_with_post_success():
@@ -222,24 +203,3 @@ async def test_forget():
222203

223204
assert mock_session.post.called
224205
assert isinstance(new_post, ForgetMessage)
225-
226-
@pytest.mark.asyncio
227-
async def fetch_aggregate():
228-
229-
_get_fallback_session.cache_clear()
230-
231-
if os.path.exists(settings.PRIVATE_KEY_FILE):
232-
os.remove(settings.PRIVATE_KEY_FILE)
233-
234-
private_key = get_fallback_private_key()
235-
account: ETHAccount = ETHAccount(private_key=private_key)
236-
237-
mock_session = new_mock_session_with_post_success()
238-
239-
address = account.get_address()
240-
241-
response = await fetch_aggregate(
242-
address = address,
243-
key = "0xa1B3bb7d2332383D96b7796B908fB7f7F3c2Be10",
244-
api_server = settings.API_HOST,
245-
)

0 commit comments

Comments
 (0)