Add typing and linting to alembic/

Author: Iain-S

.pre-commit-config.yaml

@@ -43,7 +43,6 @@ repos:
         entry: poetry run pylint --rcfile=.python-lint
         language: system
         types: ['python']
-        exclude: ^alembic/
       - id: flake8
         name: Flake8
         entry: poetry run flake8
@@ -61,7 +60,6 @@ repos:
         language: system
         types: ['python']
         exclude: (?x)(
-            alembic|
             tests|
             scripts
           )

alembic/env.py

@@ -1,5 +1,7 @@
+"""Configuration for Alembic migrations."""
+
 from logging.config import fileConfig
-from typing import Any, Literal, Optional
+from typing import Literal, Optional
 
 from sqlalchemy import engine_from_config, pool
 from sqlalchemy.sql.schema import SchemaItem
@@ -8,6 +10,10 @@
 from rctab.crud.models import metadata
 from rctab.settings import Settings
 
+# pylint: disable=unused-argument
+# pylint: disable=no-member
+# pylint: disable=redefined-builtin
+
 settings = Settings()
 # this is the Alembic Config object, which provides
 # access to the values within the .ini file in use.
@@ -41,10 +47,7 @@ def include_object(
     reflected: bool,
     compare_to: Optional[SchemaItem],
 ) -> bool:
-    """
-    Exclude views from Alembic's consideration.
-    """
-
+    """Exclude views from Alembic's consideration."""
     if object.info:
         if object.info.get("is_view", False):
             return False

alembic/versions/b65796c99771_squash.py

@@ -1,4 +1,4 @@
-"""Squash
+"""Squash (previous migrations).
 
 Revision ID: b65796c99771
 Revises:
@@ -12,6 +12,9 @@
 
 from alembic import op
 
+# pylint: disable=no-member
+# pylint: disable=invalid-name
+
 # revision identifiers, used by Alembic.
 revision = "b65796c99771"
 down_revision = None
@@ -68,6 +71,7 @@ class FinanceHistorySql:
 
 
 def upgrade() -> None:
+    """Upgrade the database."""
     op.execute(text("create schema accounting"))
     op.create_table(
         "user_cache",
@@ -487,6 +491,7 @@ def upgrade() -> None:
 
 
 def downgrade() -> None:
+    """Downgrade the database."""
     op.drop_table("cost_recovery", schema="accounting")
     op.execute(
         "DROP MATERIALIZED VIEW {schema}.usage_view;".format(schema="accounting")

poetry.lock

@@ -6,7 +6,7 @@ authors = []
 
 [tool.poetry.dependencies]
 python = ">=3.10 <3.12"
-alembic = "^1.7.1"
+alembic = "^1.13.2"
 anyio = "^4.4.0"  # only pinned to satisfy safety warning on <=4.3.0
 asyncpg = "^0.27.0"
 azure-identity = "^1.16.0"
@@ -56,7 +56,6 @@ pytest-asyncio = "^0.14.0"
 pytest-cov = "^2.10.1"
 pytest-mock = "^3.6.1"
 safety = "^3.1.0"
-sqlalchemy-stubs = "^0.3"
 types-requests = "^2.32.0.20240602"
 
 [tool.poetry.extras]