From d057b24b3b36cdcf097d422077ee1e12475cf658 Mon Sep 17 00:00:00 2001 From: Aaron Steers Date: Tue, 12 Nov 2024 20:56:42 -0800 Subject: [PATCH 1/4] replace faker with hardcoded source --- .github/workflows/connector-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/connector-tests.yml b/.github/workflows/connector-tests.yml index 77bfe1574..591c2835b 100644 --- a/.github/workflows/connector-tests.yml +++ b/.github/workflows/connector-tests.yml @@ -68,7 +68,7 @@ jobs: fail-fast: false matrix: include: - - connector: source-faker + - connector: source-hardcoded-records cdk_extra: n/a - connector: source-shopify cdk_extra: n/a From fb051b970b6b72bf7af1c70e7c9bddd991b8d587 Mon Sep 17 00:00:00 2001 From: Aaron Steers Date: Tue, 12 Nov 2024 21:12:17 -0800 Subject: [PATCH 2/4] revise error logging --- .github/workflows/connector-tests.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/connector-tests.yml b/.github/workflows/connector-tests.yml index 591c2835b..8a934d147 100644 --- a/.github/workflows/connector-tests.yml +++ b/.github/workflows/connector-tests.yml @@ -141,14 +141,16 @@ jobs: json_output_file=$(find airbyte/airbyte-ci/connectors/pipelines/pipeline_reports -name 'output.json' -print -quit) job_output=$(cat ${json_output_file}) success=$(echo ${job_output} | jq -r '.success') - failed_jobs=$(echo ${job_output} | jq -r '.failed_steps') + failed_step=$(echo ${job_output} | jq -r '.failed_steps | select(length > 0) | .[0] // "None"') run_duration=$(echo ${job_output} | jq -r '.run_duration') echo "## Job Output for ${{matrix.connector}}" >> $GITHUB_STEP_SUMMARY echo "- Success: ${success}" >> $GITHUB_STEP_SUMMARY echo "- Test Duration: $(printf "%.0f" ${run_duration})s" >> $GITHUB_STEP_SUMMARY - echo "- Failed Checks: ${failed_jobs}" >> $GITHUB_STEP_SUMMARY + if [ "${success}" != "true" ]; then + echo "- Failed Step: ${failed_step}" >> $GITHUB_STEP_SUMMARY + fi echo -e "\n[Download Job Output](${{steps.upload_job_output.outputs.artifact-url}})" >> $GITHUB_STEP_SUMMARY if [ "${success}" != "true" ]; then - # Throw failure if tests failed + echo "::error::Test failed for connector '${{ matrix.connector }}' on step '${failed_step}'. Check the logs for more details." exit 1 fi From 3a9d35c6b93a7de7e6e11d5defb0fa6057b9bb21 Mon Sep 17 00:00:00 2001 From: Aaron Steers Date: Tue, 12 Nov 2024 21:14:49 -0800 Subject: [PATCH 3/4] retest failure --- .github/workflows/connector-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/connector-tests.yml b/.github/workflows/connector-tests.yml index 8a934d147..ea38e7571 100644 --- a/.github/workflows/connector-tests.yml +++ b/.github/workflows/connector-tests.yml @@ -70,6 +70,8 @@ jobs: include: - connector: source-hardcoded-records cdk_extra: n/a + - connector: source-faker + cdk_extra: n/a - connector: source-shopify cdk_extra: n/a # Currently not passing CI (unrelated) From 90d2973d102f99861fb301f4c5fecdac5def1b69 Mon Sep 17 00:00:00 2001 From: Aaron Steers Date: Tue, 12 Nov 2024 21:27:06 -0800 Subject: [PATCH 4/4] remove faker --- .github/workflows/connector-tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/connector-tests.yml b/.github/workflows/connector-tests.yml index ea38e7571..8a934d147 100644 --- a/.github/workflows/connector-tests.yml +++ b/.github/workflows/connector-tests.yml @@ -70,8 +70,6 @@ jobs: include: - connector: source-hardcoded-records cdk_extra: n/a - - connector: source-faker - cdk_extra: n/a - connector: source-shopify cdk_extra: n/a # Currently not passing CI (unrelated)