fix typing and add tests

Author: maxi297

airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py

@@ -40,7 +40,7 @@ def __post_init__(self, parameters: Mapping[str, Any]) -> None:
         )
 
     def get_request_property_chunks(
-        self, property_fields: Iterable[str], always_include_properties: Optional[List[str]]
+        self, property_fields: List[str], always_include_properties: Optional[List[str]]
     ) -> Iterable[List[str]]:
         if not self.property_limit:
             single_property_chunk = list(property_fields)

airbyte_cdk/sources/declarative/requesters/query_properties/query_properties.py

@@ -34,7 +34,7 @@ def get_request_property_chunks(
         :param stream_slice: The StreamSlice of the current partition being processed during the sync. This is included
         because subcomponents of QueryProperties can make use of interpolation of the top-level StreamSlice object
         """
-        fields: Union[Iterable[str], List[str]]
+        fields: List[str]
         if isinstance(self.property_list, PropertiesFromEndpoint):
             fields = self.property_list.get_properties_from_endpoint(stream_slice=stream_slice)
         else:

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py

@@ -72,7 +72,6 @@ def test_get_request_property_chunks(
     property_limit,
     expected_property_chunks,
 ):
-    property_fields = iter(property_fields)
     property_chunking = PropertyChunking(
         property_limit_type=property_limit_type,
         property_limit=property_limit,
@@ -104,3 +103,26 @@ def test_get_merge_key():
 
     merge_key = property_chunking.get_merge_key(record=record)
     assert merge_key == "0"
+
+
+def test_given_single_property_chunk_when_get_request_property_chunks_then_always_include_properties_are_not_added_to_input_list():
+    """
+    This test is used to validate that we don't manipulate the in-memory values from get_request_property_chunks
+    """
+    property_chunking = PropertyChunking(
+        property_limit_type=PropertyLimitType.property_count,
+        property_limit=None,
+        record_merge_strategy=GroupByKey(key="id", config=CONFIG, parameters={}),
+        config=CONFIG,
+        parameters={},
+    )
+
+    property_fields = ["rick", "chelsea", "victoria", "tim", "saxon", "lochlan", "piper"]
+    list(
+        property_chunking.get_request_property_chunks(
+            property_fields=property_fields,
+            always_include_properties=["id"],
+        )
+    )
+
+    assert property_fields == ["rick", "chelsea", "victoria", "tim", "saxon", "lochlan", "piper"]