Skip to content

Commit 57cbdd9

Browse files
committed
self code review
1 parent 06b69f4 commit 57cbdd9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3218,6 +3218,9 @@ def _get_url(req: Requester) -> str:
32183218
model=query_properties_definitions[0], config=config
32193219
)
32203220

3221+
# Removes QueryProperties components from the interpolated mappings because it has been designed
3222+
# to be used by the SimpleRetriever and will be resolved from the provider from the slice directly
3223+
# instead of through jinja interpolation
32213224
if isinstance(model.requester.request_parameters, Mapping):
32223225
model.requester.request_parameters = self._remove_query_properties(
32233226
model.requester.request_parameters
@@ -3244,9 +3247,6 @@ def _get_url(req: Requester) -> str:
32443247
config=config,
32453248
)
32463249

3247-
# Removes QueryProperties components from the interpolated mappings because it has been designed
3248-
# to be used by the SimpleRetriever and will be resolved from the provider from the slice directly
3249-
# instead of through jinja interpolation
32503250
requester = self._create_component_from_model(
32513251
model=model.requester,
32523252
decoder=decoder,

0 commit comments

Comments
 (0)