From 0dd3dbd7b62061e1ca3d1c5467ed3fbca1e5daf6 Mon Sep 17 00:00:00 2001 From: Siddharth Doshi Date: Sat, 20 May 2017 15:41:37 +0530 Subject: [PATCH] [eslint config] [base] [breaking] Blacklist confusing globals --- packages/eslint-config-airbnb-base/package.json | 3 +++ packages/eslint-config-airbnb-base/rules/variables.js | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json index d604e51ea8..92fa71298c 100644 --- a/packages/eslint-config-airbnb-base/package.json +++ b/packages/eslint-config-airbnb-base/package.json @@ -62,5 +62,8 @@ }, "engines": { "node": ">= 4" + }, + "dependencies": { + "eslint-restricted-globals": "^0.1.1" } } diff --git a/packages/eslint-config-airbnb-base/rules/variables.js b/packages/eslint-config-airbnb-base/rules/variables.js index 3fc5f6ef93..fc0b5b11d4 100644 --- a/packages/eslint-config-airbnb-base/rules/variables.js +++ b/packages/eslint-config-airbnb-base/rules/variables.js @@ -1,3 +1,5 @@ +const restrictedGlobals = require('eslint-restricted-globals'); + module.exports = { rules: { // enforce or disallow variable initializations at definition @@ -14,7 +16,7 @@ module.exports = { 'no-label-var': 'error', // disallow specific globals - 'no-restricted-globals': 'off', + 'no-restricted-globals': ['error'].concat(restrictedGlobals), // disallow declaration of variables already declared in the outer scope 'no-shadow': 'error',