From cd9dfcddc1f0ae3db13453902b56791d1037ca7c Mon Sep 17 00:00:00 2001 From: Hany Hamed Date: Wed, 6 Oct 2021 18:16:13 +0300 Subject: [PATCH 1/3] [Dockerfile] Update opencv installation We had a problem when building the docker image and we had the following error: ```bash gpg: keyring `/tmp/tmpa_k4apov/secring.gpg' created gpg: keyring `/tmp/tmpa_k4apov/pubring.gpg' created gpg: requesting key BF4CAA63 from hkp server keyserver.ubuntu.com gpg: /tmp/tmpa_k4apov/trustdb.gpg: trustdb created gpg: key BF4CAA63: public key "Launchpad pscroll" imported gpg: Total number processed: 1 gpg: imported: 1 (RSA: 1) ``` ```bash E: Unable to correct problems, you have held broken packages. The command '/bin/sh -c apt-get clean && add-apt-repository --yes ppa:xqms/opencv-nonfree && apt-get update && apt-get -y install libopencv-nonfree-dev libopencv-dev' returned a non-zero code: 100 ``` And we found the following [solution](https://askubuntu.com/questions/1137931/unable-to-install-libopencv-nonfree-dev-in-ubuntu-16-04), this solution suggest changing an alternative PPA for the package. --- src/bash/docker/Dockerfile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bash/docker/Dockerfile b/src/bash/docker/Dockerfile index ae885f5..3807c58 100644 --- a/src/bash/docker/Dockerfile +++ b/src/bash/docker/Dockerfile @@ -76,7 +76,8 @@ RUN apt-get clean && apt-get update && apt-get install -y \ libeigen3-dev \ gfortran #OpenCV -RUN apt-get clean && add-apt-repository --yes ppa:xqms/opencv-nonfree \ +RUN apt-get clean && add-apt-repository --remove ppa:xqms/opencv-nonfree \ + && add-apt-repository --yes ppa:jeff250/opencv \ && apt-get update \ && apt-get -y install \ libopencv-nonfree-dev \ From 56027f94c8d64bfcef62354f6f208ba78004fc70 Mon Sep 17 00:00:00 2001 From: Hany Hamed Date: Wed, 6 Oct 2021 18:17:21 +0300 Subject: [PATCH 2/3] [Dockerfile] Add installation for wget We had the following error: ```bash + wget http://coppeliarobotics.com/files/V-REP_PRO_EDU_V3_6_1_Ubuntu16_04.tar.xz /root/robotics_setup/vrep.sh: line 52: wget: command not found The command '/bin/bash -c cd ~/robotics_setup && ~/robotics_setup/vrep.sh' returned a non-zero code: 127 ``` As the robotics_setup package is using wget inside its setup scripts and wget is not installed. Thus, we add installation for wget. --- src/bash/docker/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bash/docker/Dockerfile b/src/bash/docker/Dockerfile index 3807c58..b322dfc 100644 --- a/src/bash/docker/Dockerfile +++ b/src/bash/docker/Dockerfile @@ -59,6 +59,7 @@ RUN apt-get clean && apt-get update && apt-get install -y \ sudo \ unzip \ curl \ + wget \ ctags \ git \ tmux From b99ee6fa72163f22dddc5547a09a461a914889ac Mon Sep 17 00:00:00 2001 From: Hany Hamed Date: Wed, 6 Oct 2021 20:58:44 +0300 Subject: [PATCH 3/3] [Dockerfile] Remove extra installation for git Installation for git is repetitive. --- src/bash/docker/Dockerfile | 1 - 1 file changed, 1 deletion(-) diff --git a/src/bash/docker/Dockerfile b/src/bash/docker/Dockerfile index b322dfc..0565fb3 100644 --- a/src/bash/docker/Dockerfile +++ b/src/bash/docker/Dockerfile @@ -61,7 +61,6 @@ RUN apt-get clean && apt-get update && apt-get install -y \ curl \ wget \ ctags \ - git \ tmux #LLVM RUN apt-get clean && apt-get update && apt-get install -y \