Skip to content

Commit 38c8f6e

Browse files
committed
Ensure EH/longjmp does not change code after link
We used to require Binaryen postprocessing for EH and longjmp and have `fail` requirements for those features in `other.test_immutable_after_link`. I deleted those requirements in emscripten-core#12399, but it could have been better if I didn't just delete them but changed them to `ok` requirements. This PR adds them.
1 parent e179b57 commit 38c8f6e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/test_other.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9009,6 +9009,10 @@ def ok(args, filename='hello_world.cpp', expected='hello, world!'):
90099009
ok(required_flags, filename='hello_world_main_loop.cpp')
90109010
# -O1 is ok as we don't run wasm-opt there (but no higher, see below)
90119011
ok(required_flags + ['-O1'])
9012+
# exception support shouldn't require change after linking
9013+
ok(required_flags + ['-fexceptions'])
9014+
# longjmp support shouldn't require change after linking
9015+
ok(required_flags + ['-sSUPPORT_LONGJMP=1'])
90129016

90139017
# other builds fail with a standard message + extra details
90149018
def fail(args, details):

0 commit comments

Comments
 (0)