From d7d7cb09ae42a6fd6cf383eff2efed33c91081ef Mon Sep 17 00:00:00 2001 From: Mike Storey Date: Tue, 22 Jul 2025 13:35:26 -0400 Subject: [PATCH 1/2] More complete defaults. --- configurator/services/dictionary_services.py | 2 +- tests/services/test_dictionary_service_operations.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configurator/services/dictionary_services.py b/configurator/services/dictionary_services.py index fcdee03..891ea2e 100644 --- a/configurator/services/dictionary_services.py +++ b/configurator/services/dictionary_services.py @@ -137,7 +137,7 @@ def __init__(self, name: str, property: dict): self.enums = property.get("enums", None) self.additional_properties = property.get("additional_properties", False) self.properties = {} - self.items = {} + self.items = {"type": "void"} # Initialize properties if this is an object type if self.type == "object": diff --git a/tests/services/test_dictionary_service_operations.py b/tests/services/test_dictionary_service_operations.py index 45c4b87..59aa79c 100644 --- a/tests/services/test_dictionary_service_operations.py +++ b/tests/services/test_dictionary_service_operations.py @@ -140,7 +140,7 @@ def test_init_with_missing_values(self): self.assertFalse(prop.required) self.assertFalse(prop.additional_properties) self.assertEqual(prop.properties, {}) - self.assertEqual(prop.items, {}) + self.assertEqual(prop.items, {"type": "void"}) def test_to_dict_with_ref(self): """Test to_dict method for ref property""" From 1562b550cdb1fe68c6ec261d2f8320e99235f5c7 Mon Sep 17 00:00:00 2001 From: Mike Storey Date: Tue, 22 Jul 2025 13:46:35 -0400 Subject: [PATCH 2/2] array type properties now initialize correctly if items are missing --- configurator/services/dictionary_services.py | 4 ++-- tests/services/test_dictionary_service_operations.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configurator/services/dictionary_services.py b/configurator/services/dictionary_services.py index 891ea2e..0e41307 100644 --- a/configurator/services/dictionary_services.py +++ b/configurator/services/dictionary_services.py @@ -137,7 +137,7 @@ def __init__(self, name: str, property: dict): self.enums = property.get("enums", None) self.additional_properties = property.get("additional_properties", False) self.properties = {} - self.items = {"type": "void"} + self.items = {} # Initialize properties if this is an object type if self.type == "object": @@ -146,7 +146,7 @@ def __init__(self, name: str, property: dict): # Initialize items if this is an array type if self.type == "array": - items_data = property.get("items", {}) + items_data = property.get("items", {"type": "void"}) if items_data: self.items = Property("items", items_data) diff --git a/tests/services/test_dictionary_service_operations.py b/tests/services/test_dictionary_service_operations.py index 59aa79c..45c4b87 100644 --- a/tests/services/test_dictionary_service_operations.py +++ b/tests/services/test_dictionary_service_operations.py @@ -140,7 +140,7 @@ def test_init_with_missing_values(self): self.assertFalse(prop.required) self.assertFalse(prop.additional_properties) self.assertEqual(prop.properties, {}) - self.assertEqual(prop.items, {"type": "void"}) + self.assertEqual(prop.items, {}) def test_to_dict_with_ref(self): """Test to_dict method for ref property"""