Skip to content

Topics schema has Partner status property #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michquinn opened this issue Jan 13, 2024 · 6 comments
Closed

Topics schema has Partner status property #31

michquinn opened this issue Jan 13, 2024 · 6 comments
Labels
invalid This doesn't seem right

Comments

@michquinn
Copy link
Contributor

michquinn commented Jan 13, 2024

"status": {
"description": "The status of this partnership",
"bsonType": "string",
"enum": ["Pending", "Active", "Drip", "Archived"]

This appears to have been carried over by mistake and should be removed.

@michquinn michquinn added the invalid This doesn't seem right label Jan 13, 2024
@avinashpathy
Copy link

Hi @michquinn,
Can I work on this one?

@FlatBallFlyer
Copy link
Contributor

FlatBallFlyer commented Jan 13, 2024

The status is still a valid attribute, but the values are simply Active and Archived - we must have a soft-delete indicator. Every collection should have a status property with at a minimum Active and Archived values.

@michquinn
Copy link
Contributor Author

Good to know. If that's the case, did you want to leave it as an enum or would you prefer switching it to a boolean, perhaps something like isActive?

@FlatBallFlyer
Copy link
Contributor

Keep it as an enum, there may be additional statuses in the future. Also, see my note on the PR about adding readme content

@michquinn
Copy link
Contributor Author

You have notes to that effect in the README already [1], though it could be more explicit in regards to workflow when making changes. Shall I open another issue?

[1] https://github.com/agile-learning-institute/mentorHub-mongodb#build-and-test-the-container

@FlatBallFlyer
Copy link
Contributor

I think you can use the existing PR to address more than one issue, or to make a minor refactor without an issue. I'd go ahead and knock out the readme updates along side the partner-status schema fix - at least the testing part. If you want to pick off some of the tasks in the existing issue that is a good way to move that change alone into a new issue for the existing PR. If you want to remove the Backlog part of the readme that is a good thing to catch as I"ve moved that content into issues. I would address the larger schema improvement refactor identified in issue 30 as a separate branch/PR

@michquinn michquinn changed the title Topics schema has Person status property Topics schema has Partner status property Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants