-
Notifications
You must be signed in to change notification settings - Fork 3
Topics schema has Partner status property #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @michquinn, |
The status is still a valid attribute, but the values are simply Active and Archived - we must have a soft-delete indicator. Every collection should have a status property with at a minimum Active and Archived values. |
Good to know. If that's the case, did you want to leave it as an |
Keep it as an enum, there may be additional statuses in the future. Also, see my note on the PR about adding readme content |
You have notes to that effect in the README already [1], though it could be more explicit in regards to workflow when making changes. Shall I open another issue? [1] https://github.com/agile-learning-institute/mentorHub-mongodb#build-and-test-the-container |
I think you can use the existing PR to address more than one issue, or to make a minor refactor without an issue. I'd go ahead and knock out the readme updates along side the partner-status schema fix - at least the testing part. If you want to pick off some of the tasks in the existing issue that is a good way to move that change alone into a new issue for the existing PR. If you want to remove the Backlog part of the readme that is a good thing to catch as I"ve moved that content into issues. I would address the larger schema improvement refactor identified in issue 30 as a separate branch/PR |
mentorHub-mongodb/src/mongosh/institute-topics-schema.json
Lines 32 to 35 in 8142a5e
This appears to have been carried over by mistake and should be removed.
The text was updated successfully, but these errors were encountered: