Skip to content

Commit 8849b26

Browse files
committed
Fix send zero bytes stream buffer unit test
The change in FreeRTOS/FreeRTOS-Kernel#264 updated prvWriteMessageToBuffer in a way that it no longer calls prvWriteBytesToBuffer for messages of zero size (prvWriteBytesToBuffer triggers an assert for messages of zero size). As a result, a zero byte send to a stream buffer no longer results in assert failure but instead returns 0. This change updates the zero byte send test to check for 0 return value. Signed-off-by: Gaurav Aggarwal <[email protected]>
1 parent 19271dd commit 8849b26

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

FreeRTOS/Test/CMock/stream_buffer/stream_buffer_utest.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ void test_xStreamBufferSend_more_than_buffer_size( void )
619619
void test_xStreamBufferSend_zero_bytes( void )
620620
{
621621
uint8_t data[ TEST_STREAM_BUFFER_SIZE + 1 ] = { 0 };
622+
size_t bytesWritten;
622623

623624
vTaskSetTimeOutState_Ignore();
624625
vTaskSuspendAll_Ignore();
@@ -629,11 +630,8 @@ void test_xStreamBufferSend_zero_bytes( void )
629630
TEST_ASSERT_NOT_NULL( xStreamBuffer );
630631
TEST_ASSERT_EQUAL( TEST_STREAM_BUFFER_SIZE, xStreamBufferSpacesAvailable( xStreamBuffer ) );
631632

632-
if( TEST_PROTECT() )
633-
{
634-
( void ) xStreamBufferSend( xStreamBuffer, data, 0U, TEST_STREAM_BUFFER_WAIT_TICKS );
635-
}
636-
validate_and_clear_assertions();
633+
bytesWritten = xStreamBufferSend( xStreamBuffer, data, 0U, TEST_STREAM_BUFFER_WAIT_TICKS );
634+
TEST_ASSERT_EQUAL( 0, bytesWritten );
637635

638636
vStreamBufferDelete( xStreamBuffer );
639637
}

0 commit comments

Comments
 (0)