lamejs is not optional

[etschelp]

I'm no JS expert and I might be totally wrong here, but according to the Readme and the projects package.json the dependency to lamejs is marked as optional, so I would expect that when I add vue-advanced-chat as a dependency and then run npm install --no-optional that lamejs is not installed locally.

What happens per default is that lamejs is installed anyway and it is also set to required according to the contents of package-lock.json. If I overwrite this behaviour and explicitly set lamejs to optional in my local package.json like

  "optionalDependencies": {
    "lamejs": "^1.2.0"
  }

lamejs is not installed. When I now run npm serve I see the following in my console:

 ERROR  Failed to compile with 1 error                                                                                                                                                                                                            2:39:36 PM

This dependency was not found:

* lamejs in ./node_modules/vue-advanced-chat/dist/vue-advanced-chat.common.js

To install it, you can run: npm install --save lamejs

In this bundle file I see that one module indeed directly requires lamejs. This might be one issue, and the other issue might be that your package.json defines lamejs twice. The npm documentation says:

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#optionaldependencies

Entries in optionalDependencies will override entries of the same name in dependencies, so it's usually best to only put in one place.

So it might be cleaner to delete the dependency entry.

[antoine92190]

Yes indeed you are right, there is something wrong here.
Feel free to send me a PR so we can fix this ASAP :)

[etschelp]

I believe the webpack config in vue.config.js is the culprit. When declaring a package as external webpack adds wrapper code that checks if lamejs is installed locally. Unfortunately there is no concept to say this package is external to the library and optional for users of the library in webpack. On the other hand shouldn't it be enough to simply declare lamejs as optional in package.json without the need to declare it as external?

It looked ok when i deleted vue.config.json and removed the duplicated lamejs line from the dependency section in package.json

[antoine92190]

Indeed, does this look ok to you ? 4a84979

[antoine92190]

Should be fixed in version 0.9.0
Let me know if you still have any issue.

[etschelp]

Looks good now. Thanks for the quick fix and release.