fix(tooltip): force label wrapping #5878
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rise-erpelding
added
Status: WIP
🦋 Changeset detectedLatest commit: ea779aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 78 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
rise-erpelding
force-pushed
the
swc-1331--wrap-tooltip-text
branch
from
45aefe2 to
043cece
Compare
rise-erpelding
added
bug
rise-erpelding
force-pushed
the
swc-1331--wrap-tooltip-text
branch
from
043cece to
b69aeb5
Compare
rise-erpelding
force-pushed
the
swc-1331--wrap-tooltip-text
branch
from
b69aeb5 to
ea779aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with tooltip text overflow: long, unbroken words were not wrapping and overflowed the container. See screenshots.
Motivation and context
We have
overflow-wrap: break-word;on#tooltip, but needinline-size: 100%on the label to force it to wrap properly in cases of longer text without spaces.#5504 previously updated the CSS to remove the deprecated
word-break: break-wordin favor ofoverflow-wrap: break-word. @5t3ph explains and fixes the issue that this causes in CSS via adobe/spectrum-css#4044. This PR carries that fix over to be applied in SWC.The fix in adobe/spectrum-css#4044 does not require modifications for icons because it addresses the S2 version of tooltip, where icon variants have been removed. Therefore, additional modifications were made here to accommodate the tooltip variants that include icons.
Related issue(s)
Screenshots
Before:
After:
Author's checklist
I have added automated tests to cover my changes.I have included updated documentation if my change required it.Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Check regular tooltip wrapping (no icon)
Check tooltip wrapping with icon
Device review