Skip to content

fix: CardView height in ActionBar #8373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snowystinger merged 2 commits into from
Jun 18, 2025
Merged

fix: CardView height in ActionBar #8373

snowystinger merged 2 commits into from
Jun 18, 2025

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Jun 10, 2025

Closes

Found in testing that the S2 ActionBar Docs for CardView doesn't scroll

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 10, 2025

Build successful! 🎉

reidbarber
reidbarber reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing an error: https://reactspectrum.blob.core.windows.net/reactspectrum/3351d8c5ffac968390ccd120724a903999770cd8/storybook-s2/index.html?path=/story/actionbar--card-example

@rspbot
Copy link

rspbot commented Jun 10, 2025

Build successful! 🎉

@snowystinger
Copy link
Member Author

snowystinger commented Jun 11, 2025

@reidbarber just needed main to be merged in, here it is https://reactspectrum.blob.core.windows.net/reactspectrum/95f751be1b5fc48769bd03fed4f7e230f0f9ba92/storybook-s2/index.html?path=/story/actionbar--card-example

@snowystinger snowystinger added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit c7285d5 Jun 18, 2025
30 checks passed
@snowystinger snowystinger deleted the fix-cardview-height branch June 18, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snowystinger @rspbot @devongovett @reidbarber