Skip to content

Update Picker placeholder to be shorter #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2024
Merged

Update Picker placeholder to be shorter #6796

merged 2 commits into from
Jul 31, 2024

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Jul 30, 2024

Closes #4816

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger added the small review Easy to review PR label Jul 30, 2024
@rspbot
Copy link

rspbot commented Jul 30, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jul 31, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jul 31, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@snowystinger snowystinger merged commit 1dcc870 into main Jul 31, 2024
@snowystinger snowystinger deleted the update-string-for-picker-placeholder branch July 31, 2024 03:06
@yihuiliao yihuiliao mentioned this pull request Jul 31, 2024
Merged
5 tasks
reidbarber pushed a commit that referenced this pull request Aug 21, 2024
@snowystinger @reidbarber
Update Picker placeholder to be shorter (#6796)
9d91db9
@reidbarber reidbarber mentioned this pull request Aug 21, 2024
Merged
5 tasks
reidbarber added a commit that referenced this pull request Aug 21, 2024
@reidbarber @snowystinger
@solimant @ktabors @mdhmaiti @Andarist
Revert reverts from before latest release (#6926)
859615a 
* Update Picker placeholder to be shorter (#6796)

* feat: Support fragments in collections (#6430)

Co-authored-by: Reid Barber <[email protected]>
Co-authored-by: Robert Snow <[email protected]>

* Exposing prop disabledBehavior to TableView (#6832)

* fix/bug useTablist #5996 (#6023)

* fix/bug useTabist #5996 and added tests

* Extract `ToggleStateProps` type to use only what is needed in `useToggleState` (#3836)

* Extract `ToggleStateProps` type to use only what is needed in `useToggleState`

---------

Co-authored-by: Robert Snow <[email protected]>
Co-authored-by: solimant <[email protected]>
Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: Medhashis Maiti <[email protected]>
Co-authored-by: Mateusz Burzyński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LFDanLu LFDanLu LFDanLu approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees

No one assigned

Labels

needs translations small review Easy to review PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Picker: placeholder string is truncated for some locales when isLoading is set to true

5 participants

@snowystinger @rspbot @LFDanLu @yihuiliao