TableView rows don't re-render if values change other than the key

[rabidpug]

🐛 Bug Report

TableView rows don't re-render when values change if the key does not change.

🤔 Expected Behavior

Rows should re-render if their values change

😯 Current Behavior

Rows don't re-render if their values change

💁 Possible Solution

Should be able to opt out of memoization.

🔦 Context

I have a table where the user selects rows (which by design are identified by their Key, so I have to use the row ID), then clicks a button to approve/reject rows. The rows don't re-render with the changed values.

💻 Code Sample

CodeSandBox demonstrating

🌍 Your Environment

Software	Version(s)
react-spectrum	3.11.2 / 3.0.0-beta.1 (for table)
Browser	Chrome 90
Operating System	Windows 10

[devongovett]

I think the rows actually do re-render, but looks like the cells are not invalidated.

[dannify]

In collection builder we are not rerendering the cells when the row is updating. We might need to force rerender all cells when the value(s) in the row changes.

[LFDanLu]

@rabidpug Looks like this is actually related to StrictMode, removing that makes the TableView rows rerender properly when typing in input field. Definitely something we need to address as a whole w/ our library

[JSanchezIO]

I was experiencing this as well and removing StrictMode didn't change the behavior.

[LFDanLu]

@JSanchezIO Mind sharing a codesandbox of the issue?

[JSanchezIO]

I'm now re-reading the title of this and realize that my issue isn't with <TableView /> but with useTable and its supporting hooks. I can still try to work on a repro if you'd like.

[LFDanLu]

In that case feel free to open a separate issue/discussion and we can help you there.

[LFDanLu]

Was brought up in slack room with https://codesandbox.io/s/tableviewv3-sort-forked-eppm1?file=/src/App.js (slightly modified from the original) as an example, looks like it isn't just a strict mode issue.

[ktabors]

It looks like this is more general than TableView and it was found in ListView. See the https://codesandbox.io/s/listview-item-height-test-forked-w3iwcn. Clicking on an item changes its value and moves it to the end of the list where the item displays the update. If we only update the item, the UI doesn't change.