Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit a91c7bb

Browse files
committed
Code review: support "Find in..." from working set context menu also.
Use CSS class instead of raw <b> tags where filenames are displayed.
1 parent 78e1034 commit a91c7bb

File tree

3 files changed

+14
-5
lines changed

3 files changed

+14
-5
lines changed

src/command/Menus.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -993,6 +993,7 @@ define(function (require, exports, module) {
993993
project_cmenu.addMenuItem(Commands.FILE_NEW);
994994
project_cmenu.addMenuItem(Commands.FILE_NEW_FOLDER);
995995
project_cmenu.addMenuItem(Commands.FILE_RENAME, "F2");
996+
project_cmenu.addMenuDivider();
996997
project_cmenu.addMenuItem(Commands.EDIT_FIND_IN_SUBTREE);
997998

998999
var working_set_cmenu = registerContextMenu(ContextMenuIds.WORKING_SET_MENU);
@@ -1001,6 +1002,8 @@ define(function (require, exports, module) {
10011002
working_set_cmenu.addMenuItem(Commands.FILE_RENAME);
10021003
working_set_cmenu.addMenuItem(Commands.NAVIGATE_SHOW_IN_FILE_TREE);
10031004
working_set_cmenu.addMenuDivider();
1005+
working_set_cmenu.addMenuItem(Commands.EDIT_FIND_IN_SUBTREE);
1006+
working_set_cmenu.addMenuDivider();
10041007
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_ADDED);
10051008
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_NAME);
10061009
working_set_cmenu.addMenuItem(Commands.SORT_WORKINGSET_BY_TYPE);

src/nls/root/strings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,15 @@ define({
108108
"NO_UPDATE_MESSAGE" : "You are running the latest version of {APP_NAME}.",
109109

110110
"FIND_IN_FILES_TITLE" : "for \"{4}\" {5} - {0} {1} in {2} {3}",
111-
"FIND_IN_FILES_SCOPED" : "in <b>{0}</b>",
111+
"FIND_IN_FILES_SCOPED" : "in <span class='dialog-filename'>{0}</span>",
112112
"FIND_IN_FILES_NO_SCOPE" : "in project",
113113
"FIND_IN_FILES_FILE" : "file",
114114
"FIND_IN_FILES_FILES" : "files",
115115
"FIND_IN_FILES_MATCH" : "match",
116116
"FIND_IN_FILES_MATCHES" : "matches",
117117
"FIND_IN_FILES_MORE_THAN" : "More than ",
118118
"FIND_IN_FILES_MAX" : " (showing the first {0} matches)",
119-
"FIND_IN_FILES_FILE_PATH" : "File: <b>{0}</b>",
119+
"FIND_IN_FILES_FILE_PATH" : "File: <span class='dialog-filename'>{0}</span>",
120120
"FIND_IN_FILES_LINE" : "line:&nbsp;{0}",
121121

122122
"ERROR_FETCHING_UPDATE_INFO_TITLE" : "Error getting update info",

src/search/FindInFiles.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -417,10 +417,16 @@ define(function (require, exports, module) {
417417
});
418418
}
419419

420-
/** Search within the file/subtree defined by the project tree selection */
420+
/** Search within the file/subtree defined by the sidebar selection */
421421
function doFindInSubtree() {
422-
var treeSelection = ProjectManager.getSelectedItem();
423-
doFindInFiles(treeSelection);
422+
// Prefer project tree selection, else use working set selection
423+
var selectedEntry = ProjectManager.getSelectedItem();
424+
if (!selectedEntry) {
425+
var doc = DocumentManager.getCurrentDocument();
426+
selectedEntry = (doc && doc.file);
427+
}
428+
429+
doFindInFiles(selectedEntry);
424430
}
425431

426432

0 commit comments

Comments
 (0)