Skip to content

Commit 61850ac

Browse files
committed
Fixed bug in pin error handling, deleted debug prints
1 parent 4140012 commit 61850ac

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

ports/esp32s2/common-hal/displayio/ParallelBus.c

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,16 @@
3434
#include "shared-bindings/microcontroller/__init__.h"
3535

3636
/*
37-
*
3837
* Current pin limitations for ESP32-S2 ParallelBus:
39-
* - data0 pin must be byte aligned (data0 pin options: 0, 8, 16 or 24)
40-
*
38+
* - data0 pin must be byte aligned
4139
*/
4240

4341
void common_hal_displayio_parallelbus_construct(displayio_parallelbus_obj_t* self,
4442
const mcu_pin_obj_t* data0, const mcu_pin_obj_t* command, const mcu_pin_obj_t* chip_select,
4543
const mcu_pin_obj_t* write, const mcu_pin_obj_t* read, const mcu_pin_obj_t* reset) {
4644

4745
uint8_t data_pin = data0->number;
48-
if ( (data_pin % 8 != 0) && (data_pin >= 32) ) {
46+
if (data_pin % 8 != 0) {
4947
mp_raise_ValueError(translate("Data 0 pin must be byte aligned."));
5048
}
5149

@@ -113,20 +111,7 @@ void common_hal_displayio_parallelbus_construct(displayio_parallelbus_obj_t* sel
113111
}
114112

115113

116-
mp_printf(&mp_plat_print, "write_clear: %x, write_set: %x\n", self->write_clear_register, self->write_set_register);
117-
118114
self->write_mask = 1 << (write->number % 32); /* the write pin triggers the LCD to latch the data */
119-
mp_printf(&mp_plat_print, "write_mask: %x\n", self->write_mask);
120-
121-
mp_printf(&mp_plat_print, "out1 register: %x\n", g->out1.val);
122-
mp_printf(&mp_plat_print, "clear a bit\n");
123-
*self->write_clear_register = self->write_mask;
124-
mp_printf(&mp_plat_print, "out1 register: %x\n", g->out1.val);
125-
mp_printf(&mp_plat_print, "write a bit\n");
126-
*self->write_set_register = self->write_mask;
127-
mp_printf(&mp_plat_print, "out1 register: %x\n", g->out1.val);
128-
129-
*self->write_clear_register = self->write_mask;
130115

131116
/* SNIP - common setup of the reset pin, same as from SAMD and NRF ports */
132117
self->reset.base.type = &mp_type_NoneType;

0 commit comments

Comments
 (0)