Skip to content

Commit 5b29821

Browse files
authored
Merge pull request #10 from adafruit/pylint-update
Ran black, updated to pylint 2.x
2 parents a43eab5 + e72fac4 commit 5b29821

File tree

6 files changed

+146
-106
lines changed

6 files changed

+146
-106
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
source actions-ci/install.sh
4141
- name: Pip install pylint, black, & Sphinx
4242
run: |
43-
pip install --force-reinstall pylint==1.9.2 black==19.10b0 Sphinx sphinx-rtd-theme
43+
pip install --force-reinstall pylint black==19.10b0 Sphinx sphinx-rtd-theme
4444
- name: Library version
4545
run: git describe --dirty --always --tags
4646
- name: PyLint

adafruit_touchscreen.py

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,25 +46,37 @@
4646
from digitalio import DigitalInOut
4747
from analogio import AnalogIn
4848

49+
4950
def map_range(x, in_min, in_max, out_min, out_max):
5051
"""
5152
Maps a number from one range to another.
5253
Note: This implementation handles values < in_min differently than arduino's map function does.
5354
:return: Returns value mapped to new range
5455
:rtype: float
5556
"""
56-
mapped = (x-in_min) * (out_max - out_min) / (in_max-in_min) + out_min
57+
mapped = (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min
5758
if out_min <= out_max:
5859
return max(min(mapped, out_max), out_min)
5960
return min(max(mapped, out_max), out_min)
6061

62+
6163
class Touchscreen:
6264
"""A driver for common and inexpensive resistive touchscreens. Analog input
6365
capable pins are required to read the intrinsic potentiometers"""
6466

65-
def __init__(self, x1_pin, x2_pin, y1_pin, y2_pin, *,
66-
x_resistance=None, samples=4, z_threshhold=10000,
67-
calibration=None, size=None):
67+
def __init__(
68+
self,
69+
x1_pin,
70+
x2_pin,
71+
y1_pin,
72+
y2_pin,
73+
*,
74+
x_resistance=None,
75+
samples=4,
76+
z_threshhold=10000,
77+
calibration=None,
78+
size=None
79+
):
6880
"""Create the Touchscreen object. At a minimum you need the 4 pins
6981
that will connect to the 4 contacts on a screen. X and Y are just our
7082
names, you can rotate and flip the data if you like. All pins must be
@@ -98,7 +110,7 @@ def __init__(self, x1_pin, x2_pin, y1_pin, y2_pin, *,
98110
self._zthresh = z_threshhold
99111

100112
@property
101-
def touch_point(self): # pylint: disable=too-many-locals
113+
def touch_point(self): # pylint: disable=too-many-locals
102114
"""A tuple that represents the x, y and z (touch pressure) coordinates
103115
of a touch. Or, None if no touch is detected"""
104116
with DigitalInOut(self._yp_pin) as y_p:
@@ -136,8 +148,8 @@ def touch_point(self): # pylint: disable=too-many-locals
136148
z_1 = x_m.value
137149
with AnalogIn(self._yp_pin) as y_p:
138150
z_2 = y_p.value
139-
#print(z_1, z_2)
140-
z = 65535 - (z_2-z_1)
151+
# print(z_1, z_2)
152+
z = 65535 - (z_2 - z_1)
141153
if z > self._zthresh:
142154
return (x, y, z)
143155
return None

docs/conf.py

Lines changed: 65 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,19 @@
22

33
import os
44
import sys
5-
sys.path.insert(0, os.path.abspath('..'))
5+
6+
sys.path.insert(0, os.path.abspath(".."))
67

78
# -- General configuration ------------------------------------------------
89

910
# Add any Sphinx extension module names here, as strings. They can be
1011
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
1112
# ones.
1213
extensions = [
13-
'sphinx.ext.autodoc',
14-
'sphinx.ext.intersphinx',
15-
'sphinx.ext.napoleon',
16-
'sphinx.ext.todo',
14+
"sphinx.ext.autodoc",
15+
"sphinx.ext.intersphinx",
16+
"sphinx.ext.napoleon",
17+
"sphinx.ext.todo",
1718
]
1819

1920
# TODO: Please Read!
@@ -23,29 +24,32 @@
2324
autodoc_mock_imports = ["analogio"]
2425

2526

26-
intersphinx_mapping = {'python': ('https://docs.python.org/3.4', None),'CircuitPython': ('https://circuitpython.readthedocs.io/en/latest/', None)}
27+
intersphinx_mapping = {
28+
"python": ("https://docs.python.org/3.4", None),
29+
"CircuitPython": ("https://circuitpython.readthedocs.io/en/latest/", None),
30+
}
2731

2832
# Add any paths that contain templates here, relative to this directory.
29-
templates_path = ['_templates']
33+
templates_path = ["_templates"]
3034

31-
source_suffix = '.rst'
35+
source_suffix = ".rst"
3236

3337
# The master toctree document.
34-
master_doc = 'index'
38+
master_doc = "index"
3539

3640
# General information about the project.
37-
project = u'Adafruit Touchscreen Library'
38-
copyright = u'2019 ladyada'
39-
author = u'ladyada'
41+
project = u"Adafruit Touchscreen Library"
42+
copyright = u"2019 ladyada"
43+
author = u"ladyada"
4044

4145
# The version info for the project you're documenting, acts as replacement for
4246
# |version| and |release|, also used in various other places throughout the
4347
# built documents.
4448
#
4549
# The short X.Y version.
46-
version = u'1.0'
50+
version = u"1.0"
4751
# The full version, including alpha/beta/rc tags.
48-
release = u'1.0'
52+
release = u"1.0"
4953

5054
# The language for content autogenerated by Sphinx. Refer to documentation
5155
# for a list of supported languages.
@@ -57,7 +61,7 @@
5761
# List of patterns, relative to source directory, that match files and
5862
# directories to ignore when looking for source files.
5963
# This patterns also effect to html_static_path and html_extra_path
60-
exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store', '.env', 'CODE_OF_CONDUCT.md']
64+
exclude_patterns = ["_build", "Thumbs.db", ".DS_Store", ".env", "CODE_OF_CONDUCT.md"]
6165

6266
# The reST default role (used for this markup: `text`) to use for all
6367
# documents.
@@ -69,7 +73,7 @@
6973
add_function_parentheses = True
7074

7175
# The name of the Pygments (syntax highlighting) style to use.
72-
pygments_style = 'sphinx'
76+
pygments_style = "sphinx"
7377

7478
# If true, `todo` and `todoList` produce output, else they produce nothing.
7579
todo_include_todos = False
@@ -84,68 +88,76 @@
8488
# The theme to use for HTML and HTML Help pages. See the documentation for
8589
# a list of builtin themes.
8690
#
87-
on_rtd = os.environ.get('READTHEDOCS', None) == 'True'
91+
on_rtd = os.environ.get("READTHEDOCS", None) == "True"
8892

8993
if not on_rtd: # only import and set the theme if we're building docs locally
9094
try:
9195
import sphinx_rtd_theme
92-
html_theme = 'sphinx_rtd_theme'
93-
html_theme_path = [sphinx_rtd_theme.get_html_theme_path(), '.']
96+
97+
html_theme = "sphinx_rtd_theme"
98+
html_theme_path = [sphinx_rtd_theme.get_html_theme_path(), "."]
9499
except:
95-
html_theme = 'default'
96-
html_theme_path = ['.']
100+
html_theme = "default"
101+
html_theme_path = ["."]
97102
else:
98-
html_theme_path = ['.']
103+
html_theme_path = ["."]
99104

100105
# Add any paths that contain custom static files (such as style sheets) here,
101106
# relative to this directory. They are copied after the builtin static files,
102107
# so a file named "default.css" will overwrite the builtin "default.css".
103-
html_static_path = ['_static']
108+
html_static_path = ["_static"]
104109

105110
# The name of an image file (relative to this directory) to use as a favicon of
106111
# the docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32
107112
# pixels large.
108113
#
109-
html_favicon = '_static/favicon.ico'
114+
html_favicon = "_static/favicon.ico"
110115

111116
# Output file base name for HTML help builder.
112-
htmlhelp_basename = 'AdafruitTouchscreenLibrarydoc'
117+
htmlhelp_basename = "AdafruitTouchscreenLibrarydoc"
113118

114119
# -- Options for LaTeX output ---------------------------------------------
115120

116121
latex_elements = {
117-
# The paper size ('letterpaper' or 'a4paper').
118-
#
119-
# 'papersize': 'letterpaper',
120-
121-
# The font size ('10pt', '11pt' or '12pt').
122-
#
123-
# 'pointsize': '10pt',
124-
125-
# Additional stuff for the LaTeX preamble.
126-
#
127-
# 'preamble': '',
128-
129-
# Latex figure (float) alignment
130-
#
131-
# 'figure_align': 'htbp',
122+
# The paper size ('letterpaper' or 'a4paper').
123+
#
124+
# 'papersize': 'letterpaper',
125+
# The font size ('10pt', '11pt' or '12pt').
126+
#
127+
# 'pointsize': '10pt',
128+
# Additional stuff for the LaTeX preamble.
129+
#
130+
# 'preamble': '',
131+
# Latex figure (float) alignment
132+
#
133+
# 'figure_align': 'htbp',
132134
}
133135

134136
# Grouping the document tree into LaTeX files. List of tuples
135137
# (source start file, target name, title,
136138
# author, documentclass [howto, manual, or own class]).
137139
latex_documents = [
138-
(master_doc, 'AdafruitTouchscreenLibrary.tex', u'AdafruitTouchscreen Library Documentation',
139-
author, 'manual'),
140+
(
141+
master_doc,
142+
"AdafruitTouchscreenLibrary.tex",
143+
u"AdafruitTouchscreen Library Documentation",
144+
author,
145+
"manual",
146+
),
140147
]
141148

142149
# -- Options for manual page output ---------------------------------------
143150

144151
# One entry per manual page. List of tuples
145152
# (source start file, name, description, authors, manual section).
146153
man_pages = [
147-
(master_doc, 'AdafruitTouchscreenlibrary', u'Adafruit Touchscreen Library Documentation',
148-
[author], 1)
154+
(
155+
master_doc,
156+
"AdafruitTouchscreenlibrary",
157+
u"Adafruit Touchscreen Library Documentation",
158+
[author],
159+
1,
160+
)
149161
]
150162

151163
# -- Options for Texinfo output -------------------------------------------
@@ -154,7 +166,13 @@
154166
# (source start file, target name, title, author,
155167
# dir menu entry, description, category)
156168
texinfo_documents = [
157-
(master_doc, 'AdafruitTouchscreenLibrary', u'Adafruit Touchscreen Library Documentation',
158-
author, 'AdafruitTouchscreenLibrary', 'One line description of project.',
159-
'Miscellaneous'),
169+
(
170+
master_doc,
171+
"AdafruitTouchscreenLibrary",
172+
u"Adafruit Touchscreen Library Documentation",
173+
author,
174+
"AdafruitTouchscreenLibrary",
175+
"One line description of project.",
176+
"Miscellaneous",
177+
),
160178
]

examples/touchscreen_orientation.py

Lines changed: 32 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,31 +8,47 @@
88

99
if rotation == 0:
1010
# -------Rotate 0:
11-
ts = adafruit_touchscreen.Touchscreen(board.TOUCH_XL, board.TOUCH_XR,
12-
board.TOUCH_YD, board.TOUCH_YU,
13-
calibration=((5200, 59000), (5800, 57000)),
14-
size=(320, 240))
11+
ts = adafruit_touchscreen.Touchscreen(
12+
board.TOUCH_XL,
13+
board.TOUCH_XR,
14+
board.TOUCH_YD,
15+
board.TOUCH_YU,
16+
calibration=((5200, 59000), (5800, 57000)),
17+
size=(320, 240),
18+
)
1519

1620
if rotation == 90:
1721
# -------Rotate 90:
18-
ts = adafruit_touchscreen.Touchscreen(board.TOUCH_YU, board.TOUCH_YD,
19-
board.TOUCH_XL, board.TOUCH_XR,
20-
calibration=((5200, 59000), (5800, 57000)),
21-
size=(240, 320))
22+
ts = adafruit_touchscreen.Touchscreen(
23+
board.TOUCH_YU,
24+
board.TOUCH_YD,
25+
board.TOUCH_XL,
26+
board.TOUCH_XR,
27+
calibration=((5200, 59000), (5800, 57000)),
28+
size=(240, 320),
29+
)
2230

2331
if rotation == 180:
2432
# ------Rotate 180:
25-
ts = adafruit_touchscreen.Touchscreen(board.TOUCH_XR, board.TOUCH_XL,
26-
board.TOUCH_YU, board.TOUCH_YD,
27-
calibration=((5200, 59000), (5800, 57000)),
28-
size=(320, 240))
33+
ts = adafruit_touchscreen.Touchscreen(
34+
board.TOUCH_XR,
35+
board.TOUCH_XL,
36+
board.TOUCH_YU,
37+
board.TOUCH_YD,
38+
calibration=((5200, 59000), (5800, 57000)),
39+
size=(320, 240),
40+
)
2941

3042
if rotation == 270:
3143
# ------Rotate 270:
32-
ts = adafruit_touchscreen.Touchscreen(board.TOUCH_YD, board.TOUCH_YU,
33-
board.TOUCH_XR, board.TOUCH_XL,
34-
calibration=((5200, 59000), (5800, 57000)),
35-
size=(240, 320))
44+
ts = adafruit_touchscreen.Touchscreen(
45+
board.TOUCH_YD,
46+
board.TOUCH_YU,
47+
board.TOUCH_XR,
48+
board.TOUCH_XL,
49+
calibration=((5200, 59000), (5800, 57000)),
50+
size=(240, 320),
51+
)
3652

3753
while True:
3854
p = ts.touch_point

examples/touchscreen_simpletest.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@
33

44
# These pins are used as both analog and digital! XL, XR and YU must be analog
55
# and digital capable. YD just need to be digital
6-
ts = adafruit_touchscreen.Touchscreen(board.TOUCH_XL, board.TOUCH_XR,
7-
board.TOUCH_YD, board.TOUCH_YU,
8-
calibration=((5200, 59000), (5800, 57000)),
9-
size=(320, 240))
6+
ts = adafruit_touchscreen.Touchscreen(
7+
board.TOUCH_XL,
8+
board.TOUCH_XR,
9+
board.TOUCH_YD,
10+
board.TOUCH_YU,
11+
calibration=((5200, 59000), (5800, 57000)),
12+
size=(320, 240),
13+
)
1014

1115
while True:
1216
p = ts.touch_point

0 commit comments

Comments
 (0)