diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..21c125c --- /dev/null +++ b/.gitattributes @@ -0,0 +1,11 @@ +# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries +# +# SPDX-License-Identifier: Unlicense + +.py text eol=lf +.rst text eol=lf +.txt text eol=lf +.yaml text eol=lf +.toml text eol=lf +.license text eol=lf +.md text eol=lf diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 70ade69..ff19dde 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,42 +1,21 @@ -# SPDX-FileCopyrightText: 2020 Diego Elio Pettenò +# SPDX-FileCopyrightText: 2024 Justin Myers for Adafruit Industries # # SPDX-License-Identifier: Unlicense repos: - - repo: https://github.com/python/black - rev: 23.3.0 - hooks: - - id: black - - repo: https://github.com/fsfe/reuse-tool - rev: v1.1.2 - hooks: - - id: reuse - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.4.0 + rev: v4.5.0 hooks: - id: check-yaml - id: end-of-file-fixer - id: trailing-whitespace - - repo: https://github.com/pycqa/pylint - rev: v2.17.4 + - repo: https://github.com/astral-sh/ruff-pre-commit + rev: v0.3.4 hooks: - - id: pylint - name: pylint (library code) - types: [python] - args: - - --disable=consider-using-f-string - exclude: "^(docs/|examples/|tests/|setup.py$)" - - id: pylint - name: pylint (example code) - description: Run pylint rules on "examples/*.py" files - types: [python] - files: "^examples/" - args: - - --disable=missing-docstring,invalid-name,consider-using-f-string,duplicate-code - - id: pylint - name: pylint (test code) - description: Run pylint rules on "tests/*.py" files - types: [python] - files: "^tests/" - args: - - --disable=missing-docstring,consider-using-f-string,duplicate-code + - id: ruff-format + - id: ruff + args: ["--fix"] + - repo: https://github.com/fsfe/reuse-tool + rev: v3.0.1 + hooks: + - id: reuse diff --git a/.pylintrc b/.pylintrc deleted file mode 100644 index f945e92..0000000 --- a/.pylintrc +++ /dev/null @@ -1,399 +0,0 @@ -# SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries -# -# SPDX-License-Identifier: Unlicense - -[MASTER] - -# A comma-separated list of package or module names from where C extensions may -# be loaded. Extensions are loading into the active Python interpreter and may -# run arbitrary code -extension-pkg-whitelist= - -# Add files or directories to the ignore-list. They should be base names, not -# paths. -ignore=CVS - -# Add files or directories matching the regex patterns to the ignore-list. The -# regex matches against base names, not paths. -ignore-patterns= - -# Python code to execute, usually for sys.path manipulation such as -# pygtk.require(). -#init-hook= - -# Use multiple processes to speed up Pylint. -jobs=1 - -# List of plugins (as comma separated values of python modules names) to load, -# usually to register additional checkers. -load-plugins=pylint.extensions.no_self_use - -# Pickle collected data for later comparisons. -persistent=yes - -# Specify a configuration file. -#rcfile= - -# Allow loading of arbitrary C extensions. Extensions are imported into the -# active Python interpreter and may run arbitrary code. -unsafe-load-any-extension=no - - -[MESSAGES CONTROL] - -# Only show warnings with the listed confidence levels. Leave empty to show -# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED -confidence= - -# Disable the message, report, category or checker with the given id(s). You -# can either give multiple identifiers separated by comma (,) or put this -# option multiple times (only on the command line, not in the configuration -# file where it should appear only once).You can also use "--disable=all" to -# disable everything first and then reenable specific checks. For example, if -# you want to run only the similarities checker, you can use "--disable=all -# --enable=similarities". If you want to run only the classes checker, but have -# no Warning level messages displayed, use"--disable=all --enable=classes -# --disable=W" -# disable=import-error,raw-checker-failed,bad-inline-option,locally-disabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,deprecated-str-translate-call -disable=raw-checker-failed,bad-inline-option,locally-disabled,file-ignored,suppressed-message,useless-suppression,deprecated-pragma,import-error,pointless-string-statement,unspecified-encoding - -# Enable the message, report, category or checker with the given id(s). You can -# either give multiple identifier separated by comma (,) or put this option -# multiple time (only on the command line, not in the configuration file where -# it should appear only once). See also the "--disable" option for examples. -enable= - - -[REPORTS] - -# Python expression which should return a note less than 10 (10 is the highest -# note). You have access to the variables errors warning, statement which -# respectively contain the number of errors / warnings messages and the total -# number of statements analyzed. This is used by the global evaluation report -# (RP0004). -evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10) - -# Template used to display messages. This is a python new-style format string -# used to format the message information. See doc for all details -#msg-template= - -# Set the output format. Available formats are text, parseable, colorized, json -# and msvs (visual studio).You can also give a reporter class, eg -# mypackage.mymodule.MyReporterClass. -output-format=text - -# Tells whether to display a full report or only the messages -reports=no - -# Activate the evaluation score. -score=yes - - -[REFACTORING] - -# Maximum number of nested blocks for function / method body -max-nested-blocks=5 - - -[LOGGING] - -# Logging modules to check that the string format arguments are in logging -# function parameter format -logging-modules=logging - - -[SPELLING] - -# Spelling dictionary name. Available dictionaries: none. To make it working -# install python-enchant package. -spelling-dict= - -# List of comma separated words that should not be checked. -spelling-ignore-words= - -# A path to a file that contains private dictionary; one word per line. -spelling-private-dict-file= - -# Tells whether to store unknown words to indicated private dictionary in -# --spelling-private-dict-file option instead of raising a message. -spelling-store-unknown-words=no - - -[MISCELLANEOUS] - -# List of note tags to take in consideration, separated by a comma. -# notes=FIXME,XXX,TODO -notes=FIXME,XXX - - -[TYPECHECK] - -# List of decorators that produce context managers, such as -# contextlib.contextmanager. Add to this list to register other decorators that -# produce valid context managers. -contextmanager-decorators=contextlib.contextmanager - -# List of members which are set dynamically and missed by pylint inference -# system, and so shouldn't trigger E1101 when accessed. Python regular -# expressions are accepted. -generated-members= - -# Tells whether missing members accessed in mixin class should be ignored. A -# mixin class is detected if its name ends with "mixin" (case insensitive). -ignore-mixin-members=yes - -# This flag controls whether pylint should warn about no-member and similar -# checks whenever an opaque object is returned when inferring. The inference -# can return multiple potential results while evaluating a Python object, but -# some branches might not be evaluated, which results in partial inference. In -# that case, it might be useful to still emit no-member and other checks for -# the rest of the inferred objects. -ignore-on-opaque-inference=yes - -# List of class names for which member attributes should not be checked (useful -# for classes with dynamically set attributes). This supports the use of -# qualified names. -ignored-classes=optparse.Values,thread._local,_thread._local - -# List of module names for which member attributes should not be checked -# (useful for modules/projects where namespaces are manipulated during runtime -# and thus existing member attributes cannot be deduced by static analysis. It -# supports qualified module names, as well as Unix pattern matching. -ignored-modules=board - -# Show a hint with possible names when a member name was not found. The aspect -# of finding the hint is based on edit distance. -missing-member-hint=yes - -# The minimum edit distance a name should have in order to be considered a -# similar match for a missing member name. -missing-member-hint-distance=1 - -# The total number of similar names that should be taken in consideration when -# showing a hint for a missing member. -missing-member-max-choices=1 - - -[VARIABLES] - -# List of additional names supposed to be defined in builtins. Remember that -# you should avoid to define new builtins when possible. -additional-builtins= - -# Tells whether unused global variables should be treated as a violation. -allow-global-unused-variables=yes - -# List of strings which can identify a callback function by name. A callback -# name must start or end with one of those strings. -callbacks=cb_,_cb - -# A regular expression matching the name of dummy variables (i.e. expectedly -# not used). -dummy-variables-rgx=_+$|(_[a-zA-Z0-9_]*[a-zA-Z0-9]+?$)|dummy|^ignored_|^unused_ - -# Argument names that match this expression will be ignored. Default to name -# with leading underscore -ignored-argument-names=_.*|^ignored_|^unused_ - -# Tells whether we should check for unused import in __init__ files. -init-import=no - -# List of qualified module names which can have objects that can redefine -# builtins. -redefining-builtins-modules=six.moves,future.builtins - - -[FORMAT] - -# Expected format of line ending, e.g. empty (any line ending), LF or CRLF. -# expected-line-ending-format= -expected-line-ending-format=LF - -# Regexp for a line that is allowed to be longer than the limit. -ignore-long-lines=^\s*(# )??$ - -# Number of spaces of indent required inside a hanging or continued line. -indent-after-paren=4 - -# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 -# tab). -indent-string=' ' - -# Maximum number of characters on a single line. -max-line-length=100 - -# Maximum number of lines in a module -max-module-lines=1000 - -# Allow the body of a class to be on the same line as the declaration if body -# contains single statement. -single-line-class-stmt=no - -# Allow the body of an if to be on the same line as the test if there is no -# else. -single-line-if-stmt=no - - -[SIMILARITIES] - -# Ignore comments when computing similarities. -ignore-comments=yes - -# Ignore docstrings when computing similarities. -ignore-docstrings=yes - -# Ignore imports when computing similarities. -ignore-imports=yes - -# Minimum lines number of a similarity. -min-similarity-lines=12 - - -[BASIC] - -# Regular expression matching correct argument names -argument-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - -# Regular expression matching correct attribute names -attr-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - -# Bad variable names which should always be refused, separated by a comma -bad-names=foo,bar,baz,toto,tutu,tata - -# Regular expression matching correct class attribute names -class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ - -# Regular expression matching correct class names -# class-rgx=[A-Z_][a-zA-Z0-9]+$ -class-rgx=[A-Z_][a-zA-Z0-9_]+$ - -# Regular expression matching correct constant names -const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ - -# Minimum line length for functions/classes that require docstrings, shorter -# ones are exempt. -docstring-min-length=-1 - -# Regular expression matching correct function names -function-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - -# Good variable names which should always be accepted, separated by a comma -# good-names=i,j,k,ex,Run,_ -good-names=r,g,b,w,i,j,k,n,x,y,z,ex,ok,Run,_ - -# Include a hint for the correct naming format with invalid-name -include-naming-hint=no - -# Regular expression matching correct inline iteration names -inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ - -# Regular expression matching correct method names -method-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - -# Regular expression matching correct module names -module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - -# Colon-delimited sets of names that determine each other's naming style when -# the name regexes allow several styles. -name-group= - -# Regular expression which should only match function or class names that do -# not require a docstring. -no-docstring-rgx=^_ - -# List of decorators that produce properties, such as abc.abstractproperty. Add -# to this list to register other decorators that produce valid properties. -property-classes=abc.abstractproperty - -# Regular expression matching correct variable names -variable-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - - -[IMPORTS] - -# Allow wildcard imports from modules that define __all__. -allow-wildcard-with-all=no - -# Analyse import fallback blocks. This can be used to support both Python 2 and -# 3 compatible code, which means that the block might have code that exists -# only in one or another interpreter, leading to false positives when analysed. -analyse-fallback-blocks=no - -# Deprecated modules which should not be used, separated by a comma -deprecated-modules=optparse,tkinter.tix - -# Create a graph of external dependencies in the given file (report RP0402 must -# not be disabled) -ext-import-graph= - -# Create a graph of every (i.e. internal and external) dependencies in the -# given file (report RP0402 must not be disabled) -import-graph= - -# Create a graph of internal dependencies in the given file (report RP0402 must -# not be disabled) -int-import-graph= - -# Force import order to recognize a module as part of the standard -# compatibility libraries. -known-standard-library= - -# Force import order to recognize a module as part of a third party library. -known-third-party=enchant - - -[CLASSES] - -# List of method names used to declare (i.e. assign) instance attributes. -defining-attr-methods=__init__,__new__,setUp - -# List of member names, which should be excluded from the protected access -# warning. -exclude-protected=_asdict,_fields,_replace,_source,_make - -# List of valid names for the first argument in a class method. -valid-classmethod-first-arg=cls - -# List of valid names for the first argument in a metaclass class method. -valid-metaclass-classmethod-first-arg=mcs - - -[DESIGN] - -# Maximum number of arguments for function / method -max-args=5 - -# Maximum number of attributes for a class (see R0902). -# max-attributes=7 -max-attributes=11 - -# Maximum number of boolean expressions in a if statement -max-bool-expr=5 - -# Maximum number of branch for function / method body -max-branches=12 - -# Maximum number of locals for function / method body -max-locals=15 - -# Maximum number of parents for a class (see R0901). -max-parents=7 - -# Maximum number of public methods for a class (see R0904). -max-public-methods=20 - -# Maximum number of return / yield for function / method body -max-returns=6 - -# Maximum number of statements in function / method body -max-statements=50 - -# Minimum number of public methods for a class (see R0903). -min-public-methods=1 - - -[EXCEPTIONS] - -# Exceptions that will emit a warning when being caught. Defaults to -# "Exception" -overgeneral-exceptions=builtins.Exception diff --git a/README.rst b/README.rst index 9f8a304..522d068 100644 --- a/README.rst +++ b/README.rst @@ -17,9 +17,9 @@ Introduction :alt: Build Status -.. image:: https://img.shields.io/badge/code%20style-black-000000.svg - :target: https://github.com/psf/black - :alt: Code Style: Black +.. image:: https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/astral-sh/ruff/main/assets/badge/v2.json + :target: https://github.com/astral-sh/ruff + :alt: Code Style: Ruff CircuitPython driver for OV2640 Camera. diff --git a/adafruit_ov2640.py b/adafruit_ov2640.py index 6a001ee..c2ad88c 100644 --- a/adafruit_ov2640.py +++ b/adafruit_ov2640.py @@ -26,7 +26,6 @@ * Adafruit's Bus Device library: https:# github.com/adafruit/Adafruit_CircuitPython_BusDevice """ -# pylint: disable=too-many-lines,unnecessary-lambda-assignment # imports __version__ = "0.0.0+auto.0" @@ -38,14 +37,14 @@ import imagecapture import pwmio from adafruit_bus_device.i2c_device import I2CDevice - from micropython import const try: - from typing import Optional, Union, Type, List + from typing import List, Optional, Type, Union + from busio import I2C - from microcontroller import Pin from circuitpython_typing import WriteableBuffer + from microcontroller import Pin except ImportError: pass @@ -974,16 +973,14 @@ def __get__(self, obj: "_SCCBCameraBase", objtype: Optional[Type] = None) -> int def __set__(self, obj: "_SCCBCameraBase", value: Union[bool, int]) -> None: if value & ~self.mask: - raise ValueError( - f"Value 0x{value:02x} does not fit in mask 0x{self.mask:02x}" - ) + raise ValueError(f"Value 0x{value:02x} does not fit in mask 0x{self.mask:02x}") reg_value = obj._read_bank_register(self.bank, self.reg) reg_value &= ~(self.mask << self.shift) reg_value |= value << self.shift obj._write_register(self.reg, reg_value) -class _SCCBCameraBase: # pylint: disable=too-few-public-methods +class _SCCBCameraBase: def __init__(self, i2c_bus: I2C, i2c_address: int) -> None: self._i2c_device = I2CDevice(i2c_bus, i2c_address) self._bank = None @@ -991,9 +988,7 @@ def __init__(self, i2c_bus: I2C, i2c_address: int) -> None: def _get_reg_bits(self, bank: int, reg: int, shift: int, mask: int) -> int: return (self._read_bank_register(bank, reg) >> shift) & mask - def _set_reg_bits( # pylint: disable=too-many-arguments - self, bank: int, reg: int, shift: int, mask: int, value: int - ) -> None: + def _set_reg_bits(self, bank: int, reg: int, shift: int, mask: int, value: int) -> None: reg_value = self._read_bank_register(bank, reg) reg_value &= ~(mask << shift) reg_value |= value << shift @@ -1036,7 +1031,7 @@ def _read_register(self, reg: int) -> int: return b[0] -class OV2640(_SCCBCameraBase): # pylint: disable=too-many-instance-attributes +class OV2640(_SCCBCameraBase): """Library for the OV2640 digital camera""" test_pattern = _RegBits(_BANK_SENSOR, _COM7, 1, 1) @@ -1058,7 +1053,7 @@ def __init__( mclk_frequency: int = 20_000_000, i2c_address: int = 0x30, size: int = OV2640_SIZE_QQVGA, - ): # pylint: disable=too-many-arguments + ): """ Args: i2c_bus (busio.I2C): The I2C bus used to configure the OV2640 @@ -1268,7 +1263,7 @@ def product_version(self) -> int: """Get the version (VER) register. The expected value is 0x41.""" return self._read_bank_register(_BANK_SENSOR, _REG_VER) - def _set_window( # pylint: disable=too-many-arguments, too-many-locals + def _set_window( self, mode: int, offset_x: int, diff --git a/docs/api.rst b/docs/api.rst index 6f8e980..2a29ae9 100644 --- a/docs/api.rst +++ b/docs/api.rst @@ -4,5 +4,8 @@ .. If your library file(s) are nested in a directory (e.g. /adafruit_foo/foo.py) .. use this format as the module name: "adafruit_foo.foo" +API Reference +############# + .. automodule:: adafruit_ov2640 :members: diff --git a/docs/conf.py b/docs/conf.py index ba21855..6a566dc 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -1,12 +1,10 @@ -# -*- coding: utf-8 -*- - # SPDX-FileCopyrightText: 2017 Scott Shawcroft, written for Adafruit Industries # # SPDX-License-Identifier: MIT +import datetime import os import sys -import datetime sys.path.insert(0, os.path.abspath("..")) @@ -55,9 +53,7 @@ creation_year = "2021" current_year = str(datetime.datetime.now().year) year_duration = ( - current_year - if current_year == creation_year - else creation_year + " - " + current_year + current_year if current_year == creation_year else creation_year + " - " + current_year ) copyright = year_duration + " Jeff Epler" author = "Jeff Epler" diff --git a/examples/ov2640_aio_kaluga1_3.py b/examples/ov2640_aio_kaluga1_3.py index 55389a4..f71443f 100644 --- a/examples/ov2640_aio_kaluga1_3.py +++ b/examples/ov2640_aio_kaluga1_3.py @@ -24,12 +24,13 @@ import time from os import getenv +import adafruit_connection_manager +import adafruit_minimqtt.adafruit_minimqtt as MQTT import board import busio import wifi -import adafruit_connection_manager -import adafruit_minimqtt.adafruit_minimqtt as MQTT from adafruit_io.adafruit_io import IO_MQTT + import adafruit_ov2640 feed_name = "image" diff --git a/examples/ov2640_aio_saola.py b/examples/ov2640_aio_saola.py index f517e98..86c64f5 100644 --- a/examples/ov2640_aio_saola.py +++ b/examples/ov2640_aio_saola.py @@ -20,12 +20,13 @@ import time from os import getenv +import adafruit_connection_manager +import adafruit_minimqtt.adafruit_minimqtt as MQTT import board import busio import wifi -import adafruit_connection_manager -import adafruit_minimqtt.adafruit_minimqtt as MQTT from adafruit_io.adafruit_io import IO_MQTT + import adafruit_ov2640 feed_name = "image-saola-ov2640" diff --git a/examples/ov2640_bmp_sd_kaluga1_3.py b/examples/ov2640_bmp_sd_kaluga1_3.py index 6ae374b..1d5ba4a 100644 --- a/examples/ov2640_bmp_sd_kaluga1_3.py +++ b/examples/ov2640_bmp_sd_kaluga1_3.py @@ -27,7 +27,6 @@ import os import struct -import ulab.numpy as np import analogio import board @@ -35,6 +34,8 @@ import displayio import sdcardio import storage +import ulab.numpy as np + import adafruit_ov2640 # Nominal voltages of several of the buttons on the audio daughterboard @@ -56,13 +57,13 @@ ) _INIT_SEQUENCE = ( b"\x01\x80\x80" # Software reset then delay 0x80 (128ms) - b"\xEF\x03\x03\x80\x02" - b"\xCF\x03\x00\xC1\x30" - b"\xED\x04\x64\x03\x12\x81" - b"\xE8\x03\x85\x00\x78" - b"\xCB\x05\x39\x2C\x00\x34\x02" - b"\xF7\x01\x20" - b"\xEA\x02\x00\x00" + b"\xef\x03\x03\x80\x02" + b"\xcf\x03\x00\xc1\x30" + b"\xed\x04\x64\x03\x12\x81" + b"\xe8\x03\x85\x00\x78" + b"\xcb\x05\x39\x2c\x00\x34\x02" + b"\xf7\x01\x20" + b"\xea\x02\x00\x00" b"\xc0\x01\x23" # Power control VRH[5:0] b"\xc1\x01\x10" # Power control SAP[2:0];BT[3:0] b"\xc5\x02\x3e\x28" # VCM control @@ -72,17 +73,15 @@ b"\x3a\x01\x55" # COLMOD: Pixel Format Set b"\xb1\x02\x00\x18" # Frame Rate Control (In Normal Mode/Full Colors) b"\xb6\x03\x08\x82\x27" # Display Function Control - b"\xF2\x01\x00" # 3Gamma Function Disable + b"\xf2\x01\x00" # 3Gamma Function Disable b"\x26\x01\x01" # Gamma curve selected - b"\xe0\x0f\x0F\x31\x2B\x0C\x0E\x08\x4E\xF1\x37\x07\x10\x03\x0E\x09\x00" # Set Gamma - b"\xe1\x0f\x00\x0E\x14\x03\x11\x07\x31\xC1\x48\x08\x0F\x0C\x31\x36\x0F" # Set Gamma + b"\xe0\x0f\x0f\x31\x2b\x0c\x0e\x08\x4e\xf1\x37\x07\x10\x03\x0e\x09\x00" # Set Gamma + b"\xe1\x0f\x00\x0e\x14\x03\x11\x07\x31\xc1\x48\x08\x0f\x0c\x31\x36\x0f" # Set Gamma b"\x11\x80\x78" # Exit Sleep then delay 0x78 (120ms) b"\x29\x80\x78" # Display on then delay 0x78 (120ms) ) -display = displayio.Display( - display_bus, _INIT_SEQUENCE, width=320, height=240, auto_refresh=False -) +display = displayio.Display(display_bus, _INIT_SEQUENCE, width=320, height=240, auto_refresh=False) bus = busio.I2C(scl=board.CAMERA_SIOC, sda=board.CAMERA_SIOD) cam = adafruit_ov2640.OV2640( @@ -104,9 +103,7 @@ bitmap = displayio.Bitmap(320, 240, 65536) tg = displayio.TileGrid( bitmap, - pixel_shader=displayio.ColorConverter( - input_colorspace=displayio.Colorspace.RGB565_SWAPPED - ), + pixel_shader=displayio.ColorConverter(input_colorspace=displayio.Colorspace.RGB565_SWAPPED), ) g.append(tg) display.root_group = g @@ -131,14 +128,14 @@ def exists(filename): def open_next_image(extension="jpg"): - global _image_counter # pylint: disable=global-statement + global _image_counter # noqa: PLW0603 while True: filename = f"/sd/img{_image_counter:04d}.{extension}" _image_counter += 1 if exists(filename): continue print("#", filename) - return open(filename, "wb") # pylint: disable=consider-using-with + return open(filename, "wb") ### These routines are for writing BMP files in the RGB565 or BGR565 formats. @@ -205,7 +202,7 @@ def capture_image_bmp(the_bitmap): old_record_pressed = True while True: - a_voltage = a.value * a.reference_voltage / 65535 # pylint: disable=no-member + a_voltage = a.value * a.reference_voltage / 65535 cam.capture(bitmap) bitmap.dirty() diff --git a/examples/ov2640_directio_kaluga1_3_ili9341.py b/examples/ov2640_directio_kaluga1_3_ili9341.py index 40d5643..287b360 100644 --- a/examples/ov2640_directio_kaluga1_3_ili9341.py +++ b/examples/ov2640_directio_kaluga1_3_ili9341.py @@ -34,6 +34,7 @@ import displayio import sdcardio import storage + import adafruit_ov2640 V_MODE = 1.98 @@ -54,13 +55,13 @@ ) _INIT_SEQUENCE = ( b"\x01\x80\x80" # Software reset then delay 0x80 (128ms) - b"\xEF\x03\x03\x80\x02" - b"\xCF\x03\x00\xC1\x30" - b"\xED\x04\x64\x03\x12\x81" - b"\xE8\x03\x85\x00\x78" - b"\xCB\x05\x39\x2C\x00\x34\x02" - b"\xF7\x01\x20" - b"\xEA\x02\x00\x00" + b"\xef\x03\x03\x80\x02" + b"\xcf\x03\x00\xc1\x30" + b"\xed\x04\x64\x03\x12\x81" + b"\xe8\x03\x85\x00\x78" + b"\xcb\x05\x39\x2c\x00\x34\x02" + b"\xf7\x01\x20" + b"\xea\x02\x00\x00" b"\xc0\x01\x23" # Power control VRH[5:0] b"\xc1\x01\x10" # Power control SAP[2:0];BT[3:0] b"\xc5\x02\x3e\x28" # VCM control @@ -70,10 +71,10 @@ b"\x3a\x01\x55" # COLMOD: Pixel Format Set b"\xb1\x02\x00\x18" # Frame Rate Control (In Normal Mode/Full Colors) b"\xb6\x03\x08\x82\x27" # Display Function Control - b"\xF2\x01\x00" # 3Gamma Function Disable + b"\xf2\x01\x00" # 3Gamma Function Disable b"\x26\x01\x01" # Gamma curve selected - b"\xe0\x0f\x0F\x31\x2B\x0C\x0E\x08\x4E\xF1\x37\x07\x10\x03\x0E\x09\x00" # Set Gamma - b"\xe1\x0f\x00\x0E\x14\x03\x11\x07\x31\xC1\x48\x08\x0F\x0C\x31\x36\x0F" # Set Gamma + b"\xe0\x0f\x0f\x31\x2b\x0c\x0e\x08\x4e\xf1\x37\x07\x10\x03\x0e\x09\x00" # Set Gamma + b"\xe1\x0f\x00\x0e\x14\x03\x11\x07\x31\xc1\x48\x08\x0f\x0c\x31\x36\x0f" # Set Gamma b"\x11\x80\x78" # Exit Sleep then delay 0x78 (120ms) b"\x29\x80\x78" # Display on then delay 0x78 (120ms) ) @@ -122,14 +123,14 @@ def exists(filename): def open_next_image(): - global _image_counter # pylint: disable=global-statement + global _image_counter # noqa: PLW0603 while True: filename = f"/sd/img{_image_counter:04d}.jpg" _image_counter += 1 if exists(filename): continue print("#", filename) - return open(filename, "wb") # pylint: disable=consider-using-with + return open(filename, "wb") def capture_image(): @@ -157,7 +158,7 @@ def main(): display_bus.send(42, struct.pack(">hh", 0, 319)) display_bus.send(43, struct.pack(">hh", 0, 239)) while True: - a_voltage = a.value * a.reference_voltage / 65535 # pylint: disable=no-member + a_voltage = a.value * a.reference_voltage / 65535 record_pressed = abs(a_voltage - V_RECORD) < 0.05 if record_pressed: capture_image() diff --git a/examples/ov2640_displayio_kaluga1_3_ili9341.py b/examples/ov2640_displayio_kaluga1_3_ili9341.py index dc6ce94..166d3da 100644 --- a/examples/ov2640_displayio_kaluga1_3_ili9341.py +++ b/examples/ov2640_displayio_kaluga1_3_ili9341.py @@ -20,10 +20,10 @@ import busio import displayio from adafruit_ili9341 import ILI9341 + import adafruit_ov2640 # Pylint is unable to see that the "size" property of OV2640_GrandCentral exists -# pylint: disable=attribute-defined-outside-init # Release any resources currently in use for the displays displayio.release_displays() @@ -57,9 +57,7 @@ bitmap = displayio.Bitmap(320, 240, 65536) tg = displayio.TileGrid( bitmap, - pixel_shader=displayio.ColorConverter( - input_colorspace=displayio.Colorspace.BGR565_SWAPPED - ), + pixel_shader=displayio.ColorConverter(input_colorspace=displayio.Colorspace.BGR565_SWAPPED), ) g.append(tg) display.root_group = g diff --git a/examples/ov2640_displayio_kaluga1_3_ili9341_ulab.py b/examples/ov2640_displayio_kaluga1_3_ili9341_ulab.py index 0c6fafc..db4b9a4 100644 --- a/examples/ov2640_displayio_kaluga1_3_ili9341_ulab.py +++ b/examples/ov2640_displayio_kaluga1_3_ili9341_ulab.py @@ -22,12 +22,12 @@ import board import busio import displayio -from adafruit_ili9341 import ILI9341 import ulab.numpy as np +from adafruit_ili9341 import ILI9341 + import adafruit_ov2640 # Pylint is unable to see that the "size" property of OV2640_GrandCentral exists -# pylint: disable=attribute-defined-outside-init # Release any resources currently in use for the displays displayio.release_displays() @@ -62,9 +62,7 @@ arr = np.frombuffer(bitmap, dtype=np.uint16) tg = displayio.TileGrid( bitmap, - pixel_shader=displayio.ColorConverter( - input_colorspace=displayio.Colorspace.RGB565_SWAPPED - ), + pixel_shader=displayio.ColorConverter(input_colorspace=displayio.Colorspace.RGB565_SWAPPED), ) g.append(tg) display.root_group = g diff --git a/examples/ov2640_displayio_kaluga1_3_st7789.py b/examples/ov2640_displayio_kaluga1_3_st7789.py index 61ee9fe..95fdac7 100644 --- a/examples/ov2640_displayio_kaluga1_3_st7789.py +++ b/examples/ov2640_displayio_kaluga1_3_st7789.py @@ -21,10 +21,10 @@ import busio import displayio from adafruit_st7789 import ST7789 + import adafruit_ov2640 # Pylint is unable to see that the "size" property of OV2640_GrandCentral exists -# pylint: disable=attribute-defined-outside-init # Release any resources currently in use for the displays displayio.release_displays() @@ -33,9 +33,7 @@ display_bus = displayio.FourWire( spi, command=board.LCD_D_C, chip_select=board.LCD_CS, reset=board.LCD_RST ) -display = ST7789( - display_bus, width=320, height=240, rotation=90, reverse_bytes_in_word=True -) +display = ST7789(display_bus, width=320, height=240, rotation=90, reverse_bytes_in_word=True) bus = busio.I2C(scl=board.CAMERA_SIOC, sda=board.CAMERA_SIOD) cam = adafruit_ov2640.OV2640( @@ -60,9 +58,7 @@ bitmap = displayio.Bitmap(320, 240, 65536) tg = displayio.TileGrid( bitmap, - pixel_shader=displayio.ColorConverter( - input_colorspace=displayio.Colorspace.BGR565_SWAPPED - ), + pixel_shader=displayio.ColorConverter(input_colorspace=displayio.Colorspace.BGR565_SWAPPED), ) g.append(tg) display.root_group = g diff --git a/examples/ov2640_displayio_pico_st7789_2in.py b/examples/ov2640_displayio_pico_st7789_2in.py index e36c501..4070bcb 100644 --- a/examples/ov2640_displayio_pico_st7789_2in.py +++ b/examples/ov2640_displayio_pico_st7789_2in.py @@ -8,20 +8,21 @@ """ import time + +import board +import busio +import digitalio +from adafruit_st7789 import ST7789 from displayio import ( Bitmap, + ColorConverter, + Colorspace, + FourWire, Group, TileGrid, - FourWire, release_displays, - ColorConverter, - Colorspace, ) -from adafruit_st7789 import ST7789 -import board -import busio -import digitalio import adafruit_ov2640 release_displays() @@ -72,9 +73,7 @@ raise SystemExit("Could not allocate a bitmap") g = Group(scale=1, x=(width - cam.width) // 2, y=(height - cam.height) // 2) -tg = TileGrid( - bitmap, pixel_shader=ColorConverter(input_colorspace=Colorspace.BGR565_SWAPPED) -) +tg = TileGrid(bitmap, pixel_shader=ColorConverter(input_colorspace=Colorspace.BGR565_SWAPPED)) g.append(tg) display.root_group = g diff --git a/examples/ov2640_jpeg_kaluga1_3.py b/examples/ov2640_jpeg_kaluga1_3.py index c3d3ff6..365a44b 100644 --- a/examples/ov2640_jpeg_kaluga1_3.py +++ b/examples/ov2640_jpeg_kaluga1_3.py @@ -19,8 +19,8 @@ import board import busio -import adafruit_ov2640 +import adafruit_ov2640 bus = busio.I2C(scl=board.CAMERA_SIOC, sda=board.CAMERA_SIOD) cam = adafruit_ov2640.OV2640( diff --git a/examples/ov2640_jpeg_kaluga1_3_boot.py b/examples/ov2640_jpeg_kaluga1_3_boot.py index ff22faf..2a872fb 100644 --- a/examples/ov2640_jpeg_kaluga1_3_boot.py +++ b/examples/ov2640_jpeg_kaluga1_3_boot.py @@ -17,7 +17,7 @@ V_RECORD = 2.41 a = analogio.AnalogIn(board.IO6) -a_voltage = a.value * a.reference_voltage / 65535 # pylint: disable=no-member +a_voltage = a.value * a.reference_voltage / 65535 if abs(a_voltage - V_MODE) > 0.05: # If mode is NOT pressed... print("storage writable by CircuitPython") storage.remount("/", readonly=False) diff --git a/examples/ov2640_jpeg_sd_kaluga1_3.py b/examples/ov2640_jpeg_sd_kaluga1_3.py index 693ad99..ad89709 100644 --- a/examples/ov2640_jpeg_sd_kaluga1_3.py +++ b/examples/ov2640_jpeg_sd_kaluga1_3.py @@ -36,6 +36,7 @@ import sdcardio import storage from adafruit_ili9341 import ILI9341 + import adafruit_ov2640 V_MODE = 1.98 @@ -75,9 +76,7 @@ bitmap = displayio.Bitmap(320, 240, 65536) tg = displayio.TileGrid( bitmap, - pixel_shader=displayio.ColorConverter( - input_colorspace=displayio.Colorspace.BGR565_SWAPPED - ), + pixel_shader=displayio.ColorConverter(input_colorspace=displayio.Colorspace.BGR565_SWAPPED), ) g.append(tg) display.root_group = g @@ -103,14 +102,14 @@ def exists(filename): def open_next_image(): - global _image_counter # pylint: disable=global-statement + global _image_counter # noqa: PLW0603 while True: filename = f"/sd/img{_image_counter:04d}.jpg" _image_counter += 1 if exists(filename): continue print("#", filename) - return open(filename, "wb") # pylint: disable=consider-using-with + return open(filename, "wb") def capture_image(): @@ -133,7 +132,7 @@ def capture_image(): display.auto_refresh = False while True: - a_voltage = a.value * a.reference_voltage / 65535 # pylint: disable=no-member + a_voltage = a.value * a.reference_voltage / 65535 record_pressed = abs(a_voltage - V_RECORD) < 0.05 if record_pressed: capture_image() diff --git a/examples/ov2640_jpeg_sd_pico_st7789_2in.py b/examples/ov2640_jpeg_sd_pico_st7789_2in.py index e5105c1..4b264c1 100644 --- a/examples/ov2640_jpeg_sd_pico_st7789_2in.py +++ b/examples/ov2640_jpeg_sd_pico_st7789_2in.py @@ -22,23 +22,25 @@ Press the "Record" button on the audio daughterboard to take a photo. """ -import time import os +import time + +import board +import busio +import digitalio +import sdcardio +import storage +from adafruit_st7789 import ST7789 from displayio import ( Bitmap, + ColorConverter, + Colorspace, + FourWire, Group, TileGrid, - FourWire, release_displays, - ColorConverter, - Colorspace, ) -from adafruit_st7789 import ST7789 -import board -import busio -import digitalio -import sdcardio -import storage + import adafruit_ov2640 release_displays() @@ -98,9 +100,7 @@ raise SystemExit("Could not allocate a bitmap") g = Group(scale=1, x=(width - cam.width) // 2, y=(height - cam.height) // 2) -tg = TileGrid( - bitmap, pixel_shader=ColorConverter(input_colorspace=Colorspace.RGB565_SWAPPED) -) +tg = TileGrid(bitmap, pixel_shader=ColorConverter(input_colorspace=Colorspace.RGB565_SWAPPED)) g.append(tg) display.root_group = g @@ -119,14 +119,14 @@ def exists(filename): def open_next_image(): - global _image_counter # pylint: disable=global-statement + global _image_counter # noqa: PLW0603 while True: filename = f"/sd/img{_image_counter:04d}.jpg" _image_counter += 1 if exists(filename): continue print("#", filename) - return open(filename, "wb") # pylint: disable=consider-using-with + return open(filename, "wb") def capture_image(): diff --git a/examples/ov2640_simpletest.py b/examples/ov2640_simpletest.py index f6c4865..fca2019 100644 --- a/examples/ov2640_simpletest.py +++ b/examples/ov2640_simpletest.py @@ -23,8 +23,8 @@ import sys import time -import busio import board +import busio import adafruit_ov2640 diff --git a/ruff.toml b/ruff.toml new file mode 100644 index 0000000..36332ff --- /dev/null +++ b/ruff.toml @@ -0,0 +1,105 @@ +# SPDX-FileCopyrightText: 2024 Tim Cocks for Adafruit Industries +# +# SPDX-License-Identifier: MIT + +target-version = "py38" +line-length = 100 + +[lint] +preview = true +select = ["I", "PL", "UP"] + +extend-select = [ + "D419", # empty-docstring + "E501", # line-too-long + "W291", # trailing-whitespace + "PLC0414", # useless-import-alias + "PLC2401", # non-ascii-name + "PLC2801", # unnecessary-dunder-call + "PLC3002", # unnecessary-direct-lambda-call + "E999", # syntax-error + "PLE0101", # return-in-init + "F706", # return-outside-function + "F704", # yield-outside-function + "PLE0116", # continue-in-finally + "PLE0117", # nonlocal-without-binding + "PLE0241", # duplicate-bases + "PLE0302", # unexpected-special-method-signature + "PLE0604", # invalid-all-object + "PLE0605", # invalid-all-format + "PLE0643", # potential-index-error + "PLE0704", # misplaced-bare-raise + "PLE1141", # dict-iter-missing-items + "PLE1142", # await-outside-async + "PLE1205", # logging-too-many-args + "PLE1206", # logging-too-few-args + "PLE1307", # bad-string-format-type + "PLE1310", # bad-str-strip-call + "PLE1507", # invalid-envvar-value + "PLE2502", # bidirectional-unicode + "PLE2510", # invalid-character-backspace + "PLE2512", # invalid-character-sub + "PLE2513", # invalid-character-esc + "PLE2514", # invalid-character-nul + "PLE2515", # invalid-character-zero-width-space + "PLR0124", # comparison-with-itself + "PLR0202", # no-classmethod-decorator + "PLR0203", # no-staticmethod-decorator + "UP004", # useless-object-inheritance + "PLR0206", # property-with-parameters + "PLR0904", # too-many-public-methods + "PLR0911", # too-many-return-statements + "PLR0912", # too-many-branches + "PLR0913", # too-many-arguments + "PLR0914", # too-many-locals + "PLR0915", # too-many-statements + "PLR0916", # too-many-boolean-expressions + "PLR1702", # too-many-nested-blocks + "PLR1704", # redefined-argument-from-local + "PLR1711", # useless-return + "C416", # unnecessary-comprehension + "PLR1733", # unnecessary-dict-index-lookup + "PLR1736", # unnecessary-list-index-lookup + + # ruff reports this rule is unstable + #"PLR6301", # no-self-use + + "PLW0108", # unnecessary-lambda + "PLW0120", # useless-else-on-loop + "PLW0127", # self-assigning-variable + "PLW0129", # assert-on-string-literal + "B033", # duplicate-value + "PLW0131", # named-expr-without-context + "PLW0245", # super-without-brackets + "PLW0406", # import-self + "PLW0602", # global-variable-not-assigned + "PLW0603", # global-statement + "PLW0604", # global-at-module-level + + # fails on the try: import typing used by libraries + #"F401", # unused-import + + "F841", # unused-variable + "E722", # bare-except + "PLW0711", # binary-op-exception + "PLW1501", # bad-open-mode + "PLW1508", # invalid-envvar-default + "PLW1509", # subprocess-popen-preexec-fn + "PLW2101", # useless-with-lock + "PLW3301", # nested-min-max +] + +ignore = [ + "PLR2004", # magic-value-comparison + "UP030", # format literals + "PLW1514", # unspecified-encoding + "PLR0913", # too-many-arguments + "PLR0915", # too-many-statements + "PLR0917", # too-many-positional-arguments + "PLR0904", # too-many-public-methods + "PLR0912", # too-many-branches + "PLR0916", # too-many-boolean-expressions +] + +[format] +line-ending = "lf"