From af08521bc8a688a32a767bf1af8a674ab294d127 Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Fri, 3 Jun 2022 11:56:10 -0400 Subject: [PATCH 1/3] Update adafruit_logging.py --- adafruit_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_logging.py b/adafruit_logging.py index 0217e8b..34160a1 100644 --- a/adafruit_logging.py +++ b/adafruit_logging.py @@ -215,7 +215,7 @@ def addHandler(self, hdlr: Handler): *NOTE* this is slightly different from the CPython equivalent which adds the handler rather than replacing it. - :param LoggingHandler handler: the handler + :param Handler hdlr: the handler """ self._handler = hdlr From 782884484453a827e9769910670f5bbe3634a43b Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Fri, 3 Jun 2022 12:34:44 -0400 Subject: [PATCH 2/3] Only log if there is a handler --- adafruit_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_logging.py b/adafruit_logging.py index 34160a1..99f1771 100644 --- a/adafruit_logging.py +++ b/adafruit_logging.py @@ -233,7 +233,7 @@ def log(self, level: int, msg: str, *args): :param args: arguments to ``format_string.format()``; can be empty """ - if level >= self._level: + if _handler and level >= self._level: self._handler._emit(level, msg % args) # pylint: disable=protected-access def debug(self, msg: str, *args): From ea091f394ea4eb22fad5e5deb911fd439482b9d3 Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Fri, 3 Jun 2022 13:00:23 -0400 Subject: [PATCH 3/3] Add missing use of self --- adafruit_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_logging.py b/adafruit_logging.py index 99f1771..5430b97 100644 --- a/adafruit_logging.py +++ b/adafruit_logging.py @@ -233,7 +233,7 @@ def log(self, level: int, msg: str, *args): :param args: arguments to ``format_string.format()``; can be empty """ - if _handler and level >= self._level: + if self._handler and level >= self._level: self._handler._emit(level, msg % args) # pylint: disable=protected-access def debug(self, msg: str, *args):