Skip to content

mirror option does not work correctly #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
thomasmey opened this issue Apr 24, 2025 · 1 comment
Open
2 of 5 tasks

mirror option does not work correctly #1285

thomasmey opened this issue Apr 24, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@thomasmey
Copy link

the mirror option does not work, it has those bugs:

  1. To the mirror URL silently the path segment "/dist" is appended, this is bad and assumes that the mirror URL is under full control, but in case that the mirror URL mirrors "/dist" path directly the mirror option cannot be used anymore, e.g. https://mirror.example.com/node-dist/ will mirror https://nodejs.org/dist
  2. When running in a self hosted action runner in private network without direct internet connectivity, the mirror option does not work. The getInfoFromManifest will timeout waiting for GitHub to not be reachable and the else branch for "Falling back to download directly from ' will never been reached.

Action version:
v4

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Repro steps:
A description with steps to reproduce the issue. If you have a public example or repo to share, please provide the link.

Expected behavior:
A description of what you expected to happen.

Actual behavior:
A description of what is actually happening.

@thomasmey thomasmey added bug Something isn't working needs triage labels Apr 24, 2025
@aparnajyothi-y
Copy link
Contributor

Hello @thomasmey, Thank you for creating this issue and we will look into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants