From d6ab64a30ddcd481da69e331b016dd00d11a9206 Mon Sep 17 00:00:00 2001 From: Graham Campbell Date: Fri, 3 Jul 2020 23:52:35 +0100 Subject: [PATCH] Fix getApiLimit in a way that variables only have one type --- lib/Github/HttpClient/Message/ResponseMediator.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/Github/HttpClient/Message/ResponseMediator.php b/lib/Github/HttpClient/Message/ResponseMediator.php index b9e8563d11a..7cc15035e84 100644 --- a/lib/Github/HttpClient/Message/ResponseMediator.php +++ b/lib/Github/HttpClient/Message/ResponseMediator.php @@ -56,9 +56,15 @@ public static function getPagination(ResponseInterface $response) */ public static function getApiLimit(ResponseInterface $response) { - $remainingCalls = self::getHeader($response, 'X-RateLimit-Remaining'); + $remainingCallsHeader = self::getHeader($response, 'X-RateLimit-Remaining'); - if (null !== $remainingCalls && 1 > $remainingCalls) { + if (null === $remainingCallsHeader) { + return null; + } + + $remainingCalls = (int) $remainingCallsHeader; + + if (1 > $remainingCalls) { throw new ApiLimitExceedException((int) $remainingCalls); }